[PATCH, PR71602] Give error for invalid va_list argument to va_arg

2016-06-22 Tom de Vries <t...@codesourcery.com> PR c/71602 * c-common.c (build_va_arg): Add comp_types parameter. Give error for invalid va_list argument. * c-common.h (build_va_arg): Add comp_types parameter. * c-typeck.c (va_list_comptypes): New function. (c_build_va_arg

[Commited, PR69069] Add missing phi args in create_parallel_loop

in the same function. This patch fixes the problem by setting the missing phi arguments in create_parallel_loop. Bootstrapped and reg-tested on x86_64. Committed to trunk. Thanks, - Tom Add missing phi args in create_parallel_loop 2016-01-07 Tom de Vries <t...@codesourcery.com> PR tree

[Committed, PR69039] Only allow single exit phi for reduction in try_create_reduction_list

reg-tested on x86_64. Committed to trunk. Thanks, - Tom Only allow single exit phi for reduction in try_create_reduction_list 2016-01-07 Tom de Vries <t...@codesourcery.com> PR tree-optimization/69039 * tree-parloops.c (try_create_reduction_list): Only allow single exit phi for reduction.

[Committed, PR69062] Don't parallelize loops containing phis with addr_exprs

ng out of parallelizing loops with a phi with an address expression in a phi argument. Bootstrapped and reg-tested on x86_64. Committed to trunk. Thanks, - Tom Don't parallelize loops containing phis with addr_exprs 2016-01-07 Tom de Vries <t...@codesourcery.com> PR tree-optimi

[gomp4, PR68977, Committed] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

in ssa mode if seen_error in oacc_xform_loop 2016-01-13 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68977 * omp-low.c (oacc_xform_loop): Handle seen_error () == true. --- gcc/ChangeLog.gomp | 5 + gcc/omp-low.c | 7 ++- 2 files changed, 11 insertions(+), 1 de

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

On 13/01/16 09:42, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: >On 12/01/16 14:04, Richard Biener wrote: > >On Tue, 12 Jan 2016, Tom de Vries wrote: > > > > >On 12/01/16 12:22, Richard Biener wrote: > > > >Doesnt' the same issue apply

[PATCH, PR68976] Use reaching def phi arg in sese_add_exit_phis_edge

86_64. OK for trunk? Thanks, - Tom Use reaching def phi arg in sese_add_exit_phis_edge 2016-01-15 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68976 * sese.c (sese_add_exit_phis_edge): Find phi arg for true_edge with reaching def, if not renamed. (sese_insert_phis_f

[PING][RFC] Use gfc_decl_attributes in fortran frontend

On 17/12/15 13:08, Tom de Vries wrote: Hi, Consider this patch, which reduces max_len of the oacc function attribute to 0: ... diff --git a/gcc/fortran/f95-lang.c b/gcc/fortran/f95-lang.c index 8556b70..60f4ad3 100644 --- a/gcc/fortran/f95-lang.c +++ b/gcc/fortran/f95-lang.c @@ -93,7 +93,7

[PING^2][PATCH, 3/16] Ignore reduction clause on kernels directive

On 24/11/15 13:21, Tom de Vries wrote: On 09/11/15 16:50, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series

[PING^2][PATCH, 12/16] Handle acc loop directive

On 24/11/15 13:26, Tom de Vries wrote: On 09/11/15 21:06, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series

[Committed] Allow pass_parallelize_loops to be run outside the loop pipeline

that. Bootstrapped and reg-tested on x86_64. Committed to trunk. Thanks, - Tom Allow pass_parallelize_loops to be run outside the loop pipeline 2016-01-18 Tom de Vries <t...@codesourcery.com> * tree-parloops.c (pass_parallelize_loops::execute): Allow pass_parallelize_loops to be run o

[committed] Add oacc_kernels_p argument to pass_parallelize_loops

[was: Re: [PIING][PATCH, 9/16] Add pass_parallelize_loops_oacc_kernels ] On 14/12/15 16:22, Richard Biener wrote: On Sun, Dec 13, 2015 at 5:58 PM, Tom de Vries <tom_devr...@mentor.com> wrote: On 24/11/15 13:24, Tom de Vries wrote: On 16/11/15 12:59, Tom de Vries wrote: On 09/11/15

[committed] Add pass_parallelize_loops to pass_oacc_kernels

[ was: Re: [committed] Add oacc_kernels_p argument to pass_parallelize_loops ] On 18/01/16 14:07, Tom de Vries wrote: [was: Re: [PIING][PATCH, 9/16] Add pass_parallelize_loops_oacc_kernels ] On 14/12/15 16:22, Richard Biener wrote: On Sun, Dec 13, 2015 at 5:58 PM, Tom de Vries <tom_d

[committed] Add oacc kernels tests in goacc

[ was: Re: [PATCH, 13/16] Add c-c++-common/goacc/kernels-*.c ] On 09/11/15 21:07, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang

[comitted] Add oacc kernels test in libgomp

[ was: Re: [PATCH, 15/16] Add libgomp.oacc-c-c++-common/kernels-*.c ] On 09/11/15 21:10, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang

[PATCH] Add fopt-info-oacc

Hi, This patch introduces an option fopt-info-oacc. When using the option like this with a kernels region in kernels-loop.c that parloops does not manage to parallelize: ... $ gcc kernels-loop.c -S -O2 -fopenacc -fopt-info-oacc-all ... we get a message: ... kernels-loop.c:23:9: note: kernels

[committed] Release_defs in expand_omp_atomic_fetch_op

in expand_omp_atomic_fetch_op 2015-11-05 Tom de Vries <t...@codesourcery.com> * omp-low.c (expand_omp_atomic_fetch_op): Release defs of update stmt. --- gcc/omp-low.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index 6df01a4..b

[Committed] Move pass_expand_omp_ssa out of pass_parallelize_loops

pass_expand_omp_ssa out of pass_parallelize_loops 2016-01-16 Tom de Vries <t...@codesourcery.com> * passes.def: Move pass_expand_omp_ssa out of pass_parallelize_loops. --- gcc/passes.def | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/passes.def b/gcc/passes.def index c

[Committed, testsuite] Move gcc.dg/parloops-exit-first-loop-alt-*.c to gcc.dg/autopar

Hi, I've moved the gcc.dg/parloops-exit-first-loop-alt-*.c tests to gcc.dg/autopar. Committed to trunk. Thanks, - Tom Move gcc.dg/parloops-exit-first-loop-alt-*.c to gcc.dg/autopar 2016-01-16 Tom de Vries <t...@codesourcery.com> * gcc.dg/parloops-exit-first-loop-alt.c

[testsuite, committed] Add goacc/kernels-alias-ipa-pta-4.c

Hi, this is an additional test, similar to goacc/kernels-alias-ipa-pta.c but with scalars instead of arrays. Committed to trunk. Thanks, - Tom Add goacc/kernels-alias-ipa-pta-4.c 2016-01-16 Tom de Vries <t...@codesourcery.com> * c-c++-common/goacc/kernels-alias-ipa-pta-4.c: Ne

[PATCH, PR59627, c++] Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity

n '0'. Bootstrapped and reg-tested on x86_64. OK for trunk, stage1? Thanks, - Tom Handle DECL_OMP_DECLARE_REDUCTION in discriminator_for_local_entity 2016-02-08 Tom de Vries <t...@codesourcery.com> PR c++/59627 * mangle.c (discriminator_for_local_entity): Handle DECL_OMP_DECLARE_R

[PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

dia accelerator and reg-tested libgomp with various lto settings. OK for trunk, stage4? Thanks, - Tom Fix GOMP/GOACC_parallel optimization in ipa-pta 2016-02-08 Tom de Vries <t...@codesourcery.com> PR tree-optimization/69599 * tree-ssa-structalias.c (fndecl_maybe_in_other_partition): New

[PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

trapped and reg-tested on x86_64. OK for stage1 trunk? Thanks, - Tom Don't call call_cgraph_insertion_hooks in simd_clone_create 2016-02-08 Tom de Vries <t...@codesourcery.com> PR lto/67709 * omp-low.c (simd_clone_create): Remove call to symtab->call_cgraph_insertion_hooks. * te

[PATCH, PR69707] Handle -fdiagnostics-color in lto

Handle -fdiagnostics-color in lto 2016-02-08 Tom de Vries <t...@codesourcery.com> PR lto/69707 * common.opt (fdiagnostics-color=): Remove Driver flag. * lto-wrapper.c (merge_and_complain, append_compiler_options): Handle OPT_fdiagnostics_color_. * testsuite/libgomp.oacc-c-c++-common/pa

Re: [PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 10/02/16 17:55, Dominique d'Humières wrote: The patch fixes the PR on x86_64-apple-darwin15. OK for stage1 trunk? What it the reason to delay the fix for a couple of months? We're in stage4 ( https://gcc.gnu.org/ml/gcc/2016-01/msg00168.html ): ... trunk is in regression and

[PATCH, PR69607] Mark offload symbols as global in lto

otstrapped and reg-tested on x86_64. Build for nvidia accelerator and reg-tested libgomp with various lto settings. OK for trunk, stage1? Thanks, - Tom Mark offload symbols as global in lto 2016-02-08 Tom de Vries <t...@codesourcery.com> PR lto/69607 * lto-partition.c (promote_offl

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

On 08/02/16 11:42, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 11:34:39AM +0100, Tom de Vries wrote: Hi, when running libgomp.oacc-c-c++-common/parallel-dims.c with -flto -fno-use-linker-plugin, we run into a failing 'test for excess errors'. The problem is that while -fdiagnostics-color

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

On 26/01/16 14:01, Ilya Verbin wrote: On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: On 25/01/16 14:27, Ilya Verbin wrote: On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c index 62e5454..cdaee41 100644 --- a/gcc/lto

Re: [PATCH, PR69707] Handle -fdiagnostics-color in lto

On 08/02/16 14:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 02:38:17PM +0100, Tom de Vries wrote: hmm, indeed removing the 'Driver' flag from the fdiagnostics-color= entry in common.opt breaks the functioning of fdiagnostics-color= in the gcc driver. This patch leaves the 'Driver' flag

Re: [PATCH, PR69599] Fix GOMP/GOACC_parallel optimization in ipa-pta

On 08/02/16 11:54, Richard Biener wrote: On Mon, 8 Feb 2016, Tom de Vries wrote: Hi, when compiling the fipa-pta tests in the libgomp testsuite (omp-nested-2.c, pr46032.c) with -flto -flto-partition=max, the tests fail in execution (PR69599). The problem is related to the GOMP/GOACC_parallel

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

On 26/01/16 13:49, Jakub Jelinek wrote: On Tue, Jan 26, 2016 at 01:38:39PM +0100, Tom de Vries wrote: Ping^3. ( https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01089.html ) First of all, I wonder if it wouldn't be far easier to handle these during gimplification rather than during omp expansion

Re: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables

On 25/01/16 14:27, Ilya Verbin wrote: Hi! On Tue, Jan 05, 2016 at 15:56:15 +0100, Tom de Vries wrote: diff --git a/gcc/lto-cgraph.c b/gcc/lto-cgraph.c index 62e5454..cdaee41 100644 --- a/gcc/lto-cgraph.c +++ b/gcc/lto-cgraph.c @@ -1911,6 +1911,11 @@ input_offload_tables (void

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

On 24/01/16 09:04, Richard Biener wrote: On January 23, 2016 7:44:23 PM GMT+01:00, Sebastian Pop <seb...@gmail.com> wrote: On Sat, Jan 23, 2016 at 12:28 PM, Tom de Vries <tom_devr...@mentor.com> wrote: That was my original patch, and Richard commented: 'I think avoiding a NULL

Re: [gomp4, PR68977, Committed] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

On 28/01/16 14:32, Richard Biener wrote: On Mon, Jan 25, 2016 at 12:00 PM, Tom de Vries <tom_devr...@mentor.com> wrote: On 14/01/16 10:43, Richard Biener wrote: On Wed, Jan 13, 2016 at 9:04 PM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, At r231739, there was an ICE when c

[PING][PATCH, PR69607] Mark offload symbols as global in lto

On 17/02/16 16:48, Tom de Vries wrote: On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza and Richard here. 2016-02-08 Tom de Vries &l

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

On 12/02/16 12:10, Tom de Vries wrote: On 26/01/16 13:49, Jakub Jelinek wrote: On Tue, Jan 26, 2016 at 01:38:39PM +0100, Tom de Vries wrote: Ping^3. ( https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01089.html ) First of all, I wonder if it wouldn't be far easier to handle these during

Re: [PATCH][RFC][Offloading] Fix PR68463

On 22/02/16 19:07, Ilya Verbin wrote: 2016-02-22 18:13 GMT+03:00 Thomas Schwinge: >On Sat, 20 Feb 2016 13:54:20 +0300, Ilya Verbin wrote: >>On Fri, Feb 19, 2016 at 15:53:08 +0100, Jakub Jelinek wrote: >> >On Wed, Feb 10, 2016 at 08:19:34PM +0300,

Re: [patch, fortran] PR69110 ICE with NEWUNIT

On 25-02-16 01:54, Jerry DeLisle wrote: This patch from Steve on c.l.f Fixes the segfault from attempting a string compare where there is no string yet. Regression tested on x86-64. New test case. OK for trunk. Regards, Jerry 2016-02-24 Jerry DeLisle

Re: [PING^3][PATCH, 12/16] Handle acc loop directive

On 22-02-16 11:57, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 11:54:46AM +0100, Tom de Vries wrote: Following up on your suggestion to implement this during gimplification, I wrote attached patch. I'll put it through some openacc testing and add testcases. Is this approach acceptable

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

On 13/01/16 09:42, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: On 12/01/16 14:04, Richard Biener wrote: On Tue, 12 Jan 2016, Tom de Vries wrote: On 12/01/16 12:22, Richard Biener wrote: Doesnt' the same issue apply to unsigned int *p; static void __attribute__

[PATCH, PR69426] Fix clobber removal in parloops

by the vuse of the clobber. The patch uses replace_uses_by, but unlink_vdef_stmt also works, I'm not sure which one to use. Bootstrapped and reg-tested on x86_64. OK for trunk, gcc-5-branch? Thanks, - Tom Fix clobber removal in parloops 2016-01-23 Tom de Vries <t...@codesourcery.com>

Re: [PATCH] Fix PR64091

{ int index = e->dest->index; bitmap_set_bit (same->succs, index); + e->flags &= ~EDGE_EXECUTABLE; same_succ_edge_flags[index] = e->flags; } EXECUTE_IF_SET_IN_BITMAP (same->succs, 0, j, bj) Backport "Fix PR64091" 2016-01-25 Tom de Vries

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

On 23/01/16 18:39, Sebastian Pop wrote: diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index a40f40d..7ff5db7 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -1023,6 +1023,10 @@ dr_analyze_indices (struct data_reference *dr, loop_p nest, loop_p loop) build_int_cst

Re: [gomp4, PR68977, Committed] Don't gimplify in ssa mode if seen_error in oacc_xform_loop

On 14/01/16 10:43, Richard Biener wrote: On Wed, Jan 13, 2016 at 9:04 PM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, At r231739, there was an ICE when checking code generated by oacc_xform_loop, in case the source contained an error. Due to seen_error (), gimplification

[PING^3][PATCH, 12/16] Handle acc loop directive

On 18/01/16 15:27, Tom de Vries wrote: On 24/11/15 13:26, Tom de Vries wrote: On 09/11/15 21:06, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto

[gomp4, committed] Remove reduction clauses in kernels region earlier

Hi, I've committed this patch to gomp-4_0-branch, moving the removal of the reduction clauses in the kernels region earlier, before localize_reductions. Thanks, - Tom Remove reduction clauses in kernels region earlier 2016-01-20 Tom de Vries <t...@codesourcery.com> * gimp

Re: [committed] Add oacc_kernels_p argument to pass_parallelize_loops

On 20/01/16 09:54, Thomas Schwinge wrote: Hi! On Mon, 18 Jan 2016 14:07:11 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: Add oacc_kernels_p argument to pass_parallelize_loops --- a/gcc/tree-parloops.c +++ b/gcc/tree-parloops.c @@ -2315,6 +2367,9 @@ gen_parallel_loop (struc

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

On 26/01/16 17:59, Sebastian Pop wrote: Tom de Vries wrote: diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c index a40f40d..4c29fc2 100644 --- a/gcc/tree-data-ref.c +++ b/gcc/tree-data-ref.c @@ -1510,8 +1510,9 @@ initialize_data_dependence_relation (struct data_reference

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

t(%{fsome-option-value=*:%*} 1) ... OK for stage4 trunk? Thanks, - Tom Add documentation for spec function gt in invoke.texi 2016-02-16 Tom de Vries <t...@codesourcery.com> * doc/invoke.texi (@node Spec Files): Document spec function gt. --- gcc/doc/invoke.texi | 14 ++ 1

Re: [PATCH, PR69607] Mark offload symbols as global in lto

On 08/02/16 14:00, Tom de Vries wrote: Hi, when running libgomp.c testsuite with "-flto -flto-partition=1to1 -fno-toplevel-reorder" we run into many compilation failures like this: ... /tmp/.ltrans0.ltrans.o:(.gnu.offload_funcs+0x1a0): undefined reference to `MAIN__._o

[PATCH] Add debug_function_to_file

debug_function_to_file (cfun.decl, "foo.1.txt", 0) ... Hmm, now I wonder if the order 'cfun.decl, 0, "foo.1.txt"' would make more sense (first two parameters the same as in debug_function). OK for stage1 trunk if bootstrap and reg-test succeeds? Thanks, - Tom Add debug_function_to_file

[PATCH] Add debug_function_graph_to_file

(gdb) call debug_function_graph_to_file (cfun.decl, "foo.1.dot") ... [ I'll post a follow-up WIP patch that adds the flags parameter. ] OK for stage1 trunk if bootstrap and reg-test succeeds? Thanks, - Tom Add debug_function_graph_to_file 2016-02-17 Tom de Vries <t...@co

Re: [PATCH] Add debug_function_to_file

On 17/02/16 14:42, Richard Biener wrote: On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries<tom_devr...@mentor.com> wrote: >Hi, > >once in a while I'm in a gdb debug session debugging cc1, and want to print >the current function to file. > >There's a debug function de

Re: [PATCH, PR69607] Mark offload symbols as global in lto

On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza and Richard here. 2016-02-08 Tom de Vries <t...@codesourcery.com>

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

On 17/02/16 17:07, Sandra Loosemore wrote: On 02/17/2016 12:14 AM, Tom de Vries wrote: Here's the documentation entry for the gt spec function (I forgot to add it when introducing the function), using the new semantics. Copy-pasting from the resulting .info viewed in emacs for a human

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

On 16/02/16 16:24, Jakub Jelinek wrote: Passing the - and ftree-parallelize-loops= stuff looks weird, and we have %* that substitutes just the variable part of the option, so in addition to fixing the case of multiple options I've also changed %:gt() behaviour, so that it now gets just the

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

On 15/02/16 12:29, Bernd Edlinger wrote: Here is a patch that puts each value on it's own 8-byte aligned memory location. From my experience with tsan tests, sharing shadow memory slots between v and q or o is the most likely explanation for the occasional inability to spot the race condition

Re: [PATCH] Add debug_function_to_file

On 17/02/16 14:42, Richard Biener wrote: On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, once in a while I'm in a gdb debug session debugging cc1, and want to print the current function to file. There's a debug function debug_function that prints a fu

Re: [PATCH] Add debug_function_to_file

On 18/02/16 16:10, Richard Biener wrote: On Thu, Feb 18, 2016 at 3:29 PM, Tom de Vries<tom_devr...@mentor.com> wrote: >On 17/02/16 14:42, Richard Biener wrote: >> >>On Wed, Feb 17, 2016 at 1:41 PM, Tom de Vries<tom_devr...@mentor.com> >>wrote: >>>

Re: [PATCH] Add debug_function_to_file

On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value >>> >history >>> >assignments, but I'm not sure how to do that. >>> > Using gdb.parse_and_eval does the trick. This updated version uses gdb.parse_and_eval, and adds error handling.

Re: [PATCH] Add debug_function_to_file

e for adding the flags argument to dump_bb_for_graph. I ran out of steam at rtl_dump_bb_for_graph, and resorted to the same save-restore dump_flags trick, although it felt a bit hacky to me. Thanks, - Tom Use flags parameter to debug_function_graph_to_file 2016-02-17 Tom de Vries <t...@c

Re: [PATCH] Add debug_function_to_file

On 18/02/16 16:43, Tom de Vries wrote: On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value >>> >history >>> >assignments, but I'm not sure how to do that. >>> > Using gdb.parse_and_eval does the

Re: [PATCH] Add debug_function_to_file

On 18/02/16 16:27, Richard Biener wrote: Attached is what I have for now, it works if you call it like (gdb) dot-fn cfun (gdb) dot-fn cfun, 1<<6 w/o that arg parsing;) I'll play with it some more tomorrow. This version: - uses arg parsing - adds error handling - uses a temp file instead of

Re: [PATCH] Add debug_function_to_file

On 18/02/16 20:41, David Malcolm wrote: On Thu, 2016-02-18 at 18:26 +0100, Tom de Vries wrote: On 18/02/16 16:43, Tom de Vries wrote: On 18/02/16 16:27, Richard Biener wrote: I would be nice if we could avoid the ${1,2,3} printouts and value history assignments, but I'm not sure how to do

Re: [PATCH] Add debug_function_to_file

On 19/02/16 10:44, Richard Biener wrote: On Fri, Feb 19, 2016 at 1:37 AM, Tom de Vries <tom_devr...@mentor.com> wrote: On 18/02/16 16:27, Richard Biener wrote: Attached is what I have for now, it works if you call it like (gdb) dot-fn cfun (gdb) dot-fn cfun, 1<<6 w/o that

[RFC] Add contrib/fix-ChangeLog.sh

Hi, this patch adds a script contrib/fix-ChangeLog.sh. It fixes whitespace issues, and shows ChangeLog lines that look suspicious. Using the script, I was able to find a stray changelog entry (removed in rr233583, https://gcc.gnu.org/viewcvs?rev=233583=gcc=rev ). And I've Any comments?

Re: [RFC] Add contrib/fix-ChangeLog.sh

On 20/02/16 15:04, Tom de Vries wrote: Hi, this patch adds a script contrib/fix-ChangeLog.sh. It fixes whitespace issues, and shows ChangeLog lines that look suspicious. Using the script, I was able to find a stray changelog entry (removed in rr233583, https://gcc.gnu.org/viewcvs?rev=233583

[RFC, PR68580] Handle pthread_create error in tsan testsuite

exit (0); \ } \ } ... If this patch is committed, I should at least be able to find out if indeed the failure I observe is related to resource exhaustion. Good idea? Any other comments? Thanks, - Tom Handle pthread_create error in tsan testsuite 2016-02-

[PING][PATCH] Don't mark offload symbols with force_output in ltrans

[ was: [PING][PATCH] Mark symbols in offload tables with force_output in read_offload_tables ] On 08/02/16 14:20, Tom de Vries wrote: On 26/01/16 14:01, Ilya Verbin wrote: On Tue, Jan 26, 2016 at 13:21:57 +0100, Tom de Vries wrote: On 25/01/16 14:27, Ilya Verbin wrote: On Tue, Jan 05, 2016

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

On 15/02/16 08:24, Dmitry Vyukov wrote: If we are talking about pr 68580, then I would try: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c2 first. As I tried to explain in the follow-up comment ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c3 ), since unfortunately I have no

[PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 08/02/16 13:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote: [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a function create_target_clone, similar to simd_clone_create, with a node.defition and !node.defition part

Re: [RFC, PR68580] Handle pthread_create error in tsan testsuite

On 15/02/16 10:07, Bernd Edlinger wrote: On 15/02/16 09:07, Tom de Vries wrote: >>On 15/02/16 08:24, Dmitry Vyukov wrote: >> >>If we are talking about pr 68580, then I would try: >>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68580#c2 >>first. > >

Re: Use plain -fopenacc to enable OpenACC kernels processing

wrote: On Mon, 9 Nov 2015 18:39:19 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: On 09/11/15 16:35, Tom de Vries wrote: this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. At

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 16/02/16 03:22, Jan Hubicka wrote: On 08/02/16 13:54, Jakub Jelinek wrote: On Mon, Feb 08, 2016 at 01:46:44PM +0100, Tom de Vries wrote: [ The pass before pass_omp_simd_clone is pass_dispatcher_calls. It has a function create_target_clone, similar to simd_clone_create, with a node.defition

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 16/02/16 11:04, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 10:56:58AM +0100, Tom de Vries wrote: >AFAIU, it's not a release regression given that: >- this has failed since 4.9.0, and >- the test-case is not supported in 4.8, >so we're not required to fix it in 4.9 an

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 16/02/16 12:11, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 12:10:29PM +0100, Tom de Vries wrote: >On 16/02/16 11:04, Jakub Jelinek wrote: > >On Tue, Feb 16, 2016 at 10:56:58AM +0100, Tom de Vries wrote: > >>>AFAIU, it's not a release regression given that: > &g

Re: [PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

On 16/02/16 17:54, Jakub Jelinek wrote: On Tue, Feb 16, 2016 at 05:52:55PM +0100, Tom de Vries wrote: Committed both patches to 4.9 and 5 branches. In order to run testsuite/libgomp.fortran/declare-simd-4.f90 with the 4.9 branch build, I needed in addition: - r212268 https://gcc.gnu.org

[PATCH, PR68659] Handle addr_expr and component_ref in graphite-ast-to-ast

failing test-case gcc.dg/graphite/id-pr45230-1.c to pass. Bootstrapped and reg-tested on x86_64. OK for stage4 trunk? Thanks, - Tom Handle addr_expr and component_ref in graphite-ast-to-ast 2016-03-01 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68659 * graphite-i

[committed][testsuite] Xfail pr46032.c scan if alignment requirements not met

Hi, this patch fixes re-opened PR68915 on sparc. It xfails a scan line that's not applicable for sparc. Committed to trunk. Thanks, - Tom Xfail pr46032.c scan if alignment requirements not met 2016-03-10 Tom de Vries <t...@codesourcery.com> PR testsuite/68915 * gcc.dg/vect/pr4

[RFC] dump_varmap in tree-ssa-structalias.c

Hi, I wrote attached patch to print the actual contents of the varmap variable in tree-ssa-structalias.c. Does it make sense to rewrite this into a dump_varmap/debug_varmap patch? Thanks, - Tom diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index de12380..9d02b14 100644

[PATCH, PR70161] Fix fdump-ipa-all-graph

orm. With the patch, it's only called after transform. ] Bootstrapped and reg-tested on x86_64. OK for stage4? Thanks, - Tom Fix fdump-ipa-all-graph 2016-03-14 Tom de Vries <t...@codesourcery.com> PR ipa/70161 * cgraph.c (cgraph_node::get_body): Save, reset and restore dump_file_name. *

Re: [PATCH, PR70185] Only finalize dot files that have been initialized

On 16/03/16 12:34, Richard Biener wrote: On Wed, Mar 16, 2016 at 11:57 AM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, Atm, using fdump-tree-all-graph produces invalid dot files: ... $ rm *.c.* ; gcc test.c -O2 -S -fdump-tree-all-graph $ for f in *.dot; do dot -Tpdf $f -o dot.pdf

[PING^3][PATCH, PR69607] Mark offload symbols as global in lto

On 07/03/16 15:38, Tom de Vries wrote: On 24/02/16 14:37, Tom de Vries wrote: On 17/02/16 16:48, Tom de Vries wrote: On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar

[PING^2][PATCH, 12/16] Handle acc loop directive

On 07/03/16 09:21, Tom de Vries wrote: On 29/02/16 04:26, Tom de Vries wrote: On 22-02-16 11:57, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 11:54:46AM +0100, Tom de Vries wrote: Following up on your suggestion to implement this during gimplification, I wrote attached patch. I'll put

Re: [PATCH, 4/16] Implement -foffload-alias

On 02/12/15 10:58, Jakub Jelinek wrote: On Fri, Nov 27, 2015 at 01:03:52PM +0100, Tom de Vries wrote: Handle non-declared variables in kernels alias analysis 2015-11-27 Tom de Vries <t...@codesourcery.com> * gimplify.c (gimplify_scan_omp_clauses): Init

[oacc,testsuite] Add goacc/kernels-alias{,-2}.f95

Hi, I've translated the goacc/kernels-alias{,-2}.c testcases to fortran. Committed to trunk. Thanks, - Tom Add goacc/kernels-alias{,-2}.f95 2016-03-15 Tom de Vries <t...@codesourcery.com> * gfortran.dg/goacc/kernels-alias-2.f95: New test. * gfortran.dg/goacc/kernels-alias.f95: Ne

Re: [PATCH, 4/16] Implement -foffload-alias

On 14/03/16 14:16, Tom de Vries wrote: On 02/12/15 10:58, Jakub Jelinek wrote: On Fri, Nov 27, 2015 at 01:03:52PM +0100, Tom de Vries wrote: Handle non-declared variables in kernels alias analysis 2015-11-27 Tom de Vries <t...@codesourcery.com> * gimplify.c (gimplify_scan_omp_c

[PATCH, PR70045] Unshare create_empty_if_region_on_edge argument

create_empty_if_region_on_edge argument 2016-03-11 Tom de Vries <t...@codesourcery.com> PR tree-optimization/70045 * graphite-isl-ast-to-gimple.c (graphite_create_new_loop_guard): Unshare create_empty_if_region_on_edge argument. * gcc.dg/graphite/pr70045.c: New test. --- gcc/graphite-isl-ast-to-gi

[oacc, testsuite, comitted] Add goacc/kernels-alias-{3,4}.f95

Hi, I've translated the goacc/kernels-alias-{3,4}.c testcases to fortran. Committed to trunk. Thanks, - Tom Add goacc/kernels-alias-{3,4}.f95 2016-03-17 Tom de Vries <t...@codesourcery.com> * gfortran.dg/goacc/kernels-alias-3.f95: New test. * gfortran.dg/goacc/kernels-alias-4.f9

[PATCH] Add debug_varinfo and debug_varmap

[ was: Re: [RFC] dump_varmap in tree-ssa-structalias.c ] On 10/03/16 10:07, Richard Biener wrote: On Thu, 10 Mar 2016, Tom de Vries wrote: Hi, I wrote attached patch to print the actual contents of the varmap variable in tree-ssa-structalias.c. Does it make sense to rewrite

[PATCH, PR68809] Fix same_close_phi_node

Bootstrapped and reg-tested on x86_64. OK for stage4 trunk? Thanks, - Tom Fix same_close_phi_node 2016-03-15 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68809 * graphite-scop-detection.c (same_close_phi_node): Test if result types are the same. * gcc.dg/graphite/pr6

Re: [PATCH, PR68715] Add missing single_pred_p test in scop_detection::merge_sese

On 16/03/16 09:53, Richard Biener wrote: Hmm, it looks like for all what this function does this effectively pessimizes scop merging and it would be easier to split 'exit' in case its destination is unsuitable (not trivially empty). Agreed. The /* For now we just want to bail out when

[PATCH, PR70185] Only finalize dot files that have been initialized

ue is uninitialized. The patch also fixes this. ] Bootstrapped and reg-tested on x86_64. OK for stage1? Thanks, - Tom Only finalize dot files that have been initialized 2016-03-16 Tom de Vries <t...@codesourcery.com> PR other/70185 * passes.c (opt_pass::opt_pass): Add m

[PATCH, PR68715] Add missing single_pred_p test in scop_detection::merge_sese

x86_64. OK for stage4 trunk? Thanks, - Tom Add missing single_pred_p test in scop_detection::merge_sese 2016-03-15 Tom de Vries <t...@codesourcery.com> PR tree-optimization/68715 * graphite-scop-detection.c (scop_detection::merge_sese): Add missing single_pred_p test. * gcc.dg/graphite

[PATCH, PR70187] Safely use nodes[0] in possible_polymorphic_call_targets

by moving the 'nodes.length () == 1' test to before the use of nodes[0]. Bootstrapped and reg-tested on x86_64. OK for stage4 trunk? Thanks, - Tom Safely use nodes[0] in possible_polymorphic_call_targets 2016-03-16 Tom de Vries <t...@codesourcery.com> PR lto/70187 * ipa-devirt.c (poss

Re: Do not give realistic estimates for loop with array accesses

On 30/03/16 14:36, Richard Biener wrote: On Wed, 30 Mar 2016, Jan Hubicka wrote: > > > >You are only changing one place in this file. > >You are right. I am attaching the updated patch which I am re-testing now. > > > >The vectorizer already checks this (albeit indirectly): > > > >

Re: [patch] libstdc++/70503 Ensure std::thread helpers have internal linkage

Hi, FYI, this testcase fails for me as follows: ... /usr/bin/ld: Dwarf Error: found dwarf version '4', this reader only handles version 2 and 3 information.^M /tmp/ccMBMHB5.o: In function `main':^M 70503.cc:(.text.startup.main+0x5): undefined reference to `execute_native_thread_routine'^M

Re: [PING][PATCH] Remove incorrect warning for kernels copy clause

On 05/04/16 12:16, Tom de Vries wrote: On 24/03/16 17:59, Tom de Vries wrote: Hi, This patch fixes an incorrect warning for the oacc copy clause. Consider this test-case: ... void foo (void) { int i; #pragma acc kernels { i = 1; } } ... When compiling with -fopenacc

Re: [patch, driver] Ignore -ftree-parallelize-loops={0,1}

On 08/04/16 12:35, Thomas Schwinge wrote: Hi! Ping. On Thu, 17 Mar 2016 17:24:48 +0100, I wrote: On Tue, 14 Jul 2015 10:36:25 +0200, Tom de Vries <tom_devr...@mentor.com> wrote: On 14/07/15 06:54, Jeff Law wrote: On 07/13/2015 04:58 AM, Tom de Vries wrote: On 07/07/15 09:53, Tom de

Re: [PING][PATCH] Remove incorrect warning for parallel firstprivate clause

On 05/04/16 17:44, Jakub Jelinek wrote: On Tue, Apr 05, 2016 at 12:17:16PM +0200, Tom de Vries wrote: On 24/03/16 18:02, Tom de Vries wrote: Remove incorrect warning for parallel firstprivate clause 2016-03-24 Tom de Vries <t...@codesourcery.com> * omp-low.c (lower_omp_target

<    7   8   9   10   11   12   13   14   15   16   >