Re: [PATCH 2/3] [graphite] add array access function in the right order

2016-04-09 Thread Tom de Vries
On 09/12/15 19:26, Sebastian Pop wrote: we used to add the access functions in the wrong order, Fortran style, leading to unprofitable interchanges. --- gcc/graphite-sese-to-poly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/graphite-sese-to-poly.c

Re: [PATCH, PR68756] Fix typo in copy_cond_phi_args

2016-04-12 Thread Tom de Vries
[adding cc gcc-patches ] On 12/04/16 09:25, Tom de Vries wrote: Hi, when compiling the test-case in the patch, we run into an ICE in sese_build_liveouts_use when evaluating 'TREE_CODE (use)' because use is NULL_TREE: ... static void sese_build_liveouts_use (sese_info_p region, bitmap liveouts

[PATCH, PR68953] Fix pdr accesses order

2016-04-08 Thread Tom de Vries
irectly but do an order inversion before. I've picked 1, since that was the easiest for me to implement (but I'm not sure if by doing so, I've broken any hardcoded graphite assumptions). Bootstrapped and regtested on x86_64. OK for stage4? Thanks, - Tom Fix pdr accesses order 2016-04-07

[gomp4] Remove superfluous passes in kernels pass list

2016-04-11 Thread Tom de Vries
Hi, this patch removes passes from the kernels pass list on gomp-4_0-branch, that are not present in the kernels pass list on trunk. Bootstrapped and reg-tested on x86-64. Committed to trunk. Thanks, - Tom Remove superfluous passes in kernels pass list 2016-04-11 Tom de Vries &l

Re: [PATCH, PR70161] Fix fdump-ipa-all-graph

2016-03-19 Thread Tom de Vries
On 18/03/16 10:23, Tom de Vries wrote: On 15/03/16 12:37, Richard Biener wrote: On Mon, 14 Mar 2016, Tom de Vries wrote: Hi, this patch fixes PR70161, a 4.9/5/6 regression. Currently when using -fdump-ipa-all-graph, the compiler ICEs in execute_function_dump when testing for pass

Re: [PATCH, PR70161] Fix fdump-ipa-all-graph

2016-03-19 Thread Tom de Vries
On 15/03/16 12:37, Richard Biener wrote: On Mon, 14 Mar 2016, Tom de Vries wrote: Hi, this patch fixes PR70161, a 4.9/5/6 regression. Currently when using -fdump-ipa-all-graph, the compiler ICEs in execute_function_dump when testing for pass->graph_dump_initialized, because pass == N

[PATCH, PR70183] Propagate dump flags in pass_manager::register_pass

2016-03-19 Thread Tom de Vries
de Vries <t...@codesourcery.com> PR other/70183 * passes.c (pass_manager::register_pass): Propagate pflags. * gcc.target/i386/vzeroupper-dump-flags.c: New test. --- gcc/passes.c | 6 +- gcc/testsuite/gcc.target/i386/vzeroupper-dump-flags.

[PATCH, PR70269] Set dump_file to NULL in cgraph_node::get_body

2016-03-19 Thread Tom de Vries
it's the dump file for ipa-pta, the pass that calls cgraph_node:get_body which triggers the ipa transform of ipa-cp. The patch fixes this by resetting dump_file to NULL in cgraph_node::get_body. OK for stage 4 trunk/5 branch if bootstrap and reg-test succeeds? Thanks, - Tom Set dump_file to NULL i

Re: [PATCH] Fix PR64764

2016-03-19 Thread Tom de Vries
On 16/03/16 17:15, H.J. Lu wrote: On Wed, Mar 16, 2016 at 9:12 AM, H.J. Lu wrote: Any particular reason why this test was changed to DOS format? FWIW, the test was in DOS format from the start. Thanks - Tom

Re: [PATCH, PR70161] Fix fdump-ipa-all-graph

2016-03-20 Thread Tom de Vries
On 15/03/16 12:37, Richard Biener wrote: On Mon, 14 Mar 2016, Tom de Vries wrote: Hi, this patch fixes PR70161, a 4.9/5/6 regression. Currently when using -fdump-ipa-all-graph, the compiler ICEs in execute_function_dump when testing for pass->graph_dump_initialized, because pass == N

[committed, testsuite] Add missing initializations in oacc testcases

2016-03-23 Thread Tom de Vries
Hi, I've run: - the goacc.exp testcases, and - the target-libgomp oacc testcases with -Wuninitialized, and found a few missing initalizations. Fixed and committed as attached. Thanks, - Tom Add missing initializations in oacc testcases 2016-03-23 Tom de Vries <t...@codesourcery.com>

[testsuite, committed] Add goacc/uninit-if-clause.{c,f95}

2016-03-24 Thread Tom de Vries
warnings for if clause'. Some of the warning scans are xfailed in C++ due to that PR. Thanks, - Tom Add goacc/uninit-if-clause.{c,f95} 2016-03-24 Tom de Vries <t...@codesourcery.com> * c-c++-common/goacc/uninit-if-clause.c: New test. * gfortran.dg/goacc/uninit-if-clause.f95: New test. ---

[testsuite, committed] Add missing initializations in oacc testcases

2016-03-24 Thread Tom de Vries
Hi, I've run the goacc.exp testcases with -Wuninitialized and found a few more missing initializations. Fixed and committed as attached. Thanks, - Tom Add missing initializations in oacc testcases 2016-03-24 Tom de Vries <t...@codesourcery.com> * gfortran.dg/goacc/data-tree.f9

[testsuite, committed] Add missing initialization in goacc/host_data-tree.f95

2016-03-24 Thread Tom de Vries
Hi, I've run the goacc.exp testcases with -Wuninitialized and found one more missing initialization. Fixed and committed as attached. Thanks, - Tom Add missing initialization in goacc/host_data-tree.f95 2016-03-24 Tom de Vries <t...@codesourcery.com> * gfortran.dg/goacc/hos

[testsuite, committed] Add goacc/uninit-dim-clause.{c,f95}

2016-03-24 Thread Tom de Vries
Hi, I've committed attached patch, which adds testcases that test the -Wuninitialized warning for the num_gangs, num_workers, vector_length clauses on the openacc directive parallel. Thanks, - Tom Add goacc/uninit-dim-clause.{c,f95} 2016-03-24 Tom de Vries <t...@codesourcery.com>

[testsuite, committed] Add goacc/uninit-use-device-clause.{c,f95}

2016-03-24 Thread Tom de Vries
triggers error mentioning use_device_ptr'. I've added xfails related to that PR. Thanks, - Tom Add goacc/uninit-use-device-clause.{c,f95} 2016-03-24 Tom de Vries <t...@codesourcery.com> * c-c++-common/goacc/uninit-use-device-clause.c: New test. * gfortran.dg/goacc/uninit-use-

[PATCH] Remove incorrect warning for kernels copy clause

2016-03-24 Thread Tom de Vries
in the copy clause with TREE_NO_WARNING. Build and reg-tested with goacc.exp, gomp.exp and target-libgomp. OK for trunk if bootstrap and reg-test succeeds? Thanks, - Tom Remove incorrect warning for kernels copy clause 2016-03-24 Tom de Vries <t...@codesourcery.com> * omp

[PATCH] Remove incorrect warning for parallel firstprivate clause

2016-03-24 Thread Tom de Vries
the warning by marking the variable in the firstprivate clause with TREE_NO_WARNING. Build and reg-tested with goacc.exp, gomp.exp and target-libgomp. OK for trunk if bootstrap and reg-test succeeds? Thanks, - Tom Remove incorrect warning for parallel firstprivate clause 2016-03-24 Tom de

Re: [PATCH] Skip ubsan internal fns in tail-merge

2016-03-07 Thread Tom de Vries
On 07/03/16 12:32, Jakub Jelinek wrote: On Mon, Mar 07, 2016 at 12:26:10PM +0100, Tom de Vries wrote: OK for stage4 trunk if bootstrap and reg-test succeeds? Ok, with a minor nits. 2016-03-07 Tom de Vries <t...@codesourcery.com> PR tree-optimization/70116 * tree-ss

[PATCH] Skip ubsan internal fns in tail-merge

2016-03-07 Thread Tom de Vries
function (ASAN_CHECK) be handled in the same way, as suggested here ( https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00776.html )? OK for stage4 trunk if bootstrap and reg-test succeeds? Thanks, - Tom Skip ubsan internal fns in tail-merge 2016-03-07 Tom de Vries <t...@codesourcery.com>

Re: [PATCH] Skip ubsan internal fns in tail-merge

2016-03-07 Thread Tom de Vries
On 07/03/16 11:01, Jakub Jelinek wrote: On Mon, Mar 07, 2016 at 10:49:14AM +0100, Tom de Vries wrote: This patch implements that. Should the asan internal function (ASAN_CHECK) be handled in the same way, as suggested here ( https://gcc.gnu.org/ml/gcc-patches/2015-07/msg00776.html )? OK

[PING][PATCH, 12/16] Handle acc loop directive

2016-03-07 Thread Tom de Vries
On 29/02/16 04:26, Tom de Vries wrote: On 22-02-16 11:57, Jakub Jelinek wrote: On Mon, Feb 22, 2016 at 11:54:46AM +0100, Tom de Vries wrote: Following up on your suggestion to implement this during gimplification, I wrote attached patch. I'll put it through some openacc testing and add

Re: [PATCH] Handle oacc region in oacc routine

2016-03-02 Thread Tom de Vries
On 01-03-16 12:37, Jakub Jelinek wrote: On Tue, Mar 01, 2016 at 06:24:58PM +0100, Tom de Vries wrote: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -3715,6 +3715,14 @@ check_omp_nesting_restrictions (gimple *stmt, omp_context *ctx) kind == OMP_CLAUSE_DEPEND_SOURCE ? "s

[PING^2][PATCH, PR69607] Mark offload symbols as global in lto

2016-03-07 Thread Tom de Vries
On 24/02/16 14:37, Tom de Vries wrote: On 17/02/16 16:48, Tom de Vries wrote: On 17/02/16 13:30, Jakub Jelinek wrote: On Wed, Feb 17, 2016 at 01:02:17PM +0100, Tom de Vries wrote: Mark offload symbols as global in lto I'm really not familiar with that part of LTO, so I'm CCing Honza

Re: [Ada] Fix unexpectedly large frame with calls manipulating strings

2016-03-01 Thread Tom de Vries
On 29-02-16 10:17, Eric Botcazou wrote: Another long-standing regression present in the compiler (dating back to the Tree-SSA merge): the compiler generates code that has an unexpectedly large stack usage for nested calls on strings, because the gimplifier creates temporaries in the outermost

[PATCH] Handle oacc region in oacc routine

2016-03-01 Thread Tom de Vries
regression test. OK for stage4 trunk, if complete bootstrap/reg-test succeeds? Thanks, - Tom Handle oacc region in oacc routine 2015-10-16 Tom de Vries <t...@codesourcery.com> * omp-low.c (check_omp_nesting_restrictions): Check for oacc region in oacc routine. * c-c++-common/goacc/nesting-

Re: [PATCH, PR68659] Handle addr_expr and component_ref in graphite-ast-to-ast

2016-03-02 Thread Tom de Vries
On 01-03-16 10:45, Richard Biener wrote: On Tue, 1 Mar 2016, Tom de Vries wrote: Hi, this patch fixes graphite PR68659, which is a 6 regression. The patch fixes two things: - by handling new_expr == NULL_TREE in collect_all_ssa_names, it handles a COMPONENT_REF where operand 2

Re: [PATCH, 16/16] Add libgomp.oacc-fortran/kernels-*.f95

2016-03-09 Thread Tom de Vries
On 09/11/15 21:12, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1

Re: [PATCH, 15/16] Add libgomp.oacc-c-c++-common/kernels-*.c

2016-03-09 Thread Tom de Vries
On 09/11/15 21:10, Tom de Vries wrote: On 09/11/15 16:35, Tom de Vries wrote: Hi, this patch series for stage1 trunk adds support to: - parallelize oacc kernels regions using parloops, and - map the loops onto the oacc gang dimension. The patch series contains these patches: 1

[PATCH, trivial, 1/3] Simplify loop in pp_write_text_as_dot_label_to_stream

2016-04-04 Thread Tom de Vries
, - Tom Simplify loop in pp_write_text_as_dot_label_to_stream 2016-04-04 Tom de Vries <t...@codesourcery.com> * pretty-print.c (pp_write_text_as_dot_label_to_stream): Simplify loop structure. --- gcc/pretty-print.c | 23 ++- 1 file changed, 14 insertions(+), 9 del

[PATCH, trivial, 3/3, PR70433] Handle backslash in pp_write_text_as_dot_label_to_stream

2016-04-04 Thread Tom de Vries
x bit of https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01077.html which is awaiting review. ] Thanks, - Tom Handle backslash in pp_write_text_as_dot_label_to_stream 2016-04-04 Tom de Vries <t...@codesourcery.com> PR other/70433 * pretty-print.c (pp_write_text_as_dot_label_to_stream): Esca

[PATCH, trivial, 2/3] Fix record-shape escapes in pp_write_text_as_dot_label_to_stream

2016-04-04 Thread Tom de Vries
rivial. Thanks, - Tom Fix record-shape escapes in pp_write_text_as_dot_label_to_stream 2016-04-04 Tom de Vries <t...@codesourcery.com> * pretty-print.c (pp_write_text_as_dot_label_to_stream): Classify chars '{}<> ' as escape-for-record. --- gcc/pretty-print.c | 12 ++--

[PING][PATCH] Remove incorrect warning for parallel firstprivate clause

2016-04-05 Thread Tom de Vries
On 24/03/16 18:02, Tom de Vries wrote: Hi, This patch fixes an incorrect warning for the oacc firstprivate clause. Consider this test-case: ... void foo (void) { int i; #pragma acc parallel { i = 1; } } ... When compiling with -fopenacc -Wuninitialized, we get an 'is used

Re: Scan for parallelization of the oacc kernels test-cases in gfortran.dg/goacc

2016-04-05 Thread Tom de Vries
On 18/03/16 13:37, Thomas Schwinge wrote: Hi! On Wed, 9 Mar 2016 10:17:28 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: [Should have cited <http://news.gmane.org/find-root.php?message_id=%3C5640FD6A.3080807%40mentor.com%3E> instead of the C/C++ tests] Retested on c

[PATCH, PR70700] Fix ICE in dump_pred_graph

2016-05-02 Thread Tom de Vries
graphs from ealias dump and verified that valid pdfs were produced. OK for trunk? Thanks, - Tom Fix ICE in dump_pred_graph 2016-05-02 Marek Polacek <pola...@redhat.com> Tom de Vries <t...@codesourcery.com> PR tree-optimization/70700 * tree-ssa-structalias.c (dump_pred_g

[PING, testsuite] Add dot-file scan to test-case

2016-04-17 Thread Tom de Vries
[ was: PATCH, PR70161] Fix fdump-ipa-all-graph ] On 18/03/16 10:35, Tom de Vries wrote: On 18/03/16 10:23, Tom de Vries wrote: On 15/03/16 12:37, Richard Biener wrote: On Mon, 14 Mar 2016, Tom de Vries wrote: Hi, this patch fixes PR70161, a 4.9/5/6 regression. Currently when using -fdump

Re: [PING, testsuite] Add dot-file scan to test-case

2016-04-18 Thread Tom de Vries
On 18-04-16 09:30, Richard Biener wrote: diff --git a/gcc/testsuite/lib/scandump.exp b/gcc/testsuite/lib/scandump.exp > >index 74d27cc..89b3944 100644 > >--- a/gcc/testsuite/lib/scandump.exp > >+++ b/gcc/testsuite/lib/scandump.exp > >@@ -22,7 +22,7 @@ > > # Extract the constant part of the

[Committed, trunk/6] Handle NULL def in build_cross_bb_scalars_def

2016-05-07 Thread Tom de Vries
gzilla/show_bug.cgi?id=70956#c2 . Committed to trunk, backported to 6 branch. Thanks, - Tom Handle NULL def in build_cross_bb_scalars_def 2016-05-07 Tom de Vries <t...@codesourcery.com> PR tree-optimization/70956 * graphite-scop-detection.c (build_cross_bb_scalars_def): Handle NULL def

[gomp4] DEV-PHASE change

2017-02-23 Thread Tom de Vries
[ was: r241221 [1/2] - in /branches/gomp-4_0-branch: ] On 16/10/16 22:13, tschwi...@gcc.gnu.org wrote: Author: tschwinge Date: Sun Oct 16 20:13:18 2016 New Revision: 241221 URL: https://gcc.gnu.org/viewcvs?rev=241221=gcc=rev Log: svn merge -r 235033:240831

Re: [gomp4] enable GOMP_MAP_FIRSTPRIVATE_INT in OpenACC

2017-02-10 Thread Tom de Vries
in convert_from_firstprivate_int 2017-02-10 Tom de Vries <t...@codesourcery.com> * omp-low.c (convert_from_firstprivate_int): Remove unused variable. --- gcc/omp-low.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index bb2d1fa..0f79533 100644 --- a/gcc/omp-low.c +++ b/g

Re: [PATCH] Some more translation related tweaks

2017-03-01 Thread Tom de Vries
On 27/02/17 18:33, Jakub Jelinek wrote: On Mon, Feb 27, 2017 at 12:47:09PM +, Joseph Myers wrote: On Mon, 27 Feb 2017, Jakub Jelinek wrote: On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote: This is not -Wformat-security friendly, perhaps better pedwarn

Re: [gomp4] DEV-PHASE change

2017-02-27 Thread Tom de Vries
On 27/02/17 10:09, Thomas Schwinge wrote: Hi Tom! On Thu, 23 Feb 2017 17:19:37 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: [ was: r241221 [1/2] - in /branches/gomp-4_0-branch: ] On 16/10/16 22:13, tschwi...@gcc.gnu.org wrote: Author: tschwinge Date: Sun Oct 16 20:13:18 20

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-25 Thread Tom de Vries
On 25/08/16 13:48, Richard Biener wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: Hi, in PR70955, ix86_canonical_va_list_type fails to recognize a __builtin_ms_va_list that was declared in a TU, because its type doesn't have the same main variant as the ms_va_list_type_node initialized

[PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-03 Thread Tom de Vries
g by considering the attribute on the va_list struct type as engrained in apply_identity_attributes. Bootstrapped and reg-tested on x86_64. OK for trunk, 6 branch? Thanks, - Tom Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list 2016-09-03 Tom de Vries <t...@codes

Re: [PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-09-03 Thread Tom de Vries
On 03/09/16 17:37, Andreas Schwab wrote: On Aug 24 2016, Tom de Vries <tom_devr...@mentor.com> wrote: > Replace error_at with assert in build_va_arg > > 2016-08-22 Tom de Vries <t...@codesourcery.com> > >* c-common.c (build_va_arg): Replace first argument

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-05 Thread Tom de Vries
On 05/09/16 09:49, Richard Biener wrote: On Sun, Sep 4, 2016 at 11:30 PM, Tom de Vries <tom_devr...@mentor.com> wrote: > On 04/09/16 16:08, Richard Biener wrote: >> >> On September 4, 2016 12:33:02 PM GMT+02:00, Tom de Vries >> <tom_devr...@mentor.com>

Re: [PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-09-04 Thread Tom de Vries
On 03/09/16 17:37, Andreas Schwab wrote: On Aug 24 2016, Tom de Vries <tom_devr...@mentor.com> wrote: > Replace error_at with assert in build_va_arg > > 2016-08-22 Tom de Vries <t...@codesourcery.com> > >* c-common.c (build_va_arg): Replace first argument

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-04 Thread Tom de Vries
On 04/09/16 08:12, Richard Biener wrote: On September 3, 2016 5:23:35 PM GMT+02:00, Tom de Vries <tom_devr...@mentor.com> wrote: >Hi, > >this patch fixes a c++ ICE, a p1 6/7 regression. > > >Consider test.C: >... >void bar (__builtin_va_list &);

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-04 Thread Tom de Vries
On 04/09/16 16:08, Richard Biener wrote: On September 4, 2016 12:33:02 PM GMT+02:00, Tom de Vries <tom_devr...@mentor.com> wrote: On 04/09/16 08:12, Richard Biener wrote: On September 3, 2016 5:23:35 PM GMT+02:00, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, this patch fix

Re: PR35503 - warn for restrict pointer

2016-08-30 Thread Tom de Vries
On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified parameter and it aliases with another argument. eg: int foo (const char *__restrict buf, const char *__restrict fmt, ...); void f(void) {

Re: PR35503 - warn for restrict pointer

2016-08-30 Thread Tom de Vries
On 30/08/16 17:34, Prathamesh Kulkarni wrote: On 30 August 2016 at 20:24, Tom de Vries <tom_devr...@mentor.com> wrote: On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified par

Re: PR35503 - warn for restrict pointer

2016-08-31 Thread Tom de Vries
On 30/08/16 16:54, Tom de Vries wrote: On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified parameter and it aliases with another argument. eg: int foo (const char *__restrict buf, const char

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'"

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-size-9.c -O2 -flto -fno-use-linker-plugin -flto-partition=none

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL:

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-13 Thread Tom de Vries
On 13/09/16 03:36, Jason Merrill wrote: On Wed, Sep 7, 2016 at 5:22 AM, Richard Biener <richard.guent...@gmail.com> wrote: On Mon, Sep 5, 2016 at 6:11 PM, Tom de Vries <tom_devr...@mentor.com> wrote: On 05/09/16 09:49, Richard Biener wrote: On Sun, Sep 4, 2016 at 11:30 PM,

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-10 Thread Tom de Vries
On 07-09-16 11:22, Richard Biener wrote: On Mon, Sep 5, 2016 at 6:11 PM, Tom de Vries <tom_devr...@mentor.com> wrote: On 05/09/16 09:49, Richard Biener wrote: On Sun, Sep 4, 2016 at 11:30 PM, Tom de Vries <tom_devr...@mentor.com> wrote: On 04/09/16 16:08, Richard

Re: [PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-09-19 Thread Tom de Vries
On 19/09/16 13:02, Szabolcs Nagy wrote: On 29/08/16 17:12, Tom de Vries wrote: > On 29/08/16 17:51, Joseph Myers wrote: >> On Wed, 24 Aug 2016, Tom de Vries wrote: >> >>> This patch fixes PR71602 by making canonical_va_list_type more strict. > 2016-08-22 Tom de Vr

Re: [PATCH] Fix PR64078

2016-09-15 Thread Tom de Vries
On 31/08/16 07:42, Tom de Vries wrote: On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-siz

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-26 Thread Tom de Vries
otstrapped and reg-tested on x86_64 -m64/-m32. OK for trunk, 6 branch? Thanks, - Tom Tag {ms,sysv}_va_list_type_node with '{ms,sysv}_abi va_list' attribute 2016-08-24 Tom de Vries <t...@codesourcery.com> PR lto/70955 * config/i386/i386.c (ix86_build_builtin_va_list_64): Tag type with '

[PATCH, 1/4] Handle errors in both args of va_arg

2016-08-23 Thread Tom de Vries
gimplify_va_arg_expr to build_va_arg. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle errors in both args of va_arg 2016-08-22 Tom de Vries <t...@codesourcery.com> * c-common.c (build_va_arg): Add first argument error. Build va_arg with error_mark_node as va_list i

[PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-08-24 Thread Tom de Vries
? Thanks, - Tom Replace error_at with assert in build_va_arg 2016-08-22 Tom de Vries <t...@codesourcery.com> * c-common.c (build_va_arg): Replace first argument type error with assert. --- gcc/c-family/c-common.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff

[PATCH, 3/4] Fix assert in build_va_arg, case 2b

2016-08-24 Thread Tom de Vries
Hi, this patch fixes an assert in build_va_arg. Instead of testing for pointer equality, we use the same test as is used in std_canonical_va_list_type. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Fix assert in build_va_arg, case 2b 2016-08-22 Tom de Vries &l

[PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-24 Thread Tom de Vries
[ was: Re: [PATCH, PR71602] Give error for invalid va_list argument to va_arg ] On 23/06/16 23:21, Jason Merrill wrote: On Thu, Jun 23, 2016 at 1:27 PM, Tom de Vries <tom_devr...@mentor.com> wrote: Hi, this patch fixes PR71602, a 6/7 regression. Consider this test-case:>> The

backport PR61929 fix to 5 branch

2016-08-28 Thread Tom de Vries
[was: Re: [PATCH] [graphite] fix pr61929] On 17/07/15 06:31, Tobias Grosser wrote: On 07/17/2015 12:23 AM, Sebastian Pop wrote: This fixes bootstrap of GCC with BOOT_CFLAGS="-g -O2 -fgraphite-identity -floop-nest-optimize -floop-block -floop-interchange -floop-strip-mine". It passes regstrap

Re: [committed] Backport r238728 testsuite g++.dg/init/elide5.C fix (PR testsuite/77034)

2016-08-28 Thread Tom de Vries
On 16/08/16 09:18, Jakub Jelinek wrote: Hi! I've backported following fix to 6 branch: 2016-08-16 Jakub Jelinek PR testsuite/77034 Backported from mainline 2016-07-25 Jason Merrill * g++.dg/init/elide5.C (operator

Re: [PATCH] Fix PR64078

2016-08-29 Thread Tom de Vries
On 17/09/15 20:08, Marek Polacek wrote: On Thu, Sep 17, 2015 at 08:06:48PM +0200, Bernd Edlinger wrote: Hi, On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: On 09/17/2015 09:00 AM, Marek Polacek wrote: On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: Hi, On Wed, 9 Sep 2015

Re: [PATCH, testsuite]: Use -gdwarf-2 for g++.dg/other/anon5.C

2016-08-29 Thread Tom de Vries
On 01/02/16 23:10, Jeff Law wrote: On 02/01/2016 03:05 PM, Uros Bizjak wrote: Hello! This test case fails for targets, where dwarf-4 is unsupported (e.g. CentOS 5.11) with /usr/bin/ld: Dwarf Error: found dwarf version '4', this reader only handles version 2 information. We can use -gdwarf-2

Re: [PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-29 Thread Tom de Vries
On 29/08/16 17:51, Joseph Myers wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: This patch fixes PR71602 by making canonical_va_list_type more strict. Bootstrapped and reg-tested on x86_64. OK for trunk, 6-branch? ENOPATCH Patch attached this time. Thanks, - Tom Make

[PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-24 Thread Tom de Vries
on x86_64. OK for trunk, 6 branch? Thanks, - Tom Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute 2016-08-24 Tom de Vries <t...@codesourcery.com> PR lto/70955 * config/i386/i386.c (ix86_build_builtin_va_list_64): Tag type with sysv_abi attribute. (ix86_build_builtin_va_list): Ta

[PATCH, PR77558] Remove RECORD_TYPE special-casing in std_canonical_va_list_type

2016-09-25 Thread Tom de Vries
implement this for structure va_list types, such as we have for arm, aarch64 and alpha. This patch adds the missing part, and fixes the ICE. OK for trunk, 6-branch? Thanks, - Tom Remove RECORD_TYPE special-casing in std_canonical_va_list_type 2016-09-25 Tom de Vries <t...@codesourcery.com> PR

Re: Fix ICE with __builtin_va_list on i?86 (PR middle-end/78716)

2016-12-12 Thread Tom de Vries
On 08/12/16 22:07, Marek Polacek wrote: This test ICEs since r240072 where Tom disallowed using va_list * as a first argument to va_arg. I think the problem is in the ADDR_EXPR check in gimplify_va_arg_expr. It's meant to handle Case 1, but the valist doesn't always have to be ADDR_EXPR. E.g.

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-24 Thread Tom de Vries
On 23/03/17 18:25, Mike Stump wrote: On Mar 23, 2017, at 8:46 AM, Tom de Vries <tom_devr...@mentor.com> wrote: I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: ... sorry, unimplemented: target cannot support alloca. We'd

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-28 Thread Tom de Vries
On 28/03/17 10:23, Thomas Schwinge wrote: Hi! On Thu, 23 Mar 2017 16:46:19 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: ... sorry, unimplemented: target canno

[PATCH, testsuite] Allow braces around relative line numbers

2017-03-28 Thread Tom de Vries
ve line number handling in process-message doesn't handle that whitespace well. This patch fixes that. Bootstrapped and reg-tested on x86_64. OK for stage4 or stage1 trunk? Thanks, - Tom Allow braces around relative line numbers 2017-03-27 Tom de Vries <t...@codesourcery.com> PR test

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-23 Thread Tom de Vries
On 23/03/17 17:24, Thomas Schwinge wrote: Hi Tom! On Thu, 23 Mar 2017 16:46:19 +0100, Tom de Vries <tom_devr...@mentor.com> wrote: I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: ... sorry, unimplemented: target canno

[testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-23 Thread Tom de Vries
Hi, I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: ... sorry, unimplemented: target cannot support alloca. ... This patch marks those testcases as requiring alloca. OK for trunk for stage1? Thanks, - Tom 2017-03-23 Tom de

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-27 Thread Tom de Vries
On 24/03/17 13:38, Rainer Orth wrote: Hi Tom, On 23/03/17 18:25, Mike Stump wrote: On Mar 23, 2017, at 8:46 AM, Tom de Vries <tom_devr...@mentor.com> wrote: I've run the gcc testsuite for target nvptx-none and ran into "test for excess errors" FAILs due to: ... sorry, unimp

Re: [testsuite] Add missing dg-require-effective-target alloca to gcc testsuite

2017-03-27 Thread Tom de Vries
On 24/03/17 18:13, Mike Stump wrote: On Mar 24, 2017, at 5:58 AM, Rainer Orth wrote: - { /* { dg-warning "statement may fall through" "" { target c } 23 } */ - int a[i]; /* { dg-warning "statement may fall through" "" { target c++ } 24 } */ + {

Re: [PATCH] Install gcov-dump.

2017-03-17 Thread Tom de Vries
, please see: <https://gcc.gnu.org/bugs/>. ... OK for trunk, 5 and 6 branch? Thanks, - Tom Print bug url for gcov-dump --help 2017-03-17 Tom de Vries <t...@codesourcery.com> * gcov-dump.c (print_usage): Print bug_report_url. --- gcc/gcov-dump.c | 2 ++ 1 file changed, 2 inserti

Re: [PATCH, testsuite] Allow braces around relative line numbers

2017-04-15 Thread Tom de Vries
On 03/29/2017 12:23 AM, Jakub Jelinek wrote: On Tue, Mar 28, 2017 at 08:27:54AM +0200, Tom de Vries wrote: this patch fixes testsuite PR80220 - "relative line numbers don't work when put between braces". What is the advantage of putting the line numbers between braces? I don't k

[RFC, testsuite] Add dg-save-linenr

2017-04-22 Thread Tom de Vries
(and possibly defined as well)? F.i.: /* { dg-save-linenr %some_func_decl } *./ /* { dg-message "but argument is of type" "" { target *-*-* } %some_func_decl } */ - error message formulation Thanks, - Tom Add dg-save-linenr 2017-04-22 Tom de Vries <t...@codesourcery.

Re: [PATCH] Add missing edge probability in simd_clone_adjust

2017-08-02 Thread Tom de Vries
On 08/02/2017 06:29 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 06:15:31PM +0200, Tom de Vries wrote: 2017-08-02 Tom de Vries<t...@codesourcery.com> * omp-simd-clone.c (simd_clone_adjust): Add missing edge probability. I think that is not the right probability, when using

[testsuite, committed] Require label_values for gcc.dg/torture/pr80163.c

2017-08-03 Thread Tom de Vries
Hi, this patch requires effective target label_values for gcc.dg/torture/pr80163.c. Committed. Thanks, - Tom Require label_values for gcc.dg/torture/pr80163.c 2017-08-02 Tom de Vries <t...@codesourcery.com> * gcc.dg/torture/pr80163.c: Require label_values. --- gcc/testsuite/

[testsuite, committed] Require alloca for gcc.dg/attr-noipa.c

2017-08-03 Thread Tom de Vries
Hi, this patch requires effective target alloca for gcc.dg/attr-noipa.c. Committed. Thanks, - Tom Require alloca for gcc.dg/attr-noipa.c 2017-08-02 Tom de Vries <t...@codesourcery.com> * gcc.dg/attr-noipa.c: Require alloca. --- gcc/testsuite/gcc.dg/attr-noipa.c | 1 + 1 file chan

[testsuite, committed] Require alias for gcc.dg/pr56727-2.c

2017-08-03 Thread Tom de Vries
Hi, this patch requires alias support for gcc.dg/pr56727-2.c. Committed. Thanks, - Tom Require alias for gcc.dg/pr56727-2.c 2017-08-02 Tom de Vries <t...@codesourcery.com> * gcc.dg/pr56727-2.c: Require alias. --- gcc/testsuite/gcc.dg/pr56727-2.c | 1 + 1 file changed, 1 ins

[testsuite, PR81662, committed] Skip fpatchable-function-entry tests for nvptx

2017-08-03 Thread Tom de Vries
2017-08-02 Tom de Vries <t...@codesourcery.com> PR target/81662 * c-c++-common/patchable_function_entry-decl.c: Skip for nvptx. * c-c++-common/patchable_function_entry-default.c: Same. * c-c++-common/patchable_function_entry-definition.c: Same. --- gcc/testsuite/c-c++-

[testsuite, committed] Use relative line number in gcc.dg/Walloca-14.c

2017-08-02 Thread Tom de Vries
Hi, Please use relative line number next time. Committed. Thanks, - Tom Use relative line number in gcc.dg/Walloca-14.c 2017-08-02 Tom de Vries <t...@codesourcery.com> * gcc.dg/Walloca-14.c: Use relative line number. --- gcc/testsuite/gcc.dg/Walloca-14.c | 2 +- 1 file changed, 1 ins

[nvptx, committed] Add missing probabilities in nvptx_lock{less,full}_update

2017-08-02 Thread Tom de Vries
was missing. I've added that, and committed. Thanks, - Tom Add missing probabilities in nvptx_lock{less,full}_update 2017-08-02 Tom de Vries <t...@codesourcery.com> Cesar Philippidis <ce...@codesourcery.com> * config/nvptx/nvptx.c (nvptx_lockless_update, nvptx_lockfull_update): Add

[nvptx, PR 81662, committed] Error out on nvptx for fpatchable-function-entry

2017-08-03 Thread Tom de Vries
[ was: Re: [testsuite, PR81662, committed] Skip fpatchable-function-entry tests for nvptx ] On 08/03/2017 09:17 AM, Tom de Vries wrote: Hi, fpatchable-function-entry requires nop, which nvptx does not have. I've disabled the corresponding test for nvptx. This patch errors out on nvptx

Re: [PATCH] Verify edge probability consistency in verify_flow_info

2017-08-04 Thread Tom de Vries
On 08/04/2017 11:15 AM, Jan Hubicka wrote: OK for trunk if bootstrap and reg-test on x86_64 succeeds? Yea, but I'd like to see ongoing work towards full checking. I have full checking in my tree for some time. At x86-64 bootstrap there is one remaining offender in simd_clone_adjust which was

[PATCH, PR81844] Fix condition folding in c_parser_omp_for_loop

2017-08-14 Thread Tom de Vries
code, while c_fully_fold breaks that assumption. The patch fixes this by folding only the operands of the condition. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Fix condition folding in c_parser_omp_for_loop 2017-08-14 Tom de Vries <t...@codesourcery.com> PR c/81844

[testsuite, committed] Require effective target nonlocal_goto for ipa/pr81696.c

2017-08-17 Thread Tom de Vries
Hi, this patch requires effective target nonlocal_goto for ipa/pr81696.c. Committed. Thanks, - Tom 2017-08-17 Tom de Vries <t...@codesourcery.com> * gcc.dg/ipa/pr81696.c: Require effective target nonlocal_goto. --- gcc/testsuite/gcc.dg/ipa/pr81696.c | 1 + 1 file chan

[PATCH, PR81030] Call compute_outgoing_frequencies at expand

2017-07-17 Thread Tom de Vries
6_64. OK for trunk? Thanks, - Tom Call compute_outgoing_frequencies at expand 2017-07-17 Tom de Vries <t...@codesourcery.com> PR middle-end/81030 * cfgbuild.c (find_many_sub_basic_blocks): Add and handle update_freq parameter. * cfgbuild.h (find_many_sub_basic_bloc

[nvptx, committed, PR81069] Insert diverging jump alap in nvptx_single

2017-07-17 Thread Tom de Vries
with nvptx accelerator. Committed. Thanks, - Tom Insert diverging jump alap in nvptx_single 2017-07-17 Tom de Vries <t...@codesourcery.com> PR target/81069 * config/nvptx/nvptx.c (nvptx_single): Insert diverging branch as late as possible. --- gcc/config/nvptx/nvptx.

[nvptx, committed] Add extra initialization of broadcasted condition variables

2017-07-11 Thread Tom de Vries
condition variables 2017-07-11 Tom de Vries <t...@codesourcery.com> * config/nvptx/nvptx.c (WORKAROUND_PTXJIT_BUG): New macro. (bb_first_real_insn): New function. (nvptx_single): Add extra initialization of broadcasted condition variables. --- gcc/config/nvptx/nvptx.

backport nvptx patch to gcc-7-branch

2017-07-18 Thread Tom de Vries
[ was: Re: [nvptx, committed, PR81069] Insert diverging jump alap in nvptx_single ] On 07/17/2017 10:41 AM, Tom de Vries wrote: Hi, Consider nvptx_single: ... /* Single neutering according to MASK. FROM is the incoming block and TO is the outgoing block. These may be the same block

[PATCH, PR81464] Handle equal-argument loop exit phi in expand_omp_for_static_chunk

2017-07-18 Thread Tom de Vries
dified in the loop. The patch fixes the ICE by not trying to fix up this particular kind of loop exit phi. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle equal-argument loop exit phi in expand_omp_for_static_chunk 2017-07-18 Tom de Vries <t...@codesourcery.com> P

[gomp4, nvptx, committed] Fix --enable-checking=rtl assert in nvptx_propagate_unified

2017-07-16 Thread Tom de Vries
[ was: Re: [gomp4, nvptx, committed] Fix assert in nvptx_propagate_unified ] On 07/06/2017 09:15 AM, Thomas Schwinge wrote: Hi Tom! On Fri, 30 Jun 2017 17:15:24 +0200, Tom de Vries <tom_devr...@mentor.com> wrote: with the openacc test-case in attached patch, I ran into an assert here:

[PR81489, committed] Fix phi arg location in find_implicit_erroneous_behavior

2017-07-20 Thread Tom de Vries
, - Tom Fix phi arg location in find_implicit_erroneous_behavior 2017-07-20 Tom de Vries <t...@codesourcery.com> PR tree-optimization/81489 * gimple-ssa-isolate-paths.c (find_implicit_erroneous_behavior): Move read of phi arg location to before loop that modifies phi. --- gcc/gimp

<    8   9   10   11   12   13   14   15   16   17   >