Re: [PATCH 7/9] [libbacktrace] Handle DW_FORM_GNU_ref_alt

2019-01-17 Thread Tom de Vries
On 17-01-19 15:14, Tom de Vries wrote: > On 17-01-19 01:35, Ian Lance Taylor wrote: >> On Wed, Jan 16, 2019 at 4:17 PM Tom de Vries wrote: >>> >>> this handles DW_FORM_GNU_ref_alt which references the .debug_info >>> section in the .gnu_debugaltlink file.

Re: libbacktrace patch RFC: check size passed to backtrace_get_view

2019-01-18 Thread Tom de Vries
On 18-01-19 16:40, Ian Lance Taylor wrote: > int > backtrace_get_view (struct backtrace_state *state ATTRIBUTE_UNUSED, > - int descriptor, off_t offset, size_t size, > + int descriptor, off_t offset, uint64_t size, > backtrace_error_callback error

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-18 Thread Tom de Vries
On 18-01-19 15:23, Ian Lance Taylor wrote: > On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: >> >> now that the rest of the patch series has been committed, here's an >> updated version of this patch that applies to trunk. > > I would much rather put dw

Re: [PATCH 9/9] [libbacktrace] Add printdwarftest_dwz_cmp.sh test-case

2019-01-22 Thread Tom de Vries
On 19-01-19 01:54, Ian Lance Taylor wrote: > On Fri, Jan 18, 2019 at 4:45 PM Tom de Vries wrote: >> >> On 18-01-19 15:23, Ian Lance Taylor wrote: >>> On Thu, Jan 17, 2019 at 5:59 AM Tom de Vries wrote: >>>> >>>> now that the rest of the patch s

[libbacktrace] Use size_t for low_offset/high_offset fields of struct unit

2019-01-22 Thread Tom de Vries
[ was: Re: [PATCH 7/9] [libbacktrace] Handle DW_FORM_GNU_ref_alt ] On 18-01-19 15:25, Ian Lance Taylor wrote: > On Thu, Jan 17, 2019 at 6:14 AM Tom de Vries wrote: >> >> On 17-01-19 01:35, Ian Lance Taylor wrote: >>> On Wed, Jan 16, 2019 at 4:17 PM Tom de Vries wrote

[committed][nvptx, libgomp] Fix map_push

2019-01-23 Thread Tom de Vries
hat the element is cleanly popped from the queue - rewriting the push element part in such a way that it can handle all cases without needing if statements, such that each line is exercised for each of the three cases. Committed to trunk. Thanks, - Tom [nvptx, libgomp] Fix map_push 2019-

[committed][nvptx, libgomp] Fix assert (!s->map->active) in map_fini

2019-01-23 Thread Tom de Vries
(though in the async case, this is more a workaround than an fix). Committed to trunk. Thanks, - Tom [nvptx, libgomp] Fix assert (!s->map->active) in map_fini 2019-01-22 Tom de Vries PR target/88941 PR target/88939 * plugin/plugin-nvptx.c (cuda_map_destroy): Han

[committed][nvptx, libgomp] Fix cuMemAlloc with size zero

2019-01-23 Thread Tom de Vries
abort happened. Fix this by calling cuMemFree with CUDA_CALL_NOCHECK in cuda_map_destroy. Committed to trunk. Thanks, - Tom [nvptx, libgomp] Fix cuMemAlloc with size zero 2019-01-22 Tom de Vries PR target/PR88946 * plugin/plugin-nvptx.c (cuda_map_destroy): Use CUDA_CALL_NOCHEC

[committed][nvptx, libgomp] Fix memleak in GOMP_OFFLOAD_fini_device

2019-01-24 Thread Tom de Vries
of ptx_devices in nvptx_init. Fix this by freeing ptx_devices in GOMP_OFFLOAD_fini_device, once instantiated_devices drops to 0. Committed to trunk. Thanks, - Tom [nvptx, libgomp] Fix memleak in GOMP_OFFLOAD_fini_device 2019-01-24 Tom de Vries * plugin/plugin-nvpt

Re: [backtrace] Avoid segfault

2019-01-25 Thread Tom de Vries
buglink Create a pattern rule for copying an existing test-case, separating out the debug information into a .debug file, and referencing the .debug file from the copied test-case using a .gnu_debuglink. 2019-01-25 Tom de Vries * Makefile.am: Rewrite dtest rule into "%_gnudebuglink&quo

Re: [backtrace] Avoid segfault

2019-01-25 Thread Tom de Vries
On 25-01-19 14:17, Tom de Vries wrote: > On 25-01-19 01:51, Ian Lance Taylor wrote: >> On Thu, Jan 24, 2019 at 4:11 PM Nathan Sidwell wrote: >>> >>> I just tripped over a segfault in libbacktrace. We apply strrchr to a >>> possibly NULL filename,

Re: [backtrace] Avoid segfault

2019-01-27 Thread Tom de Vries
On 25-01-19 18:15, Nathan Sidwell wrote: > On 1/25/19 5:28 AM, Tom de Vries wrote: >> >> This patch fixes it by passing "" instead of NULL, in the call to >> elf_add at line 3083 (for .gnu_debugaltlink), not the call to elf_add at >> line 3044 (for .gnu_deb

[libbacktrace] Fix and simplify xcoff_%.c pattern rule

2019-01-28 Thread Tom de Vries
[ was: Re: [backtrace] Avoid segfault ] On 27-01-19 22:53, Ian Lance Taylor wrote: > On Sun, Jan 27, 2019 at 1:16 PM Tom de Vries wrote: >> >> On 25-01-19 18:15, Nathan Sidwell wrote: >>> On 1/25/19 5:28 AM, Tom de Vries wrote: >>>> >>>> This patc

[libbacktrace] Add gen-xcoff-n.sh

2019-01-28 Thread Tom de Vries
[ was: Re: [libbacktrace] Fix and simplify xcoff_%.c pattern rule ] On 28-01-19 10:25, Tom de Vries wrote: > [ was: Re: [backtrace] Avoid segfault ] > On 27-01-19 22:53, Ian Lance Taylor wrote: >> On Sun, Jan 27, 2019 at 1:16 PM Tom de Vries wrote: >>> >>> On

[libbacktrace] Don't assign check_PROGRAMS to TESTS

2019-01-28 Thread Tom de Vries
[ was: Re: [backtrace] Avoid segfault ] On 27-01-19 22:16, Tom de Vries wrote: > +# The file b2test_buildid is an objcopy of b2test, so these programs share > the > +# same build-id. The first time b2test is run, there's no corresponding > debug > +# file at ./usr/lib/d

Re: [backtrace] Avoid segfault

2019-01-29 Thread Tom de Vries
On 27-01-19 22:53, Ian Lance Taylor wrote: > On Sun, Jan 27, 2019 at 1:16 PM Tom de Vries wrote: >> >> On 25-01-19 18:15, Nathan Sidwell wrote: >>> On 1/25/19 5:28 AM, Tom de Vries wrote: >>>> >>>> This patch fixes it by passing "" inst

[PATCH][libbacktrace] Fix .gnu_debugaltlink build-id check

2019-01-31 Thread Tom de Vries
Hi, The 'debugaltlink_name_len =+ 1' bug reported in PR89136 exposes the fact that the build-id is not verified for the .gnu_debugaltlink. Fix both problems. OK for trunk? Thanks, - Tom [libbacktrace] Fix .gnu_debugaltlink build-id check 2019-01-31 Tom de Vries PR li

[committed][libbacktrace] Handle DW_FORM_ref_addr

2019-02-08 Thread Tom de Vries
Hi, Add handling of the DW_FORM_ref_addr encoding to libbacktrace. Committed to trunk. Thanks, - Tom [libbacktrace] Handle DW_FORM_ref_addr 2019-02-08 Tom de Vries PR libbacktrace/78063 * dwarf.c (build_address_map): Keep all parsed units

[PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-08 Thread Tom de Vries
inlined, causing them to skip over the caller instead. Fix this by declaring the functions with __attribute__((noinline)). OK for trunk? Thanks, - Tom [libbacktrace] Declare external backtrace fns noinline 2019-02-08 Tom de Vries * backtrace.c (backtrace_full): Declare with

[PATCH][libbacktrace] Add btest_lto

2019-02-08 Thread Tom de Vries
Hi, Add libbacktrace test-case using -flto. OK for trunk? Thanks, - Tom [libbacktrace] Add btest_lto 2019-02-08 Tom de Vries * Makefile.am (BUILDTESTS): Add btest_lto. * Makefile.in: Regenerate. * btest.c (test1, f2, f3, test3, f22, f23): Declare with

Re: [PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-09 Thread Tom de Vries
On 08-02-19 18:25, Thomas Schwinge wrote: > Hi Tom! > > On Fri, 8 Feb 2019 10:41:47 +0100, Tom de Vries wrote: >> The backtrace functions backtrace_full, backtrace_print and backtrace_simple >> walk the call stack, but make sure to skip the first entry, in order to skip

Re: [PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-09 Thread Tom de Vries
On 09-02-19 22:07, Ian Lance Taylor wrote: > On Fri, Feb 8, 2019 at 9:26 AM Thomas Schwinge > wrote: >> >> On Fri, 8 Feb 2019 10:41:47 +0100, Tom de Vries wrote: >>> The backtrace functions backtrace_full, backtrace_print and backtrace_simple >>> walk the c

Re: [PATCH][libbacktrace] Add btest_lto

2019-02-09 Thread Tom de Vries
On 09-02-19 22:49, Ian Lance Taylor wrote: > On Fri, Feb 8, 2019 at 1:42 AM Tom de Vries wrote: >> >> Add libbacktrace test-case using -flto. >> >> OK for trunk? >> >> Thanks, >> - Tom >> >> [libbacktrace] Add btest_lto >> >&g

Re: [PATCH][libbacktrace] Declare external backtrace fns noinline

2019-02-09 Thread Tom de Vries
On 09-02-19 22:07, Ian Lance Taylor wrote: > On Fri, Feb 8, 2019 at 9:26 AM Thomas Schwinge > wrote: >> >> On Fri, 8 Feb 2019 10:41:47 +0100, Tom de Vries wrote: >>> The backtrace functions backtrace_full, backtrace_print and backtrace_simple >>> walk the c

[PATCH][libbacktrace] Handle bsearch with NULL base in dwarf_lookup_pc

2019-02-12 Thread Tom de Vries
declares base with attribute non-null, so the NULL will trigger a sanitizer runtime error. Fix this by only calling bsearch if nmemb != 0. OK for trunk? Thanks, - Tom [libbacktrace] Handle bsearch with NULL base in dwarf_lookup_pc 2019-02-12 Tom de Vries PR libbacktrace/81983

[PATCH, 1/4] Handle errors in both args of va_arg

2016-08-23 Thread Tom de Vries
gimplify_va_arg_expr to build_va_arg. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle errors in both args of va_arg 2016-08-22 Tom de Vries * c-common.c (build_va_arg): Add first argument error. Build va_arg with error_mark_node as va_list instead of with illegal va_list

[PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-08-23 Thread Tom de Vries
trunk? Thanks, - Tom Replace error_at with assert in build_va_arg 2016-08-22 Tom de Vries * c-common.c (build_va_arg): Replace first argument type error with assert. --- gcc/c-family/c-common.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/gcc/c-fam

[PATCH, 3/4] Fix assert in build_va_arg, case 2b

2016-08-23 Thread Tom de Vries
Hi, this patch fixes an assert in build_va_arg. Instead of testing for pointer equality, we use the same test as is used in std_canonical_va_list_type. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Fix assert in build_va_arg, case 2b 2016-08-22 Tom de Vries * c

[PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-23 Thread Tom de Vries
[ was: Re: [PATCH, PR71602] Give error for invalid va_list argument to va_arg ] On 23/06/16 23:21, Jason Merrill wrote: On Thu, Jun 23, 2016 at 1:27 PM, Tom de Vries wrote: Hi, this patch fixes PR71602, a 6/7 regression. Consider this test-case:>> The patch fixes the ICE by maki

[PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-24 Thread Tom de Vries
ed on x86_64. OK for trunk, 6 branch? Thanks, - Tom Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute 2016-08-24 Tom de Vries PR lto/70955 * config/i386/i386.c (ix86_build_builtin_va_list_64): Tag type with sysv_abi attribute. (ix86_build_builtin_va_list): Tag type with ms_abi attr

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-25 Thread Tom de Vries
On 25/08/16 13:48, Richard Biener wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: Hi, in PR70955, ix86_canonical_va_list_type fails to recognize a __builtin_ms_va_list that was declared in a TU, because its type doesn't have the same main variant as the ms_va_list_type_node initializ

Re: [PATCH, PR70955] Tag {ms,sysv}_va_list_type_node with {ms,sysv}_abi attribute

2016-08-26 Thread Tom de Vries
otstrapped and reg-tested on x86_64 -m64/-m32. OK for trunk, 6 branch? Thanks, - Tom Tag {ms,sysv}_va_list_type_node with '{ms,sysv}_abi va_list' attribute 2016-08-24 Tom de Vries PR lto/70955 * config/i386/i386.c (ix86_build_builtin_va_list_64): Tag type with 'sy

Re: [committed] Backport r238728 testsuite g++.dg/init/elide5.C fix (PR testsuite/77034)

2016-08-28 Thread Tom de Vries
On 16/08/16 09:18, Jakub Jelinek wrote: Hi! I've backported following fix to 6 branch: 2016-08-16 Jakub Jelinek PR testsuite/77034 Backported from mainline 2016-07-25 Jason Merrill * g++.dg/init/elide5.C (operator new): Use decltype(sizeof(1)) instead

backport PR61929 fix to 5 branch

2016-08-28 Thread Tom de Vries
[was: Re: [PATCH] [graphite] fix pr61929] On 17/07/15 06:31, Tobias Grosser wrote: On 07/17/2015 12:23 AM, Sebastian Pop wrote: This fixes bootstrap of GCC with BOOT_CFLAGS="-g -O2 -fgraphite-identity -floop-nest-optimize -floop-block -floop-interchange -floop-strip-mine". It passes regstrap on

Re: [PATCH, testsuite]: Use -gdwarf-2 for g++.dg/other/anon5.C

2016-08-29 Thread Tom de Vries
On 01/02/16 23:10, Jeff Law wrote: On 02/01/2016 03:05 PM, Uros Bizjak wrote: Hello! This test case fails for targets, where dwarf-4 is unsupported (e.g. CentOS 5.11) with /usr/bin/ld: Dwarf Error: found dwarf version '4', this reader only handles version 2 information. We can use -gdwarf-2 h

Re: [PATCH] Fix PR64078

2016-08-29 Thread Tom de Vries
On 17/09/15 20:08, Marek Polacek wrote: On Thu, Sep 17, 2015 at 08:06:48PM +0200, Bernd Edlinger wrote: Hi, On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: On 09/17/2015 09:00 AM, Marek Polacek wrote: On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: Hi, On Wed, 9 Sep 2015 09:3

Re: [PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-29 Thread Tom de Vries
On 29/08/16 17:51, Joseph Myers wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: This patch fixes PR71602 by making canonical_va_list_type more strict. Bootstrapped and reg-tested on x86_64. OK for trunk, 6-branch? ENOPATCH Patch attached this time. Thanks, - Tom Make

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 29/08/16 18:43, Bernd Edlinger wrote: make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-size-9.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution

Re: PR35503 - warn for restrict pointer

2016-08-30 Thread Tom de Vries
On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified parameter and it aliases with another argument. eg: int foo (const char *__restrict buf, const char *__restrict fmt, ...); void f(void) {

Re: PR35503 - warn for restrict pointer

2016-08-30 Thread Tom de Vries
On 30/08/16 17:34, Prathamesh Kulkarni wrote: On 30 August 2016 at 20:24, Tom de Vries wrote: On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified parameter and it aliases with another

Re: [PATCH] Fix PR64078

2016-08-30 Thread Tom de Vries
On 30/08/16 11:38, Bernd Edlinger wrote: On 08/30/16 10:21, Tom de Vries wrote: On 29/08/16 18:43, Bernd Edlinger wrote: Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic&#x

Re: PR35503 - warn for restrict pointer

2016-08-31 Thread Tom de Vries
On 30/08/16 16:54, Tom de Vries wrote: On 26/08/16 13:39, Prathamesh Kulkarni wrote: Hi, The following patch adds option -Wrestrict that warns when an argument is passed to a restrict qualified parameter and it aliases with another argument. eg: int foo (const char *__restrict buf, const char

[PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-03 Thread Tom de Vries
pe as engrained in apply_identity_attributes. Bootstrapped and reg-tested on x86_64. OK for trunk, 6 branch? Thanks, - Tom Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list 2016-09-03 Tom de Vries PR c++/77427 * config/i386/i386.c (ix86_build_builtin_va_list_64): Set TYPE_STRUCTUR

Re: [PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-09-03 Thread Tom de Vries
On 03/09/16 17:37, Andreas Schwab wrote: On Aug 24 2016, Tom de Vries wrote: > Replace error_at with assert in build_va_arg > > 2016-08-22 Tom de Vries > >* c-common.c (build_va_arg): Replace first argument type error >with assert. /daten/gcc/gcc-20160902

Re: [PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-09-04 Thread Tom de Vries
On 03/09/16 17:37, Andreas Schwab wrote: On Aug 24 2016, Tom de Vries wrote: > Replace error_at with assert in build_va_arg > > 2016-08-22 Tom de Vries > >* c-common.c (build_va_arg): Replace first argument type error >with assert. /daten/gcc/gcc-20160902

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-04 Thread Tom de Vries
On 04/09/16 08:12, Richard Biener wrote: On September 3, 2016 5:23:35 PM GMT+02:00, Tom de Vries wrote: >Hi, > >this patch fixes a c++ ICE, a p1 6/7 regression. > > >Consider test.C: >... >void bar (__builtin_va_list &); > >struct c >{ > operator c

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-04 Thread Tom de Vries
On 04/09/16 16:08, Richard Biener wrote: On September 4, 2016 12:33:02 PM GMT+02:00, Tom de Vries wrote: On 04/09/16 08:12, Richard Biener wrote: On September 3, 2016 5:23:35 PM GMT+02:00, Tom de Vries wrote: Hi, this patch fixes a c++ ICE, a p1 6/7 regression. Consider test.C

Re: [PATCH, c++, PR77427 ] Set TYPE_STRUCTURAL_EQUALITY for sysv_abi va_list

2016-09-05 Thread Tom de Vries
On 05/09/16 09:49, Richard Biener wrote: On Sun, Sep 4, 2016 at 11:30 PM, Tom de Vries wrote: > On 04/09/16 16:08, Richard Biener wrote: >> >> On September 4, 2016 12:33:02 PM GMT+02:00, Tom de Vries >> wrote: >>> >>> On 04/09/16 08:12, Richard Biener

[PATCH, PR69067] Remove assert in get_def_bb_for_const

2016-05-29 Thread Tom de Vries
rt. Bootstrapped and reg-tested on x86_64. OK for trunk, 6-branch? Thanks, - Tom Remove assert in get_def_bb_for_const 2016-05-29 Tom de Vries PR tree-optimization/69067 * graphite-isl-ast-to-gimple.c (get_def_bb_for_const): Remove assert. * gcc.dg/graphite/pr69067.c: New test

[PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
raphite code generation when encountering a phi with more than two arguments in copy_bb_and_scalar_dependences. Bootstrapped and reg-tested on x86_64. OK for trunk, 6 branch? Thanks, - Tom Handle 3-arg phi in copy_bb_and_scalar_dependences 2016-05-30 Tom de Vries PR tree-optimi

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 11:46, Richard Biener wrote: This patch fixes the assert conservatively by aborting graphite code >generation when encountering a phi with more than two arguments in >copy_bb_and_scalar_dependences. > >Bootstrapped and reg-tested on x86_64. > >OK for trunk, 6 branch? Did you check

Re: [PATCH, PR69068] Handle 3-arg phi in copy_bb_and_scalar_dependences

2016-05-30 Thread Tom de Vries
On 30/05/16 12:56, Richard Biener wrote: On Mon, 30 May 2016, Tom de Vries wrote: >On 30/05/16 11:46, Richard Biener wrote: > > >This patch fixes the assert conservatively by aborting graphite code > > > >generation when encountering a phi with mo

[PATCH, PR71602] Give error for invalid va_list argument to va_arg

2016-06-23 Thread Tom de Vries
r invalid va_list argument to va_arg 2016-06-22 Tom de Vries PR c/71602 * c-common.c (build_va_arg): Add comp_types parameter. Give error for invalid va_list argument. * c-common.h (build_va_arg): Add comp_types parameter. * c-typeck.c (va_list_comptypes): New function. (c_build_va_arg):

[openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-16 Thread Tom de Vries
Hi, this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks, - Tom Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices 2017-10-16 Tom de Vries * testsuite/libgomp.oacc-c-c++-common/declare-1.c: Don't require openacc_nvidia_accel_sel

[PATCH, testsuite] Add dg-require-stack-size

2017-10-16 Thread Tom de Vries
} } ... it's listed as unsupported instead. The info entry looks like: ... 'dg-require-stack-size SIZE' Skip the test if the target does not support a stack size of SIZE. ... OK for trunk? Thanks, - Tom Add dg-require-stack-size 2017-10-16 Tom de Vries * gcc.dg/t

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 01:19 PM, Thomas Schwinge wrote: Hi! On Mon, 16 Oct 2017 10:49:45 +0200, Tom de Vries wrote: this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks! --- a/libgomp/testsuite/libgomp.oacc-fortran/declare-1.f90 +++ b/libgomp/testsuite/libgomp.oacc

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 02:51 PM, Tom de Vries wrote: On 10/17/2017 01:19 PM, Thomas Schwinge wrote: Hi! On Mon, 16 Oct 2017 10:49:45 +0200, Tom de Vries  wrote: this patch enables some openacc test-cases for non-nvidia devices. Committed. Thanks! --- a/libgomp/testsuite/libgomp.oacc-fortran

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 04:46 PM, Jakub Jelinek wrote: On Tue, Oct 17, 2017 at 04:42:58PM +0200, Tom de Vries wrote: I found the culprit, in gfortran-dg-runtest: ... # look if this is dg-do-run test, in which case # we cycle through the option list, otherwise we don't

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-17 Thread Tom de Vries
On 10/17/2017 05:34 PM, Tom de Vries wrote: On 10/17/2017 04:46 PM, Jakub Jelinek wrote: the presence/absence of explicit dg-do run can then be used to decide if it should loop through options or not. I'd be in favor of specifying this clearly, f.i. as: ... '! { dg-no-tortu

Re: [PATCH, testsuite] Add dg-require-stack-size

2017-10-18 Thread Tom de Vries
On 10/17/2017 06:14 PM, Mike Stump wrote: On Oct 16, 2017, at 3:16 AM, Tom de Vries wrote: I noticed gcc.dg/tree-ssa/ldist-27.c failing for nvptx due to a too large stack size. OK for trunk? Hum. There is an existing mechanism (find-grep STACK_SIZE) in the tree to handle the same

Re: [openacc, testsuite, committed] Enable libgomp.oacc-*/declare-*.{c,f90} for non-nvidia devices

2017-10-18 Thread Tom de Vries
On 10/17/2017 06:33 PM, Mike Stump wrote: On Oct 17, 2017, at 8:34 AM, Tom de Vries wrote: OK, if full testing is ok? I believe this was fully intentional and the presence/absence of explicit dg-do run can then be used to decide if it should loop through options or not. I don't s

Re: [PATCH GCC][4/7]Choose exit edge/path when removing inner loop's exit statement

2017-10-19 Thread Tom de Vries
/tree-ssa/ldist-27.c 2017-10-19 Tom de Vries * gcc.dg/tree-ssa/ldist-27.c: Use dg-require-stack-size. --- gcc/testsuite/gcc.dg/tree-ssa/ldist-27.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ldist-27.c b/gcc/testsuite/gcc.dg/tree-ssa/ldist-27.c index 358

Re: [PATCH GCC][4/7]Choose exit edge/path when removing inner loop's exit statement

2017-10-20 Thread Tom de Vries
On 10/19/2017 10:49 AM, Bin.Cheng wrote: On Thu, Oct 19, 2017 at 9:31 AM, Tom de Vries wrote: On 10/09/2017 03:34 PM, Richard Biener wrote: On Thu, Oct 5, 2017 at 3:16 PM, Bin Cheng wrote: Hi, Function generate_loops_for_partition chooses arbitrary path when removing exit condition not in

[testsuite, committed] Fix scan-assembler in tree-ssa/loop-1.c for nvptx

2017-10-25 Thread Tom de Vries
Hi, this patch fixes a scan-assembler line in tree-ssa/loop-1.c for nvptx. Committed. Thanks, - Tom Fix scan-assembler in tree-ssa/loop-1.c for nvptx 2017-10-25 Tom de Vries * gcc.dg/tree-ssa/loop-1.c: Add xfail for nvptx in scan-assembler-times line, and add nvptx-specific version

[PATCH] Implement omp async support for nvptx

2017-10-27 Thread Tom de Vries
ssing, and there are no regressions. OK for trunk after complete testing (and adding function comment for default_async_run)? Thanks, - Tom Move async_run from plugin-hsa.c to default_async_run 2017-10-27 Tom de Vries * plugin/plugin-hsa.c (struct async_run_i

Re: [PATCH] Implement omp async support for nvptx

2017-10-30 Thread Tom de Vries
On 10/30/2017 08:15 AM, Jakub Jelinek wrote: On Fri, Oct 27, 2017 at 03:57:28PM +0200, Tom de Vries wrote: how about this approach: 1 - Move async_run from plugin-hsa.c to default_async_run 2 - Implement omp async support for nvptx ? The first patch moves the GOMP_OFFLOAD_async_run

Re: [PATCH] Implement omp async support for nvptx

2017-10-30 Thread Tom de Vries
On 10/30/2017 12:55 PM, Tom de Vries wrote: On 10/30/2017 08:15 AM, Jakub Jelinek wrote: On Fri, Oct 27, 2017 at 03:57:28PM +0200, Tom de Vries wrote: how about this approach: 1 - Move async_run from plugin-hsa.c to default_async_run 2 - Implement omp async support for nvptx ? The first patch

[libgomp, hsa,committed] Remove semicolon after do {} while (false) in HSA_LOG

2017-10-31 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (false)" in HSA_LOG, making sure we can use it in if-then-elses without curly braces. Build hsa plugin. Committed as trivial. Thanks, - Tom Remove semicolon after do {} while (false) in HSA_LOG 2017-10-31 Tom de Vries

[testsuite, committed] Fix scan pattern in gfortran.dg/implied_do_io_1.f90

2017-11-02 Thread Tom de Vries
made this scan fail (with 25 matches, instead of 7), because the dump contains lines with .common.filename = &"". Fixed by making the scan more precise. Committed as obvious. Thanks, - Tom Fix scan pattern in gfortran.dg/implied_do_io_1.f90 2017-11-02 Tom de Vries * gf

[testsuite, committed] Fix scan-assembler patterns in i386/naked-{1,2}.c

2017-11-02 Thread Tom de Vries
ks, - Tom Fix scan-assembler patterns in i386/naked-{1,2}.c 2017-11-02 Tom de Vries PR testsuite/82415 * gcc.target/i386/naked-1.c: Make scan patterns more precise. * gcc.target/i386/naked-2.c: Same. --- gcc/testsuite/gcc.target/i386/naked-1.c | 4 ++-- gcc/testsuite/gcc.target/i386/naked-2.c

[PATCH 1/7] [libsanitizer, committed] Remove semicolon after do {} while (0) in macro body

2017-11-05 Thread Tom de Vries
Hi, this removes a semicolon after "do {} while (0)" in several macro bodies in libsanitizer. This allows the macros to be used in if-then-elses without curly braces. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784 * asan/asan_po

[PATCH 4/7] [fortran, committed] Remove semicolon after do {} while (0) in match macros

2017-11-05 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in match macros. This allows the macros to be used in if-then-elses without curly braces. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784 * parse.c (match, matcha, matchs, matcho, matchd

[PATCH 2/7] [libquadmath, committed] Remove semicolon after do {} while (0) in MPN_MUL_N_RECURSE

2017-11-05 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in MPN_MUL_N_RECURSE. This allows the macro to be used in if-then-elses without curly braces. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784 * printf/gmp-impl.h (MPN_MUL

[PATCH 3/7] [graphite, committed] Remove semicolon after do {} while (0) in DEBUG_PRINT

2017-11-05 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in DEBUG_PRINT. This allows the macro to be used in if-then-elses without curly braces. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784 * graphite-scop-detection.c (DEBUG_PRIN

[PATCH 5/7][committed] Remove semicolon after ASM_OUTPUT_BEFORE_CASE_LABEL macro body

2017-11-05 Thread Tom de Vries
Hi, this patch removes a semicolon after ASM_OUTPUT_BEFORE_CASE_LABEL macro bodies. This allows the macro to be used in if-then-elses without curly braces. Bootstrapped and reg-tested on x86_64. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784

[PATCH 6/7] [libcpp,committed] Remove semicolon after do {} while (0) in BUF_APPEND

2017-11-05 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in BUF_APPEND. This allows the macro to be used in if-then-elses without curly braces. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784 * lex.c (BUF_APPEND): Remove semic

[PATCH 7/7][committed] Remove semicolon after do {} while (0) in DEF_SANITIZER_BUILTIN

2017-11-05 Thread Tom de Vries
UILTIN_1 in the if statement as a normal single statement, as made possible by the "do {} while (0)". The original DEF_SANITIZER_BUILTIN is still used with the .def file, as before. Committed as obvious. Thanks, - Tom 2017-11-02 Tom de Vries PR other/82784

Re: [PATCH 4/7] [fortran, committed] Remove semicolon after do {} while (0) in match macros

2017-11-05 Thread Tom de Vries
On 11/05/2017 03:32 PM, Steve Kargl wrote: On Sun, Nov 05, 2017 at 11:05:02AM +0100, Tom de Vries wrote: this patch removes a semicolon after "do {} while (0)" in match macros. The patch contains this part. This allows the macros to be used in if-then-elses without curly bra

[libgcc, committed] Remove semicolon after do {} while (0) in FP_HANDLE_EXCEPTIONS

2017-11-07 Thread Tom de Vries
ile (0) in FP_HANDLE_EXCEPTIONS 2017-11-06 Tom de Vries PR other/82784 * config/aarch64/sfp-machine.h (FP_HANDLE_EXCEPTIONS): Remove semicolon after "do {} while (0)". * config/i386/sfp-machine.h (FP_HANDLE_EXCEPTIONS): Same. * config/ia64/sfp-machine.h (FP_HANDLE_EXCEPTIONS): Same

[arm, committed] Remove semicolon after while {} do (0) in HANDLE_NARROW_SHIFT_ARITH

2017-11-07 Thread Tom de Vries
HIFT_ARITH 2017-11-06 Tom de Vries PR other/82784 * config/arm/arm.c (HANDLE_NARROW_SHIFT_ARITH): Remove semicolon after "while {} do (0)". (arm_rtx_costs_internal): Add missing semicolon after HANDLE_NARROW_SHIFT_ARITH call. --- gcc/config/arm/arm.c | 8 1 file c

[libgcc, rs6000] Remove semicolon after do {} while (0) in REGISTER_CFA_OFFSET_FOR

2017-11-07 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in REGISTER_CFA_OFFSET_FOR (no ChangeLog yet). Can you build & test this patch (or approve as trivial)? Thanks, - Tom [libgcc, rs6000] Remove semicolon after do {} while (0) in REGISTER_CFA_OFFSET_FOR --- libgcc/config/rs6000/aix-un

[powerpcspe, rs6000] Remove semicolon after do {} while (0) in SUBTARGET_OVERRIDE_OPTIONS

2017-11-07 Thread Tom de Vries
Hi, this patch removes a semicolon after "do {} while (0)" in SUBTARGET_OVERRIDE_OPTIONS (no ChangeLog yet). Can you build & test this patch (or approve as trivial)? Thanks, - Tom [powerpcspe, rs6000] Remove semicolon after do {} while (0) in SUBTARGET_OVERRIDE_OPTIONS --- gcc/config/powerp

Re: [powerpcspe, rs6000] Remove semicolon after do {} while (0) in SUBTARGET_OVERRIDE_OPTIONS

2017-11-07 Thread Tom de Vries
On 11/07/2017 09:55 AM, Tom de Vries wrote: Hi, this patch removes a semicolon after "do {} while (0)" in SUBTARGET_OVERRIDE_OPTIONS (no ChangeLog yet). Can you build & test this patch (or approve as trivial)? Hi, Can you build & test the powerpcspe part of this pa

[nvptx, committed] Add extra initialization of broadcasted condition variables

2017-07-11 Thread Tom de Vries
asted condition variables 2017-07-11 Tom de Vries * config/nvptx/nvptx.c (WORKAROUND_PTXJIT_BUG): New macro. (bb_first_real_insn): New function. (nvptx_single): Add extra initialization of broadcasted condition variables. --- gcc/config/nvptx/nvptx.c

[gomp4, nvptx, committed] Fix --enable-checking=rtl assert in nvptx_propagate_unified

2017-07-16 Thread Tom de Vries
[ was: Re: [gomp4, nvptx, committed] Fix assert in nvptx_propagate_unified ] On 07/06/2017 09:15 AM, Thomas Schwinge wrote: Hi Tom! On Fri, 30 Jun 2017 17:15:24 +0200, Tom de Vries wrote: with the openacc test-case in attached patch, I ran into an assert here: Using your test case, in my

[nvptx, committed, PR81069] Insert diverging jump alap in nvptx_single

2017-07-17 Thread Tom de Vries
86_64 with nvptx accelerator. Committed. Thanks, - Tom Insert diverging jump alap in nvptx_single 2017-07-17 Tom de Vries PR target/81069 * config/nvptx/nvptx.c (nvptx_single): Insert diverging branch as late as possible. --- gcc/config/nvptx/nvptx.c | 22 +++--- 1

[PATCH, PR81030] Call compute_outgoing_frequencies at expand

2017-07-17 Thread Tom de Vries
sted on x86_64. OK for trunk? Thanks, - Tom Call compute_outgoing_frequencies at expand 2017-07-17 Tom de Vries PR middle-end/81030 * cfgbuild.c (find_many_sub_basic_blocks): Add and handle update_freq parameter. * cfgbuild.h (find_many_sub_basic_blocks): Add update_freq paramete

backport nvptx patch to gcc-7-branch

2017-07-18 Thread Tom de Vries
[ was: Re: [nvptx, committed, PR81069] Insert diverging jump alap in nvptx_single ] On 07/17/2017 10:41 AM, Tom de Vries wrote: Hi, Consider nvptx_single: ... /* Single neutering according to MASK. FROM is the incoming block and TO is the outgoing block. These may be the same block

[PATCH, PR81464] Handle equal-argument loop exit phi in expand_omp_for_static_chunk

2017-07-18 Thread Tom de Vries
variable is not modified in the loop. The patch fixes the ICE by not trying to fix up this particular kind of loop exit phi. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Handle equal-argument loop exit phi in expand_omp_for_static_chunk 2017-07-18 Tom de Vries PR m

Re: [PATCH, PR81464] Handle equal-argument loop exit phi in expand_omp_for_static_chunk

2017-07-18 Thread Tom de Vries
On 07/18/2017 06:59 PM, Jakub Jelinek wrote: On Tue, Jul 18, 2017 at 06:48:56PM +0200, Tom de Vries wrote: Hi, this patch fixes PR81464, an ICE in ompexpssa. The ICE occurs in expand_omp_for_static_chunk when we're trying to fix up a loop exit phi: ... # .MEM_88 = PHI <.MEM_86(46),

[committed] Fix assert in gimple_phi_arg

2017-07-19 Thread Tom de Vries
rt in gimple_phi_arg 2017-07-19 Tom de Vries * gimple.h (gimple_phi_arg): Make assert more strict. --- gcc/gimple.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gimple.h b/gcc/gimple.h index 575babe..e19cc1c 100644 --- a/gcc/gimple.h +++ b/gcc/gimple.h @@ -43

[committed] Fix assert in gimple_phi_set_arg

2017-07-19 Thread Tom de Vries
ndition should be 'index < phi->capacity'). Bootstrapped and reg-tested on x86_64. Committed as obvious. Thanks, - Tom Fix assert in gimple_phi_set_arg 2017-07-19 Tom de Vries * gimple.h (gimple_phi_set_arg): Make assert more strict. --- gcc/gimple.h | 2 +- 1 file changed, 1

[PR81489, committed] Fix phi arg location in find_implicit_erroneous_behavior

2017-07-20 Thread Tom de Vries
hanks, - Tom Fix phi arg location in find_implicit_erroneous_behavior 2017-07-20 Tom de Vries PR tree-optimization/81489 * gimple-ssa-isolate-paths.c (find_implicit_erroneous_behavior): Move read of phi arg location to before loop that modifies phi. --- gcc/gimple-ssa-isolate-paths.c | 4 ++

[PATCH] Make assert in gimple_phi_arg more strict

2017-07-20 Thread Tom de Vries
manipulation. Using this patch, I found PR81489 - "invalid phi argument used in find_implicit_erroneous_behavior". Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Make assert in gimple_phi_arg more strict 2017-07-20 Tom de Vries * gimple.h (gimple_phi_arg): Make a

Re: [committed] Fix assert in gimple_phi_arg

2017-07-20 Thread Tom de Vries
On 07/20/2017 10:46 AM, Richard Biener wrote: On Wed, Jul 19, 2017 at 5:42 PM, Tom de Vries wrote: Hi, this patch makes an assert in gimple_phi_arg more strict. The current assert allows 'index == phi_stmt->capacity', but 'phi_stmt->args[phi_stmt->capacity]' is

[PATCH, PR81430] Use finalize_options in lto1

2017-07-20 Thread Tom de Vries
Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom Use finalize_options in lto1 2017-07-20 Tom de Vries PR lto/81430 * function.c (invoke_set_current_function_hook): Call finish_options in lto1 after cl_optimization_restore. --- gcc/function.c | 6 ++ 1 file changed, 6 i

Re: [PATCH] Make assert in gimple_phi_arg more strict

2017-07-20 Thread Tom de Vries
On 07/20/2017 12:05 PM, Richard Biener wrote: I've used the following to only init the PHI node up to nargs, not capacity (but still consistently zero things). Currently bootstrapping/testing on x86_64-unknown-linux-gnu (plus the adjusted assert of course). I think it's slightly cleaner than ad

Re: [PATCH] update edge profile info in nvptx.c

2017-07-20 Thread Tom de Vries
On 07/13/2017 06:53 PM, Cesar Philippidis wrote: Similarly, for nvptx vector reductions, when it comes time to initialize the reduction variable, the nvptx BE constructs a branch so that only vector lanes 1 to vector_length-1 are initialized the the default value for a given reduction type, where

Re: [PATCH] update edge profile info in nvptx.c

2017-07-20 Thread Tom de Vries
On 07/20/2017 04:12 PM, Cesar Philippidis wrote: Would you like to take over this patch? I saw that you started working on this issue (or a similar one to it) in PR81442. Sure. Thanks, - Tom

<    11   12   13   14   15   16   17   18   19   20   >