[testsuite] Require stack size for some test-cases

2018-01-08 Thread Tom de Vries
-01-08 Tom de Vries * gcc.dg/graphite/interchange-7.c: Add dg-require-stack-size. * gcc.dg/graphite/run-id-1.c: Same. * gcc.dg/tree-ssa/loop-interchange-4.c: Same. --- gcc/testsuite/gcc.dg/graphite/interchange-7.c | 1 + gcc/testsuite/gcc.dg/graphite/run-id-1.c | 1 + gcc

[testsuite] Xfail ssa-dom-cse-2.c for nvptx

2018-01-08 Thread Tom de Vries
this scan test to fail for nvptx. Tested on nvptx and committed. Thanks, - Tom Xfail ssa-dom-cse-2.c for nvptx 2018-01-08 Tom de Vries * gcc.dg/tree-ssa/ssa-dom-cse-2.c: Xfail scan for nvptx. --- gcc/testsuite/gcc.dg/tree-ssa/ssa-dom-cse-2.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

2018-01-08 Thread Tom de Vries
On 12/18/2017 05:57 PM, Vladimir Makarov wrote: On 12/15/2017 06:25 AM, Tom de Vries wrote: Proposed Solution: The patch addresses the problem, by: - marking the hard regs that have been used in lra_spill in   hard_regs_spilled_into - using hard_regs_spilled_into in lra_create_live_ranges

[testsuite, commited] Fix error message in scan-hidden/scan-not-hidden

2018-05-29 Thread Tom de Vries
can-not-hidden. Committed as obvious. Thanks, - Tom [testsuite] Fix error message in scan-hidden/scan-not-hidden 2018-05-21 Tom de Vries * lib/scanasm.exp (scan-hidden, scan-not-hidden): Handle being called with no arguments. --- gcc/testsuite/lib/scanasm.exp | 16 ++

[testsuite, commited] Use correct proc names in scanasm.exp

2018-05-29 Thread Tom de Vries
an-ada-spec-not and scan-lto-assembler. Committed as obvious. Thanks, - Tom [testsuite] Use correct proc names in scanasm.exp 2018-05-21 Tom de Vries * lib/scanasm.exp (scan-stack-usage, scan-stack-usage-not) (scan-ada-spec, scan-ada-spec-not, scan-lto-assembler): U

[testsuite, commited] Fix "too few/many" error messages in scan-*-times procs

2018-05-29 Thread Tom de Vries
"too few/many" error messages in scan-*-times procs 2018-05-21 Tom de Vries * lib/scanasm.exp (scan-assembler-times): Use proc name in error message. * lib/scanipa.exp (scan-ipa-dump-times): Same. * lib/scanrtl.exp (scan-rtl-dump-times): Same.

[RFC] Add gcc.dg-selftests/dg-final.exp

2018-05-30 Thread Tom de Vries
bad idea? Any other comments? Ok for trunk? Thanks, - Tom Add gcc.dg-selftests/dg-final.exp 2018-05-30 Tom de Vries * gcc.dg-selftests/dg-final.exp: New file. --- gcc/testsuite/gcc.dg-selftests/dg-final.exp | 97 + 1 file changed, 97 insertions(+) d

[RFC] Add contrib/generate-from-maintainers.sh

2018-05-30 Thread Tom de Vries
.. alias Zdenek_Dvorak Zdenek Dvorak alias Ziga_Mahkovec Ziga Mahkovec ... Good or bad idea? Any other comments? OK for trunk? Thanks, - Tom Add contrib/generate-from-maintainers.sh 2018-05-30 Tom de Vries * generate-from-maintainers.sh: New file. --- contrib/generate-from-main

[MAINTAINERS, committed] Remove redundant write-after-approval entries

2018-06-04 Thread Tom de Vries
undant in write approval: Pierre-Marie de Rodat Redundant in write approval: Iain Sandoe Redundant in write approval: Marcus Shawcroft Redundant in write approval: Chung-Lin Tang Redundant in write approval: Caroline Tice Redundant in write approval: Tom de Vries Redundant in write approval: Chung-Ju

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-12 Thread Tom de Vries
On Mon, Jun 11, 2018 at 04:00:39PM -0600, Jeff Law wrote: > On 05/30/2018 04:41 AM, Tom de Vries wrote: > > Hi, > > > > this patch tests the error behaviour of dg-final directives when called > > with an > > incorrect number of arguments. > > > > T

[PATCH, contrib] Add contrib/maintainers-verify.sh

2018-06-12 Thread Tom de Vries
[ was: Re: [MAINTAINERS, committed] Remove redundant write-after-approval entries ] On Tue, Jun 12, 2018 at 10:26:31AM +0200, Martin Liška wrote: > Hi. > > Thanks for the script, it also found me in Write After Approval section. > Thus I'll install following patch. > > Tom what about installing

Re: [PATCH, contrib] Add contrib/maintainers-verify.sh

2018-06-12 Thread Tom de Vries
[ Fixed ENOPATCH ] On Tue, Jun 12, 2018 at 11:57:13AM +0200, Tom de Vries wrote: > [ was: Re: [MAINTAINERS, committed] Remove redundant write-after-approval > entries ] > > On Tue, Jun 12, 2018 at 10:26:31AM +0200, Martin Liška wrote: > > Hi. > > > > Thanks for t

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Tom de Vries
On 06/15/2018 05:05 PM, Andreas Schwab wrote: > On Jun 12 2018, Tom de Vries wrote: > >> I've made the PASS/FAIL id minimal (removed the actual args part), which >> makes >> it easier to read: >> ... >> PASS: scan-tree-dump: too many arguments &

Re: [RFC] Add gcc.dg-selftests/dg-final.exp

2018-06-15 Thread Tom de Vries
On 06/15/2018 05:33 PM, Andreas Schwab wrote: > On Jun 15 2018, Tom de Vries wrote: > >> Where do you see the duplication? > > The problem is actually that dg-final.exp is run multiple times, once > for every parallel execution of the testsuite. Ah, I see. Thanks for not

Re: [RFC] fixincludes: vxworks: add hack around ioLib.h/unistd.h mutual inclusion

2018-06-20 Thread Tom de Vries
Hi, for make check-fixincludes I'm seeing: ... cmp: EOF on /home/vries/gcc_versions/devel/src/fixincludes/tests/base/ioLib.h *** ioLib.h 2018-06-20 14:14:40.035956737 +0200 --- /home/vries/gcc_versions/devel/src/fixincludes/tests/base/ioLib.h 2018-06-20 14:14:28.183925247 +0200 ***

[PATCH, PR86097] Generate correctly typed compare in canonicalize_loop_ivs

2018-06-20 Thread Tom de Vries
Thanks, - Tom Generate correctly typed compare in canonicalize_loop_ivs 2018-06-20 Tom de Vries PR tree-optimization/86097 * tree-ssa-loop-manip.c (canonicalize_loop_ivs): Also convert *nit to iv type if signedness of iv type is not the same as that of *nit. * g

[PATCH, PR85859][tail-merge] Factor out gimple_may_have_side_effects_p and use in stmt_local_def

2018-06-20 Thread Tom de Vries
ks, - Tom [tail-merge] Factor out gimple_may_have_side_effects_p and use in stmt_local_def 2018-06-20 Tom de Vries PR tree-optimization/85859 * tree-ssa-ifcombine.c (gimple_may_have_side_effects_p): Factor out of ... (bb_no_side_effects_p): ... here.

Re: [patch] adjust default nvptx launch geometry for OpenACC offloaded regions

2018-06-20 Thread Tom de Vries
On 06/20/2018 11:59 PM, Cesar Philippidis wrote: > Now it follows the formula contained in > the "CUDA Occupancy Calculator" spreadsheet that's distributed with CUDA. Any reason we're not using the cuda runtime functions to get the occupancy (see PR85590 - [nvptx, libgomp, openacc] Use cuda runtim

[testsuite] Fix guality/pr45882.c for flto

2018-06-21 Thread Tom de Vries
, preventing array a from being marked as write-only. Tested on x86_64. OK for trunk? Thanks, - Tom [testsuite] Fix guality/pr45882.c for flto 2018-06-21 Tom de Vries * gcc.dg/guality/pr45882.c (a): Add used attribute. --- gcc/testsuite/gcc.dg/guality/pr45882.c | 2 +- 1 file change

[PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-22 Thread Tom de Vries
. OK for trunk? Thanks, - Tom [testsuite/guality] Be verbose about gdb version used 2018-06-22 Tom de Vries * lib/gcc-gdb-test.exp (report_gdb): New proc. * g++.dg/guality/guality.exp: Use report_gdb. * gcc.dg/guality/guality.exp: Same. * gfortran.dg/gu

[PATCH][testsuite/guality] Use buildarea gdb by default in combined build

2018-06-22 Thread Tom de Vries
combined build 2018-06-22 Tom de Vries * g++.dg/guality/guality.exp (guality_gdb_name): Default to $rootme/../gdb/gdb, if available. * gcc.dg/guality/guality.exp (guality_gdb_name): Same. * gfortran.dg/guality/guality.exp (guality_gdb_name): Same. --- gcc

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-23 Thread Tom de Vries
On 06/23/2018 07:05 PM, Christophe Lyon wrote: > Hello, > > On Fri, 22 Jun 2018 at 18:01, Jeff Law wrote: >> >> On 06/22/2018 05:35 AM, Tom de Vries wrote: >>> Hi, >>> >>> by default, guality invokes gdb with --quiet to avoid being unnecessarily

[PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-24 Thread Tom de Vries
c_64_ 2018-06-22 Tom de Vries PR debug/86257 * config/i386/i386.md (define_insn "*tls_global_dynamic_64_"): Use data16 instead of .byte for insn prefix. * gcc.dg/pr86257.c: New test. --- gcc/config/i386/i386.md| 13 - gcc/testsuite

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
gt; > Patch is OK (and probably should be backported after some soaking in mainline) > Committed (after moving the testcase to gcc.target/i386). Thanks, - Tom > Honza >> >> This patch fixes the problem by using data16 to generate the prefix. >> >> Bootstrapped

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/24/2018 11:59 PM, Jan Hubicka wrote: > Hi, > searching for other occurences I see: > jan@skylake:~/trunk/gcc/config/i386> grep ASM_BYTE *md *.c > i386.md:return ASM_BYTE "0x9e"; > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); > i386.md:fputs (ASM_BYTE "0x66\n", asm_out_file); >

Re: [PATCH, PR86257, i386/debug] Fix insn prefix in tls_global_dynamic_64_

2018-06-25 Thread Tom de Vries
On 06/25/2018 02:45 PM, Nathan Sidwell wrote: > On 06/25/2018 08:25 AM, Tom de Vries wrote: > >> If we'd implemented something like this in gas: >> ... >> .insn >> .byte 0x66 >> .endinsn >> ... >> we could fix this more generically. > >

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Tom de Vries
On 06/25/2018 02:32 PM, Andreas Schwab wrote: > I'm still getting this error: > > Running /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp > ... > gdb used in > /usr/local/gcc/gcc-20180625/gcc/testsuite/gcc.dg/guality/guality.exp: > /usr/bin/gdb > ERROR: tcl error sourcing

Re: [PATCH][testsuite/guality] Be verbose about gdb version used

2018-06-25 Thread Tom de Vries
On 06/25/2018 04:36 PM, Andreas Schwab wrote: > On Jun 25 2018, Tom de Vries wrote: > >> @@ -151,6 +151,9 @@ proc report_gdb { gdb loc } { >> } >> set gdb [exec which $gdb] >> send_log "gdb used in $loc: $gdb\n" >> -set gdb_ve

[PATCH, testsuite/guality] Use line number vars in gdb-test

2018-06-28 Thread Tom de Vries
relative line numbers, and one with line number variables to make sure I didn't break process-message. OK for trunk if bootstrap and reg-test succeeds? Thanks, - Tom [testsuite/guality] Use line number vars in gdb-test 2018-06-28 Tom de Vries * gcc.dg/guality/pr45882.c (foo): Ad

Re: [PATCH, testsuite/guality] Use line number vars in gdb-test

2018-06-28 Thread Tom de Vries
[ resending. It seems this did not get through to the mail archive. ] On Thu, Jun 28, 2018 at 07:49:30PM +0200, Tom de Vries wrote: > Hi, > > I played around with pr45882.c and ran into FAILs. It took me a while to > realize that the FAILs where due to the gdb-test (a dg-final a

[RFC, testsuite/guality] Use relative line numbers in gdb-test

2018-06-28 Thread Tom de Vries
[ was: [PATCH, testsuite/guality] Use line number vars in gdb-test ] On Thu, Jun 28, 2018 at 07:49:30PM +0200, Tom de Vries wrote: > Hi, > > I played around with pr45882.c and ran into FAILs. It took me a while to > realize that the FAILs where due to the gdb-test (a dg-final a

[testsuite/guality] Don't use attribute used in pr45882.c for -O0

2018-06-28 Thread Tom de Vries
[ was: Re: [testsuite] Fix guality/pr45882.c for flto ] On Thu, Jun 21, 2018 at 02:52:31PM +0200, Richard Biener wrote: > On Thu, 21 Jun 2018, Tom de Vries wrote: > > > Hi, > > > > Atm this test in pr45882.c: > > ... > > int d = a[i];

[testsuite, committed] Fix get-absolute-line error handling

2018-07-01 Thread Tom de Vries
mally doesn't happen, so I've added a test in gcc.dg-selftests for that. Committed as obvious. Thanks, - Tom [testsuite] Fix get-absolute-line error handling 2018-07-01 Tom de Vries * gcc.dg-selftests/dg-final.exp (verify_call_1): Factor out of ... (verify_call): ...

[testsuite/guality, committed] Use relative line numbers in vla-1.c

2018-07-01 Thread Tom de Vries
relative line number '.'. This was not supported in get-absolute-line, so this patch adds support for that as well. Committed as obvious. Thanks, - Tom [testsuite/guality] Use relative line numbers in vla-1.c 2018-07-01 Tom de Vries * lib/gcc-dg.exp (get-absolute-line): Handle '

[testsuite/guality, committed] Prevent optimization of local in vla-1.c

2018-07-01 Thread Tom de Vries
y, and fixes the non-lto failures. Committed as obvious. Thanks, - Tom [testsuite/guality] Prevent optimization of local in vla-1.c 2018-07-01 Tom de Vries * gcc.dg/guality/prevent-optimization.h (VOLATILE): Define. * gcc.dg/guality/vla-1.c (f1): Mark local vla a as VOLATILE.

Re: [testsuite/guality, committed] Prevent optimization of local in vla-1.c

2018-07-01 Thread Tom de Vries
On 07/01/2018 09:11 PM, Jakub Jelinek wrote: > On Sun, Jul 01, 2018 at 06:19:20PM +0200, Tom de Vries wrote: >> So, the local vla a is optimized away. >> >> This patch adds VOLATILE to 'a', which prevents it from being optimized away, >> and fixes the non-lto

[testsuite/guality, committed] Use @main as bp loc instead of line nrs in const-volatile.c

2018-07-01 Thread Tom de Vries
, and can just use '@main'. Committed as obvious. Thanks, - Tom [testsuite/guality] Use @main as bp loc instead of line nrs in const-volatile.c 2018-07-01 Tom de Vries * lib/gcc-gdb-test.exp (gdb-test): Handle '@' prefix in line number argument. *

Re: [nvptx, committed] Disable -gstatement-frontiers for nvptx

2018-01-11 Thread Tom de Vries
On 12/31/2017 09:04 PM, Alexandre Oliva wrote: On Dec 29, 2017, Tom de Vries wrote: On 12/29/2017 05:12 AM, Alexandre Oliva wrote: On Dec 27, 2017, Tom de Vries wrote: .loc file_index line_number column_position so this causes ptxas errors when compiling something for nvptx with -g

Re: [PATCH] Add VEC_ORDERED_REMOVE_IF

2018-01-11 Thread Tom de Vries
On 01/10/2018 07:03 PM, Bernhard Reutner-Fischer wrote: On 5 January 2018 22:06:10 CET, Tom de Vries wrote: [ was: Re: [RFC] Add vec::ordered_remove_if ] Tom, s/an an/an/g Fixed. Also: - added '()' around more macro args in VEC_ORDERED_REMOVE_IF - added PR number ( https://g

[testsuite] Add dg-require-effective-target alloca for c++ test-cases

2018-01-12 Thread Tom de Vries
Hi, this patch adds dg-require-effective-target alloca for c++ test-cases. Build and reg-tested on x86_64 and nvptx. Committed as obvious. Thanks, - Tom Add dg-require-effective-target alloca for c++ test-cases 2018-01-12 Tom de Vries * c-c++-common/dwarf2/vla1.c: Add dg-require

[testsuite] Add dg-require-effective-target indirect_jumps for g++

2018-01-12 Thread Tom de Vries
Hi, this patch adds dg-require-effective-target indirect_jumps for g++ test-cases. Build and reg-tested on x86_64 and nvptx. Committed as obvious. Thanks, - Tom Add dg-require-effective-target indirect_jumps for g++ 2018-01-12 Tom de Vries * g++.dg/ext/label13.C: Add dg-require

[committed, PR83737] Set use_gcc_stdint=wrap for nvptx

2018-01-12 Thread Tom de Vries
sted libgomp. Committed. Thanks, - Tom Set use_gcc_stdint=wrap for nvptx 2018-01-12 Tom de Vries PR target/83737 * config.gcc (nvptx*-*-*): Set use_gcc_stdint=wrap. --- gcc/config.gcc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/config.gcc b/gcc/config.gcc index 4ef52ce..122d44e 100

Re: [PATCH] Add new verification for profile-count.h.

2018-01-14 Thread Tom de Vries
On 01/12/2018 09:44 AM, Jan Hubicka wrote: Hi. Following patch adds new sanitization checks for profile_quality. Problem is that zero initialization of a struct with profile_count will lead to an invalid counter. This can help to catch them. Patch can bootstrap on ppc64le-redhat-linux and survi

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-15 Thread Tom de Vries
On 01/07/2018 02:17 PM, Tom de Vries wrote: On 01/06/2018 12:36 PM, Jakub Jelinek wrote: On Sat, Jan 06, 2018 at 09:21:59AM +0100, Tom de Vries wrote: this patch adds the following builtins in C/C++: - __builtin_goacc_gang_id - __builtin_goacc_worker_id - __builtin_goacc_vector_id

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-15 Thread Tom de Vries
On 01/15/2018 11:05 AM, Jakub Jelinek wrote: On Mon, Jan 15, 2018 at 10:49:52AM +0100, Tom de Vries wrote: On 01/07/2018 02:17 PM, Tom de Vries wrote: On 01/06/2018 12:36 PM, Jakub Jelinek wrote: On Sat, Jan 06, 2018 at 09:21:59AM +0100, Tom de Vries wrote: this patch adds the following

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-15 Thread Tom de Vries
On 01/15/2018 11:44 AM, Jakub Jelinek wrote: On Mon, Jan 15, 2018 at 11:39:28AM +0100, Tom de Vries wrote: Does OpenACC have some term for the 3 dimensions/kinds of parallelism? openacc spec: "OpenACC exposes these three levels of parallelism via gang, worker and vector parallelism.

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-17 Thread Tom de Vries
On 01/15/2018 12:25 PM, Jakub Jelinek wrote: On Mon, Jan 15, 2018 at 12:12:10PM +0100, Tom de Vries wrote: It can be just number of course. parlevel is fine for me. So, in summary, I propose as interface: - int __builtin_goacc_parlevel_id (int); - int __builtin_goacc_parlevel_size (int

Re: [PATCH,PTX] Add support for CUDA 9

2018-01-17 Thread Tom de Vries
On 01/17/2018 06:29 PM, Cesar Philippidis wrote: Is this patch OK for trunk? You haven't made the changes I've asked for, this is the same patch as before. Thanks, - Tom

Re: [PATCH, PR82428] Add __builtin_goacc_{gang,worker,vector}_{id,size}

2018-01-18 Thread Tom de Vries
On 01/17/2018 06:51 PM, Jakub Jelinek wrote: On Wed, Jan 17, 2018 at 06:42:33PM +0100, Tom de Vries wrote: +static rtx +expand_builtin_goacc_parlevel_id_size (tree exp, rtx target, int ignore) +{ + tree fndecl = get_callee_fndecl (exp); + + const char *name; + switch (DECL_FUNCTION_CODE

Re: [PATCH,NVPTX] Fix PR83920

2018-01-18 Thread Tom de Vries
On 01/18/2018 12:40 AM, Cesar Philippidis wrote: In PR83920, I encountered a nvptx bug where live predicate variables were clobbered before their value was broadcasted. Hi, I've managed to reproduce the problem based on the description in the PR. Apparently, there were problems in certain v

Re: [PATCH] Fix profile_quality sanity check.

2018-01-18 Thread Tom de Vries
On 01/18/2018 03:59 PM, Martin Liška wrote: Hi. Following patch adds a new enum value so that we don't see following warning: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01211.html Hi, with the patch, I still see the same warning. And not surprisingly, given that profile_precise is still

Re: [PATCH,PTX] Add support for CUDA 9

2018-01-19 Thread Tom de Vries
On 01/19/2018 01:59 AM, Cesar Philippidis wrote: Here's the updated patch with the changes that you requested. There are no new regressions in trunk. I tested it on my desktop running driver 387.34 on a Pascal GPU. Is this OK for trunk? OK with 'PR target/83790' added to the changelog entry.

Re: [PATCH] Fix profile_quality sanity check.

2018-01-19 Thread Tom de Vries
On 01/19/2018 01:11 PM, Martin Liška wrote: On 01/18/2018 04:57 PM, Tom de Vries wrote: On 01/18/2018 03:59 PM, Martin Liška wrote: Hi. Following patch adds a new enum value so that we don't see following warning: https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01211.html Hi, with the

Re: [PATCH,NVPTX] Fix PR83920

2018-01-19 Thread Tom de Vries
On 01/18/2018 02:27 PM, Tom de Vries wrote: On 01/18/2018 12:40 AM, Cesar Philippidis wrote: In PR83920, I encountered a nvptx bug where live predicate variables were clobbered before their value was broadcasted. Hi, I've managed to reproduce the problem based on the description in t

Re: [PATCH] Fix profile_quality sanity check.

2018-01-19 Thread Tom de Vries
On 01/19/2018 04:08 PM, Martin Liška wrote: On 01/19/2018 02:21 PM, Tom de Vries wrote: How about keeping profile_uninitialized at the zero value location and asserting m_quality != profile_uninitialized ? Thanks, - Tom Yes, that would be possible. Can you please test that the patch does

[PATCH, 1/2][nvptx, libgomp] Add GOMP_NVPTX_JIT=-O[0-4] in nvptx libgomp plugin

2018-01-24 Thread Tom de Vries
-O[0-4] in nvptx libgomp plugin 2018-01-24 Tom de Vries * plugin/cuda/cuda.h (CUjit_option): Add CU_JIT_OPTIMIZATION_LEVEL. * plugin/plugin-nvptx.c (_GNU_SOURCE): Define. (process_GOMP_NVPTX_JIT): New function. (link_ptx): Use process_GOMP_NVPTX_JIT. --- libgomp/plugin/cuda/cuda.h|

[PATCH, 2/2][nvptx, PR83589] Workaround for branch-around-nothing JIT bug

2018-01-24 Thread Tom de Vries
th nvptx accelerator. I'd like to commit in stage4, but I'd appreciate a review of the code. Does the patch look OK? Thanks, - Tom [nvptx, PR83589] Workaround for branch-around-nothing JIT bug 2018-01-23 Tom de Vries PR target/83589 * config/nvptx/nvptx.c (WORKAROUND_PTXJIT_BUG_2):

[nvptx, PR81352] Add exit insn after noreturn call for neutered threads in warp

2018-01-24 Thread Tom de Vries
x, PR81352] Add exit insn after noreturn call for neutered threads in warp 2018-01-23 Tom de Vries PR target/81352 * config/nvptx/nvptx.c (nvptx_single): Add exit insn after noreturn call for neutered threads in warp. * config/nvptx/nvptx.md (define_insn "exit"): New insn.

Re: [nvptx, PR81352] Add exit insn after noreturn call for neutered threads in warp

2018-01-24 Thread Tom de Vries
On 01/24/2018 12:53 PM, Richard Biener wrote: On Wed, 24 Jan 2018, Tom de Vries wrote: I'll commit this shortly for stage4. Strictly speaking, this is not an 8 regression, but a wrong code bug. But I think that the code generation error seems fundamental enough, and the fix simple and loca

Re: [PATCH, 2/2][nvptx, PR83589] Workaround for branch-around-nothing JIT bug

2018-01-24 Thread Tom de Vries
On 01/24/2018 12:03 PM, Jakub Jelinek wrote: On Wed, Jan 24, 2018 at 11:41:45AM +0100, Tom de Vries wrote: +/* Insert a dummy ptx insn when encountering a branch to a label with no ptx + insn inbetween the branch and the label. This works around a JIT bug + observed at driver version

Re: [PATCH, 2/2][nvptx, PR83589] Workaround for branch-around-nothing JIT bug

2018-01-24 Thread Tom de Vries
On 01/24/2018 03:07 PM, Jakub Jelinek wrote: On Wed, Jan 24, 2018 at 02:56:28PM +0100, Tom de Vries wrote: +#if WORKAROUND_PTXJIT_BUG_2 +/* Variant of pc_set that only requires JUMP_P (INSN) if STRICT. This variant + is needed in the nvptx target because the branches generated for

[nvptx, PR84028] Add exit insn after noreturn call for neutered workers

2018-01-25 Thread Tom de Vries
id for the vector neutering join (which we can see here after $L28). Build and reg-tested on x86_64 with nvptx accelerator. Committed in stage4 as non-intrusive wrong-code fix. Thanks, - Tom [nvptx, PR84028] Add exit insn after noreturn call for neutered workers 2018-01-25 Tom de Vries PR ta

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-29 Thread Tom de Vries
Hi, this ( r257065 ) caused: PR84088 - "[nvptx] libgomp.oacc-fortran/declare-*.f90 execution fails" ( https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84088 ). Thanks, - Tom On 01/24/2018 10:05 AM, Paul Richard Thomas wrote: Hi Jakub, The lateness is indeed embarrassing but couldn't be helped.

Re: [PATCH, combine]: Fix PR84123: internal compiler error: in gen_rtx_SUBREG, at emit-rtl.c

2018-01-31 Thread Tom de Vries
On 01/31/2018 10:33 PM, Segher Boessenkool wrote: Hi! On Wed, Jan 31, 2018 at 08:47:08PM +0100, Uros Bizjak wrote: We should skip RTXes that will result in certain ICE here, and this is what the attached patch does. 2018-01-31 Uros Bizjak PR target/84123 * combine.c (change_zero_

Re: [Patch, fortran] PR84088 - [8 Regression][nvptx] libgomp.oacc-fortran/declare-*.f90 execution fails

2018-01-31 Thread Tom de Vries
On 01/31/2018 09:34 PM, Paul Richard Thomas wrote: This fixes the reduced testcase provided by Tom de Vries in comment #7 of the PR. Committed as 'obvious' as r257262. Will await a report from Tom as to whether or not this fixes the original problem Hi Paul, it does. I've

Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions

2018-02-06 Thread Tom de Vries
On 12/21/2017 10:46 PM, Cesar Philippidis wrote: I've committed this patch to openacc-gcc-7-branch. diff --git a/gcc/omp-expand.c b/gcc/omp-expand.c index bf1f127d8d6..f674c74ec82 100644 --- a/gcc/omp-expand.c +++ b/gcc/omp-expand.c offloaded = is_gimple_omp_offloaded (entry_stmt);

[og7, committed] Fix implicit fallthrough warning in expand_omp_target

2018-02-06 Thread Tom de Vries
[ was: Re: [PATCH,WIP] Use functional parameters for data mappings in OpenACC child functions ] On 02/06/2018 12:46 PM, Tom de Vries wrote: On 12/21/2017 10:46 PM, Cesar Philippidis wrote: I've committed this patch to openacc-gcc-7-branch. diff --git a/gcc/omp-expand.c b/gcc/omp-exp

[openacc, committed] Fix diff_type in expand_oacc_collapse_init

2018-02-07 Thread Tom de Vries
to apply the r250925 fix (in expand_oacc_for) to expand_oacc_collapse_init as well. Build and reg-tested on x86_64 with nvptx accelerator. Committed to stage4 trunk. Thanks, - Tom [openacc] Fix diff_type in expand_oacc_collapse_init 2018-02-07 Tom de Vries PR libgomp/84217 * omp

[testsuite, committed] Require global_constructor in gcc.dg/torture/pr83055.c

2018-02-07 Thread Tom de Vries
Hi, this patch requires effective target global_constructor in gcc.dg/torture/pr83055.c. Committed. Thanks, - Tom [testsuite] Require global_constructor in gcc.dg/torture/pr83055.c 2018-02-07 Tom de Vries * gcc.dg/torture/pr83055.c: Require effective target global_constructor

[testsuite, committed] Require alloca in gcc.dg/pr83844.c

2018-02-07 Thread Tom de Vries
Hi, this patch requires effective target alloca in gcc.dg/pr83844.c. Committed. Thanks, - Tom [testsuite] Require alloca in gcc.dg/pr83844.c 2018-02-07 Tom de Vries * gcc.dg/pr83844.c: Require effective target alloca. --- gcc/testsuite/gcc.dg/pr83844.c | 1 + 1 file changed, 1

Re: [openacc, committed] Fix diff_type in expand_oacc_collapse_init

2018-02-07 Thread Tom de Vries
On 02/07/2018 08:37 PM, Rainer Orth wrote: Hi Tom, this patch fixes an 8 regression in an openacc testcase. The regression was introduced by r250925, a fix for PR78266, a bug in the handling of a loop with iteration variable type range smaller than the size of the parallel dimension the loop i

[testsuite, committed] Require et indirect_jumps for pr84136.c

2018-02-15 Thread Tom de Vries
Hi, this patch requires effective target indirect_jumps for test-case pr84136.c. Committed. Thanks, - Tom [testsuite] Require et indirect_jumps for pr84136.c 2018-02-15 Tom de Vries * gcc.c-torture/compile/pr84136.c: Require effective target indirect_jumps. --- gcc/testsuite/gcc.c

[testsuite, committed] Require et alloca for Wstringop-overflow-3.c

2018-02-15 Thread Tom de Vries
Hi, this patch requires effective target alloca for test-case Wstringop-overflow-3.c. Committed. Thanks, - Tom [testsuite] Require et alloca for Wstringop-overflow-3.c 2018-02-15 Tom de Vries * gcc.dg/Wstringop-overflow-3.c: Require effective target alloca. --- gcc/testsuite/gcc.dg

Re: [testsuite, committed] Require et alloca for Wstringop-overflow-3.c

2018-02-16 Thread Tom de Vries
It also could be done without modifying the compiler by dumping a tree file and grepping, but it sounds more fragile to me. Maybe for alloca the grepping method would work, but for other rarely-false effective targets it could be harder. Thanks, - Tom Martin On 02/15/2018 07:10 AM, Tom de Vr

Re: [PATCH][committed] Fix ICE in maybe_record_trace_start

2018-02-22 Thread Tom de Vries
On 02/12/2018 07:32 PM, Jeff Law wrote: diff --git a/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c new file mode 100644 index 000..0ca0b9f034b --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c @@ -0,0 +1,36

[testsuite] Require et alloca for pr82210.c

2018-02-22 Thread Tom de Vries
Hi, this patch requires effective target alloca in testcase pr82210.c. Committed. Thanks, - Tom [testsuite] Require et alloca for pr82210.c 2018-02-22 Tom de Vries * gcc.c-torture/execute/pr82210.c: Require effective target alloca. --- gcc/testsuite/gcc.c-torture/execute/pr82210.c | 1

[og7] Fix hang when running oacc exec with CUDA 9.0 nvprof

2018-02-22 Thread Tom de Vries
mp library, and returning acc_device_none, which is a legal value given that the openacc standard states "If the device type has not yet been selected, the value acc_device_none may be returned". Committed to og7 branch. Thanks, - Tom Fix hang when running oacc exec with CUDA 9.0 nvprof

[parloops, PR83126], Use cached affine_ivs canonicalize_loop_ivs

2018-02-22 Thread Tom de Vries
that aborts the optimization instead of ICE-ing. Thanks, - Tom [parloops] Use cached affine_ivs canonicalize_loop_ivs 2018-02-22 Tom de Vries PR tree-optimization/83126 * tree-ssa-loop-manip.c (rewrite_phi_with_iv): Add and handle piv parameter. (rewrite_all_phi_nodes_with_iv, canonical

Re: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

2018-02-26 Thread Tom de Vries
On 01/08/2018 05:32 PM, Tom de Vries wrote: On 12/18/2017 05:57 PM, Vladimir Makarov wrote: On 12/15/2017 06:25 AM, Tom de Vries wrote: Proposed Solution: The patch addresses the problem, by: - marking the hard regs that have been used in lra_spill in   hard_regs_spilled_into - using

Re: [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs

2018-02-26 Thread Tom de Vries
On 02/26/2018 12:00 PM, Matthew Fortune wrote: Tom de Vries writes: On 01/08/2018 05:32 PM, Tom de Vries wrote: On 12/18/2017 05:57 PM, Vladimir Makarov wrote: On 12/15/2017 06:25 AM, Tom de Vries wrote: Proposed Solution: The patch addresses the problem, by: - marking the hard regs

Re: [PATCH][committed] Fix ICE in maybe_record_trace_start

2018-02-26 Thread Tom de Vries
On 02/23/2018 04:59 PM, Jeff Law wrote: On 02/22/2018 03:59 AM, Tom de Vries wrote: On 02/12/2018 07:32 PM, Jeff Law wrote: diff --git a/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c b/gcc/testsuite/gcc.c-torture/compile/regs-arg-size.c new file mode 100644 index 000..0ca0b9f034b

[PATCH] Fix ICE for static vars in offloaded functions

2018-03-07 Thread Tom de Vries
ld and reg-tested libgomp on x86_64 with nvptx accelerator. Bootstrapped and reg-tested on x86_64. OK for stage4 trunk? Thanks, - Tom Fix ICE for static vars in offloaded functions 2018-03-06 Tom de Vries PR lto/84592 * varpool.c (varpool_node::get_create): Mark static variables in off

Re: [PATCH] Fix ICE for static vars in offloaded functions

2018-03-07 Thread Tom de Vries
On 03/07/2018 02:29 PM, Richard Biener wrote: On Wed, 7 Mar 2018, Jakub Jelinek wrote: On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: Fix ICE for static vars in offloaded functions 2018-03-06 Tom de Vries PR lto/84592 * varpool.c (varpool_node::get_create

Re: [og7] Update nvptx_fork/join barrier placement

2018-03-09 Thread Tom de Vries
On 03/09/2018 12:31 AM, Cesar Philippidis wrote: Nvidia Volta GPUs now support warp-level synchronization. Well, let's try to make that statement a bit more precise. All Nvidia architectures have supported synchronization of threads in a warp on a very basic level: by means of convergence (an

Re: [PATCH] Fix PR84512

2018-03-16 Thread Tom de Vries
dump "return 285;" "optimized" } } */ This fails for nvptx, because it doesn't have the required vector operations. To fix the fail, I've added requiring effective target vect_int_mult. Thanks, - Tom [testsuite] Require vect_int_mult in pr84512.c 2018-03-16 Tom de

[testsuite] Require label_values in builtin-unreachable-6.c

2018-03-16 Thread Tom de Vries
tree-vrp" } */ void foo (int b, int c) Preventing vrp triggered "sorry, unimplemented: target cannot support label values" on nvptx. Fixed by requiring the effective target label_values. Thanks, - Tom [testsuite] Require label_values in builtin-unreachable-6.c 2018-

Re: [PATCH] Fix PR84512

2018-03-16 Thread Tom de Vries
On 03/16/2018 12:55 PM, Richard Biener wrote: On Fri, 16 Mar 2018, Tom de Vries wrote: On 02/27/2018 01:42 PM, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/tree-ssa/pr84512.c === --- gcc/testsuite/gcc.dg/tree-ssa/pr84512.c

Re: [og7] Update nvptx_fork/join barrier placement

2018-03-19 Thread Tom de Vries
On 03/09/2018 05:55 PM, Cesar Philippidis wrote: On 03/09/2018 08:21 AM, Tom de Vries wrote: On 03/09/2018 12:31 AM, Cesar Philippidis wrote: Nvidia Volta GPUs now support warp-level synchronization. Well, let's try to make that statement a bit more precise. All Nvidia architectures

Re: [og7] Update nvptx_fork/join barrier placement

2018-03-19 Thread Tom de Vries
On 03/19/2018 03:55 PM, Cesar Philippidis wrote: Is your patch purely for debugging, or are you planning on committing it to og7 and trunk? I plan to commit it. We have no test-cases testing the neutering code order explicitly. So this check is the only thing that allows us to detect regressi

Re: [og7] Update nvptx_fork/join barrier placement

2018-03-19 Thread Tom de Vries
On 03/19/2018 03:55 PM, Cesar Philippidis wrote: Note that this changes ordering of the vector-neutering jump and worker-neutering jump at the end. In principle, this should not be harmful, but it violates the invariant that vector-neutering branch-around code should be as short-lived as possible

[nvptx, PR84954, committed] Fix prevent_branch_around_nothing

2018-03-20 Thread Tom de Vries
[ was: Re: [PATCH, 2/2][nvptx, PR83589] Workaround for branch-around-nothing JIT bug ] On 01/24/2018 11:41 AM, Tom de Vries wrote: Hi, this patch adds a workaround for the nvptx target JIT bug PR83589 - "[nvptx] mode-transitions.c and private-variables.{c,f90} execution FAI

[nvptx, PR84952, committed] Fix bar.sync position

2018-03-20 Thread Tom de Vries
[ was: Re: [og7] Update nvptx_fork/join barrier placement ] On 03/19/2018 06:02 PM, Tom de Vries wrote: I've got a tentative patch at https://gcc.gnu.org/bugzilla/attachment.cgi?id=43707 ( PR84952 - "[nvptx] bar.sync generated in divergent code" ). Tested on x86_64 with nvptx

Re: [Patch] Document __builtin_extend_pointer

2018-03-20 Thread Tom de Vries
On 02/20/2018 06:33 PM, Steve Ellcey wrote: +@deftypefn {Built-in Function} Pmode __builtin_extend_pointer (void * x) +On targets where the user visible pointer size is different than the size +of an actual hardware address this function returns the extended user +pointer.  Targets where this is

Re: [PATCH] Fix PR84512

2018-03-20 Thread Tom de Vries
On 03/19/2018 10:11 AM, Richard Biener wrote: On Fri, 16 Mar 2018, Tom de Vries wrote: On 03/16/2018 12:55 PM, Richard Biener wrote: On Fri, 16 Mar 2018, Tom de Vries wrote: On 02/27/2018 01:42 PM, Richard Biener wrote: Index: gcc/testsuite/gcc.dg/tree-ssa/pr84512.c

Re: [parloops, PR83126], Use cached affine_ivs canonicalize_loop_ivs

2018-03-21 Thread Tom de Vries
On 03/12/2018 01:14 PM, Richard Biener wrote: On Thu, 22 Feb 2018, Tom de Vries wrote: I can rework the bit of the patch that adds an assert after canonicalize_loop_ivs into a patch that aborts the optimization instead of ICE-ing. I think that's something reasonable anyway. Patch att

Re: [parloops, PR83126], Use cached affine_ivs canonicalize_loop_ivs

2018-03-21 Thread Tom de Vries
On 03/12/2018 01:14 PM, Richard Biener wrote: On Thu, 22 Feb 2018, Tom de Vries wrote: Hi, this patch fixes an ICE in the parloops pass. The ICE (when compiling the test-case in attached patch) follows from the fact that here in gen_parallel_loop the call to canonicalize_loop_ivs fails to

Re: [og7] vector_length extension part 4: target hooks and automatic parallelism

2018-03-21 Thread Tom de Vries
On 03/02/2018 08:18 PM, Cesar Philippidis wrote: og7-vl-part4-hooks.diff diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c index 5642941c6a3..507c8671704 100644 --- a/gcc/config/nvptx/nvptx.c +++ b/gcc/config/nvptx/nvptx.c @@ -5205,14 +5205,36 @@ nvptx_simt_vf () return PTX

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

2018-03-21 Thread Tom de Vries
On 03/02/2018 05:55 PM, Cesar Philippidis wrote: In addition, nvptx_cta_sync and the corresponding nvptx_barsync insn, have been extended to take a barrier ID and a thread count. The idea here is to assign one barrier for each logical vector. Worker-single synchronization is controlled by barrier

[tail-merge, PR84956] Don't merge bbs with bb_has_abnormal_pred

2018-03-22 Thread Tom de Vries
h? Thanks, - Tom [tail-merge] Don't merge bbs with bb_has_abnormal_pred 2018-03-21 Tom de Vries PR tree-optimization/84956 * tree-ssa-tail-merge.c (find_clusters_1): Skip bbs with bb_has_abnormal_pred. * gcc.dg/pr84956.c: New test. --- gcc/testsuite/gcc.dg/pr84956.c | 27

Re: [og7] vector_length extension part 2: Generalize state propagation and synchronization

2018-03-22 Thread Tom de Vries
On 03/22/2018 04:59 AM, Cesar Philippidis wrote: On 03/21/2018 10:10 AM, Tom de Vries wrote: On 03/02/2018 05:55 PM, Cesar Philippidis wrote: In addition, nvptx_cta_sync and the corresponding nvptx_barsync insn, have been extended to take a barrier ID and a thread count. The idea here is to

<    4   5   6   7   8   9   10   11   12   13   >