Re: Buildbot failure in Wildebeest Builder on whole buildset

2022-02-23 Thread Mark Wielaard
Hi, On Wed, Feb 23, 2022 at 12:26:26PM +0100, Mark Wielaard wrote: > So there were 3 issues: > > - The debian-i386 build had pre-existing failures that weren't > reported before. > - The recent commits introduced some tests which failed, and then > some code changes that fixed those tests so

Re: qual_union_type help

2022-02-23 Thread Eric Botcazou via Gcc-rust
> That makes sense during construction we also know what the value of > the discriminant is. What does the Ada front-end replace the > placeholder_exprs with? Can it simply be the value of the discriminant > at constructor? I haven't tried that. Ultimately all PLACEHOLDER_EXPRs need to be

Re: qual_union_type help

2022-02-23 Thread Philip Herron
Hi Eric, That makes sense during construction we also know what the value of the discriminant is. What does the Ada front-end replace the placeholder_exprs with? Can it simply be the value of the discriminant at constructor? I haven't tried that. Thanks --Phil On Wed, 23 Feb 2022 at 17:33,

Re: qual_union_type help

2022-02-23 Thread Eric Botcazou via Gcc-rust
> This makes sense this we can't gimplify a placeholder expression. So > this seems that when i make a constructor for the QUAL_UNION_TYPE i > must iterate the fields and replace the placeholder_expr to have a > reference to the discriminant via another COMPONENT_REF. Though does > this mean for

qual_union_type help

2022-02-23 Thread Philip Herron
Hi everyone I am seeking some help on using the QUAL_UNION_TYPE it seems ideally placed to be used for enums in Rust. My initial implementation was achieved by simply using a union such as: union my_enum { variant_a { enum discriminant; ...data } ; variant_b { enum discriminant; ...data} ; }

Re: make check-rust doesn't fail, but now the buildbot does

2022-02-23 Thread Philip Herron
Thanks for doing this I've been investigating the issue with the 2 match expressions I think it's down to the layout of the enum type not being correct. Not quite sure what the fix will be yet. Overall it's just great to have this level of feedback automatically on multiple machines. --Phil On

Buildbot failure in Wildebeest Builder on whole buildset

2022-02-23 Thread buildbot
The Buildbot has detected a new failure on builder gccrust-fedora-x86_64 while building gccrust. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/59/builds/1598 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: fedora-x86_64 Build

Re: Buildbot failure in Wildebeest Builder on whole buildset

2022-02-23 Thread Mark Wielaard
Hi, On Wed, 2022-02-23 at 11:35 +0100, Mark Wielaard wrote: > So, this works as expected. Note that it reports issues not just for > debian-i386, but also for some other arches (all debian based). The > i386 issues are not new. But the others do seem to be caused by the > latest commit. I haven't

Re: Buildbot failure in Wildebeest Builder on whole buildset

2022-02-23 Thread Mark Wielaard
Hi, So, this works as expected. Note that it reports issues not just for debian-i386, but also for some other arches (all debian based). The i386 issues are not new. But the others do seem to be caused by the latest commit. I haven't investigated why yet though. The buildbot links also point to

Buildbot failure in Wildebeest Builder on whole buildset

2022-02-23 Thread buildbot
The Buildbot has detected a new failure on builder gccrust-debian-arm64 while building gccrust. Full details are available at: https://builder.wildebeest.org/buildbot/#builders/58/builds/1681 Buildbot URL: https://builder.wildebeest.org/buildbot/ Worker for this Build: debian-arm64 Build