[COMMITTED] gcc-mingw don't enable rust

gccrs now requires cargo to build --- builder/master.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/master.cfg b/builder/master.cfg index c75b1622331f..97bf3703c019 100644 --- a/builder/master.cfg +++ b/builder/master.cfg @@ -3511,7 +3511,7 @@

Sourceware 2024 - The Plan

The Sourceware Project Leadership Committee in discussion with the Software Freedom Conservancy staff came up with the Sourceware 2024 plan and is looking at longer term projects that would be needed to keep your infrastructure running smoothly and securely for the next couple of years. We are

Re: ☠ Buildbot (Sourceware): gccrust - failed compile (failure) (master)

Hi, On Fri, Mar 01, 2024 at 11:24:00AM +0100, Arthur Cohen wrote: > On 2/29/24 21:22, Mark Wielaard wrote: > >I think what needs to happen is have a config check for the minimum > >versions of cargo and rustc that are now needed for when configuring > >for --enable-lan

Re: ☠ Buildbot (Sourceware): gccrust - failed compile (failure) (master)

Hi, On Thu, Feb 29, 2024 at 09:00:13PM +0100, Thomas Schwinge wrote: > Three 'cargo' ('command not found') as well as > one 'rustc' ('error[E0658]: `let...else` statements are unstable') > errors: Yeah, I noticed those earlier, but oddly the tree became compilable again earlier today, then broke

Sourceware infrastructure updates for Q1 2024

Sourceware infrastructure community updates for Q1 2024 A summary of news about Sourceware, the Free Software hosting project for core toolchain and developer tools, from the last 3 months. - Sourceware now has an official donation page - StarFive VisionFive-2 RISC-V boards for

Sourceware infrastructure updates for Q4 2023

Sourceware infrastructure community updates for Q4 2023 - 6 months with the Software Freedom Conservancy - Sourceware @ Fosdem - OSUOSL provides extra larger arm64 and x86_64 buildbot servers - No more From rewriting for patches mailinglists = 6 months with the Software Freedom Conservancy

Re: gcc-patches From rewriting mailman settings

Hi, On Sun, Sep 17, 2023 at 10:04:37PM +0200, Mark Wielaard wrote: > On Tue, Sep 12, 2023 at 05:00:07PM +0200, Mark Wielaard wrote: > > We (Jeff or anyone else with mailman admin privs) could use the same > > settings for gcc-patches. The settings that need to be set are

Re: ☠ Buildbot (Sourceware): gccrust - failed '! grep ...' (failure) (master)

Hi, On Fri, 2023-08-18 at 16:07 +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-debian-ppc64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/3/builds/1488 > > Build state: failed '!

Sourceware joins Software Freedom Conservancy

https://sfconservancy.org/news/2023/may/15/sourceware-joins-sfc/ After various discussions and lots of positive feedback [1] [2] [3] [4] Software Freedom Conservancy and Sourceware proudly announce that Sourceware today joins SFC as a member project! As the fiscal host of Sourceware, Software

Re: [GSoC] gccrs Unicode support

Hi, On Thu, 2023-03-16 at 10:28 +0100, Thomas Schwinge wrote: > I'm now also putting Mark Wielaard in CC; he once also started discussing > this topic, "thinking of importing a couple of gnulib modules to help > with UTF-8 processing [unless] other gcc frontends handle [these thi

Sourceware infrastructure updates Q1 2023

and/or providing hardware for builder.sourceware.org Brno University, Dan Horák, Marist University, Thomas Fitzsimmons, Mark Wielaard, Frank Eigler, IBM, Carl Love, The Works on Arm initiative, Christophe Lyon, and Red Hat -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust

[PATCH] Disable mn_gccrust and mn_gccrust_bootstrap services

Don't sent email to "interested users" for the gccrust and gccrust-bootstrap problem reports. Since these build might happen after a merge from gcc to gccrs this might include a lot of people. Only sent change notifications to the gcc-rust mailinglist. --- builder/master.cfg | 30

Sourceware network outage, Tuesday 2023-01-31

We've received word from our data centre hosts that they will have a network infrastructure outage tomorrow, Tuesday 2023-01-31, between 8am and 12am EST (UTC-5). We may follow that up with a server firmware-related update/boot. This impacts sourceware.org, builder.sourceware.org,

Re: Sourceware infrastructure presentation and community Q

On Tue, Nov 15, 2022 at 10:46:17PM +0100, Mark Wielaard wrote: > https://www.fsf.org/events/sourceware-infrastructure-a-presentation-and-community-q-a > https://inbox.sourceware.org/overseers/6e9cde97-d880-5343-6cfd-16a648cf6...@fsf.org/ > > We like to discuss how to use the new in

Re: Rust front-end patches v4

Hi John, On Tue, Dec 06, 2022 at 12:57:17PM +0100, John Paul Adrian Glaubitz wrote: > On 12/6/22 12:40, Arthur Cohen wrote: > > > Can't wait to see this becoming available in the distributions :D. > > > > > > I will make sure we get the frontend enabled in Debian as soon as > > > possible. > >

Sourceware infrastructure presentation and community Q

This Friday, 18 November, at 16:00 UTC (11:00am Eastern, 17:00 Central European Time) the FSF will host a session on their BBB server about the current sourceware infrastructure and future plans. https://www.fsf.org/events/sourceware-infrastructure-a-presentation-and-community-q-a

Re: [PATCH Rust front-end v3 01/46] Use DW_ATE_UTF for the Rust 'char' type

/commit/?h=no-Rust-old if someone wants to push that, to merge for a v4. Thanks, Mark>From cdcfe27cfba23402f91200c64c1ef8e0bf3528a0 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sun, 30 Oct 2022 16:03:16 +0100 Subject: [PATCH] dwarf2out.c: Don't emit DW_LANG_Rust_old DW_LANG_Rust_old is a

Re: Sourceware accepted as SFC member project

Hi Philip, On Fri, Sep 09, 2022 at 11:11:56AM +0100, Philip Herron wrote: > Do you have the link available to join this mailing list? https://sourceware.org/mailman/listinfo/overseers Note that you don't need to be subscribed to post to the list and you can also follow the list through imap,

Sourceware accepted as SFC member project

with, the next steps they are invited to join the sourceware overseers list. https://sourceware.org/pipermail/overseers/2022q3/018834.html Thanks, Chris Faylor Frank Eigler Mark Wielaard -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust

Proposing Sourceware as SFC member project

/018802.html Chris Faylor Frank Eigler Mark Wielaard -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed compile (failure) (master)

On Thu, 2022-08-25 at 15:31 +, buil...@sourceware.org wrote: > A new failure has been detected on builder gccrust-bootstrap-debian- > amd64 while building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/107/builds/83 > > Build state: failed

Re: Rust frontend patches v2

Hi Martin, On Thu, 2022-08-25 at 11:52 +0200, Martin Liška wrote: > What about limit increase, how much space do we have on sourceware > infrastructure? Feel free to increase the limits, there is a couple of hundred GB free on sourceware and we can add more. The public-inbox instance at

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'make clean' (failure) (master)

Hi, On Fri, Jul 22, 2022 at 12:49:54AM +0200, Mark Wielaard wrote: > On Thu, Jul 21, 2022 at 10:38:18PM +, builder--- via Gcc-rust wrote: > > A new failure has been detected on builder gccrust-bootstrap-debian-amd64 > > while building gccrust. > > > >

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'make clean' (failure) (master)

Hi, On Thu, Jul 21, 2022 at 10:38:18PM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-bootstrap-debian-amd64 > while building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/107/builds/43 > > Build

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)

Hi, On Fri, Jul 15, 2022 at 05:46:42PM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-rawhide-x86_64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/132/builds/38 > > Build state:

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed update (failure) (master)

On Mon, Jul 04, 2022 at 09:13:12AM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-opensuseleap-x86_64 while > building gccrust. > [,,,] > A new failure has been detected on builder gccrust-rawhide-x86_64 while > building gccrust. Apologies, the

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed compile (failure) (master)

Hi, On Fri, Jun 24, 2022 at 09:21:21AM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-bootstrap-debian-amd64 > while building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/107/builds/2 > > Build

gccrust debian stable bootstrap builder (Was: ☝ Buildbot (GNU Toolchain): gccrust - worker cancelled (master))

. Cheers, Mark >From 65cd2f861528d5ef59f594c7c8372975562abad4 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Sun, 19 Jun 2022 02:03:18 +0200 Subject: [PATCH 1/2] Add gccrs debian-stable bootstrap builder Add a new gccrust-bootstrap Scheduler with a treeStableTimer of 10 minutes. Share g

[PATCH] Actually set TYPE_PACKED for type_record

When bootstrapping with --enable-checking=no you'll get: gcc/rust/backend/rust-compile-type.cc: In member function ‘virtual void Rust::Compile::TyTyResolveCompile::visit(const Rust::TyTy::ADTType&)’: gcc/tree.h:2312:59: error: statement has no effect [-Werror=unused-value] 2312 | #define

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)

Hi, On Thu, May 26, 2022 at 09:53:41AM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-fedora-s390x while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/37/builds/136 > > Build state:

Re: ☝ Buildbot (GNU Toolchain): gccrust - worker cancelled (master)

Hi, On Tue, May 24, 2022 at 01:01:55AM +, builder--- via Gcc-rust wrote: > A cancelled build has been detected on builder gccrust-fedora-x86_64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/16/builds/131 > > Build

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)

Hi, On Wed, May 11, 2022 at 06:06:16PM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-debian-ppc64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/3/builds/103 > > Build state:

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed 'grep unexpected ...' (failure) (master)

On Tue, 2022-05-10 at 11:00 +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-debian-i386 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/27/builds/98 Just when we were all green :{ It

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed compile (failure) (master)

. I'll disable the arm64 builder for now till I have figured out how to provide more memory to it. Cheers, Mark>From 554270393043c2c893b819f43ef59a1c732ded62 Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Thu, 28 Apr 2022 13:35:07 +0200 Subject: [PATCH] Disable gccrust-debian-arm64 builder T

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed compile (failure) (master)

Hi, On Fri, 2022-04-22 at 13:29 +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-debian-arm64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/34/builds/20 > > Build state: failed

Re: ☠ Buildbot (GNU Toolchain): gccrust - failed compile (failure) (master)

Hi, On Thu, Apr 21, 2022 at 06:32:37PM +, builder--- via Gcc-rust wrote: > A new failure has been detected on builder gccrust-debian-arm64 while > building gccrust. > > Full details are available at: > https://builder.sourceware.org/buildbot/#builders/34/builds/8 > > Build state:

Re: ☠ Buildbot (Wildebeest Builder): gccrust - failed compile (failure) (master)

Hi, On Tue, 2022-04-12 at 13:07 +, build...@builder.wildebeest.org wrote: > A new failure has been detected on builder gccrust-debian-arm64 while > building gccrust. > > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1814 > > Build state:

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Tue, Mar 22, 2022 at 12:41:01PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1770 > >

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi Arthur, On Mon, 2022-03-07 at 15:32 +0100, Arthur Cohen wrote: > I suspect this might be due to bors, our merging bot on github, and me > asking it to merge multiple pull requests this morning (around 4 or 5). > Not really sure. > > But the bug is fixed and properly placed in the history :)

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Mon, 2022-03-07 at 10:57 +0100, Arthur Cohen wrote: > This is due to the lexer's fix not being in yet. I think it should > be > resolved later as soon as bors merges the fix, but I'll check just in > case. According to: https://builder.wildebeest.org/buildbot/#/builders?tags=gccrust It

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Sun, Mar 06, 2022 at 11:20:56PM +0100, Mark Wielaard wrote: > On Sun, Mar 06, 2022 at 10:01:10PM +, build...@builder.wildebeest.org > wrote: > > The Buildbot has detected a new failure on builder gccrust-debian-arm64 > > while building gccrust. > > Fu

Re: Buildbot failure in Wildebeest Builder on whole buildset

On Sun, Mar 06, 2022 at 10:01:10PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1716 > >

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Wed, 2022-03-02 at 09:03 +, Philip Herron wrote: > Yet again the build bots are out doing github automation :D. Would > you > be able to give Arthur access to the failing buildbot to test his > fix? Sure. Arthur can you sent me your ssh pubkey? > We think we know what the issue is.

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Tue, Mar 01, 2022 at 07:08:15PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1710 > >

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Wed, Feb 23, 2022 at 12:26:26PM +0100, Mark Wielaard wrote: > So there were 3 issues: > > - The debian-i386 build had pre-existing failures that weren't > reported before. > - The recent commits introduced some tests which failed, and then > some code changes that fi

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Wed, 2022-02-23 at 11:35 +0100, Mark Wielaard wrote: > So, this works as expected. Note that it reports issues not just for > debian-i386, but also for some other arches (all debian based). The > i386 issues are not new. But the others do seem to be caused by the > latest commi

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, So, this works as expected. Note that it reports issues not just for debian-i386, but also for some other arches (all debian based). The i386 issues are not new. But the others do seem to be caused by the latest commit. I haven't investigated why yet though. The buildbot links also point to

make check-rust doesn't fail, but now the buildbot does

Hi, make check-rust doesn't fail if there are any unexpected failuress. I couldn't figure out why not. So I added a new step to the buildbot so that it does grep unexpected gcc/testsuite/rust/rust.sum; test $? == 1" which should make the build fail if there are any unexpected test results. If

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi Marc, Hi Tom, On Fri, Feb 18, 2022 at 12:48:23PM +, dkm--- via Gcc-rust wrote: > > Worker for this Build: debian-ppc64 > > Looks like the ppc64 is requesting a bigger disk :) > > fatal: sha1 file > '/var/lib/buildbot/workers/wildebeest/gccrust-debian-ppc64/gccrs/.git/index.lock' >

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Thu, Feb 17, 2022 at 10:05:29PM +0100, Mark Wielaard wrote: > On Thu, Feb 17, 2022 at 08:46:01PM +0100, Marc via Gcc-rust wrote: > > ../gccrs/gcc/rust/hir -I ../../gccrs/gcc/rust/resolve -I > > ../../gccrs/gcc/rust/util -I ../../gccrs/gcc/rust/typecheck -I > > ../.

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi Marc, On Thu, Feb 17, 2022 at 08:46:01PM +0100, Marc via Gcc-rust wrote: > build...@builder.wildebeest.org writes: > > > Build Reason: > > Blamelist: Philip Herron > > g++ -fno-PIE -c -DIN_GCC_FRONTEND -g -O2 -DIN_GCC -fno-exceptions > -fno-rtti -fasynchronous-unwind-tables -W

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Sat, 2022-02-05 at 16:58 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1620 > > Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi Thomas, On Thu, 2022-02-03 at 21:55 +0100, Thomas Schwinge wrote: > On 2022-01-29T21:20:45+0100, Mark Wielaard wrote: > > On Tue, Jan 25, 2022 at 11:42:41PM +0100, Mark Wielaard wrote: > > > I added a filesIsImportant filter to the buildbot gccrs > > > schedule

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Sat, Jan 29, 2022 at 04:20:57PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1609 > >

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Tue, Jan 25, 2022 at 11:42:41PM +0100, Mark Wielaard wrote: > I added a filesIsImportant filter to the buildbot gccrs scheduler: > > gccrs_files = ["gcc/rust/", "gcc/testsuite/rust/", "gcc/config/.*/*-rust.c"] > > def gccrsImpo

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Tue, Jan 25, 2022 at 08:33:50AM +0100, Thomas Schwinge wrote: > On 2022-01-24T22:30:21+0100, Marc via Gcc-rust wrote: > > Mark Wielaard writes: > >> Sorry, I don't immediately know what is happening. > >> I assume some merge took place and the buildbot doesn't

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Mon, 2022-01-24 at 12:29 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian- > arm64 while building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/1581 > > Buildbot

Re: Buildbot failure in Wildebeest Builder on whole buildset

On Sun, 2021-12-19 at 17:13 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian- > ppc64 while building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/64/builds/6 > > Buildbot URL:

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Fri, 2021-11-05 at 13:49 +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-fedora- > s390x while building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/63/builds/1072 > > Buildbot

Re: byte/char string representation (Was: [PATCH] Fix byte char and byte string lexing code)

Hi Philip, On Thu, Sep 30, 2021 at 11:46:30AM +0100, Philip Herron wrote: > Your patch was 99% of the way there to fix the type > resolution so I finished it off for you: > > https://github.com/Rust-GCC/gccrs/pull/698/files And you added the actual backend code needed! So I'll probably say I

[PATCH] Fix lexer to not produce bad unicode escape values

There were a couple of issues in the lexer unicode escape code. Unicode escape sequences must always start with an opening curly bracket (and end with a closing one). Underscores are not allowed as starting character. And the produced values must be unicode scalar values, which excludes surrogate

[PATCH] Fix raw byte string parsing of zero and out of range bytes

Allow \0 escape in raw byte string and reject non-ascii byte values. Change parse_partial_hex_escapes to not skip bad characters to provide better error messages. Add rawbytestring.rs testcase to check string, raw string, byte string and raw byte string parsing. ---

[no subject]

>From e6e1cc117e1f08dfde86f5a3b1988e4b7206a7da Mon Sep 17 00:00:00 2001 From: Mark Wielaard Date: Wed, 29 Sep 2021 22:03:34 +0200 Subject: [PATCH] Fix raw byte string parsing of zero and out of range bytes Allow \0 escape in raw byte string and reject non-ascii byte values. Cha

[PATCH] Remove raw string and raw byte string references from ast and hir

Raw strings and raw byte strings are simply different ways to create string and byte string literals. Only the lexer cares how those literals are constructed and which escapes are used to construct them. The parser and hir simply see strings or byte strings. ---

Re: Buildbot failure in Wildebeest Builder on whole buildset

On Sat, Sep 25, 2021 at 12:04:01PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/469 O fun. I

Re: byte/char string representation (Was: [PATCH] Fix byte char and byte string lexing code)

Hi Philip, On Fri, Sep 24, 2021 at 12:01:42PM +0100, Philip Herron wrote: > This is really useful information, will this mean that the lexer token will > need to represent strings differently as well? Or is the std::string in the > lexer still ok? I think the respresentation as std::string is

Re: Merge from GCC upstream into GCC/Rust

Hi Thomas, On Fri, Sep 24, 2021 at 10:30:15AM +0200, Thomas Schwinge wrote: > I'm preparing a merge from GCC upstream into GCC/Rust. This is normally > pretty unexciting ;-) -- the exception being, as once mentioned in > :

byte/char string representation (Was: [PATCH] Fix byte char and byte string lexing code)

On Thu, Sep 23, 2021 at 04:10:59PM +0200, Arthur Cohen wrote: > > Something I was thinking about outside of the scope of that patch was > about the utf8 how do they get represented? Is it some kind of wchar_t? > > Do you mean in C++ or in rustc? In rustc, they are represented as Unicode > Scalar

Re: [PATCH] Fix byte char and byte string lexing code

Hi Thomas, On Wed, Sep 22, 2021 at 11:48:56AM +0200, Thomas Schwinge wrote: > That's . > [...] > That's . Ah, sorry, I don't really track the github issues and had missed those. But good to see the analysis

[PATCH] Fix byte char and byte string lexing code

There were two warnings in lexer parse_byte_char and parse_byte_string code for arches with signed chars: rust-lex.cc: In member function ‘Rust::TokenPtr Rust::Lexer::parse_byte_char(Location)’: rust-lex.cc:1564:21: warning: comparison is always false due to limited

Re: [PATCH] Remove warnings from v0_mangle functions in rust-mangle.cc

Hi Arthur, On Tue, 2021-09-21 at 13:58 +0200, cohenarthur.dev via Gcc-rust wrote: > I forgot to do a clean build before creating the pull request and the > file was already compiled... Sorry about that! > > I'll keep on working on v0 mangling in order to get all the parts > linked correctly, but

[PATCH] Remove warnings from v0_mangle functions in rust-mangle.cc

There were two warnings in rust-mangle.cc rust-mangle.cc: In function ‘std::string Rust::Compile::v0_mangle_item (const Rust::TyTy::BaseType*, const Rust::Resolver::CanonicalPath&, const string&)’: rust-mangle.cc:198:1: warning: no return statement in function returning non-void

[PATCH 3/3] Add EnumItem HIR lowering

Make HIT EnumItem class an Item, not VisItem like in the AST. At the HIR level EnumItems shouldn't have visibility anymore. Move struct_field_name_exists to rust-ast-lower.cc with the declaration in rust-ast-lower.h to make it reusable in the different visitors. Add a new ASTLoweringEnumItem

[PATCH 2/3] Resolve Enums and EnumItems

Generate paths for Enum and EnumItem AST NodeIds and resolve the types of tuple and struct enum items. EnumItems always have the Enum as prefix. To make this work for ResolveStms (declaration statements are not given a canonical path) we add an enum_prefix to be used when resolving EnumItems.

Re: Cleanup some StructExpr related classes

Hi Philip, On Thu, Sep 02, 2021 at 02:23:33PM +0100, Philip Herron wrote: > I've been reviewing your branch a bit and noticed this commit > https://code.wildebeest.org/git/user/mjw/gccrs/commit/?h=enums=84d27b926e09ef44dd94be20c97d72bd4b865c40 > which I really like. I wasn't sure what was the

Re: Cleanup some StructExpr related classes

Hi, On Wed, Sep 01, 2021 at 11:11:46AM +0100, Philip Herron wrote: > This is fantastic work Mar. This brings us closer to the AST structures of > rustc and does simplify a lot of the analysis within the compiler. > https://doc.rust-lang.org/nightly/reference/expressions/struct-expr.html The

[PATCH 3/3] Remove Enumaration Expression, EnumExpr, classes

An Enumaration Expression is just like a Struct Expression. Old versions of the Rust Reference described them separately. But since they are syntactically exactly like a Struct Expression they are never actually parsed. A Struct Expression can also be used to initialize enums (and unions). Remove

[PATCH 2/3] StructExprUnit doesn't really exist

A StructExprUnit is parsed as an IdentifierExpr. An IdentifierExpr, which is what we call a single segment PathInExpression. After type checking, when generating gcc generic trees, if the IdentifierExpr is a type reference (which must be a unit struct), then a unit expression is generated.

Cleanup some StructExpr related classes

Hi, There are various Structure Expressions that don't actually "exist" because they are syntactically equivalent to other constructs. So we never really construct or use these classes. But they are still listed in various visitors, which is somewhat confusing. Removing the AST and HIR variants

[PATCH 1/3] StructExprTuple doesn't really exist

A StructExprTuple is parsed as a CallExpr. Both (can) start with a PathInExpression followed by zero or more Expressions between brackets. Only, after type checking, when actually generating gcc generic trees is a distinction made between a function call or tuple constructor. Remove the AST and

[PATCH 3/3] Remove GetLocusFromImplItem visitor

Simply use get_locus () on the ImplItem. Both the generics7.rs and generics8.rs testcase still pass. --- .../rust-hir-inherent-impl-overlap.h | 45 +-- 1 file changed, 2 insertions(+), 43 deletions(-) diff --git a/gcc/rust/typecheck/rust-hir-inherent-impl-overlap.h

A few more location patches

Hi, Here are a couple of little patches to improve or simplify locations a bit: [PATCH 1/3] Use location when lowering TupleField [PATCH 2/3] Replace HIRItem::get_impl_locus with HirItem::get_locus [PATCH 3/3] Remove GetLocusFromImplItem visitor Also on

[PATCH 2/3] Replace HIRItem::get_impl_locus with HirItem::get_locus

HIRItem::get_impl_locus wasn't used and all subclasses already implement get_locus. --- gcc/rust/hir/tree/rust-hir-item.h | 6 -- gcc/rust/hir/tree/rust-hir.h | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/gcc/rust/hir/tree/rust-hir-item.h

[PATCH 1/3] Use location when lowering TupleField

--- gcc/rust/hir/rust-ast-lower-stmt.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/rust/hir/rust-ast-lower-stmt.h b/gcc/rust/hir/rust-ast-lower-stmt.h index 1e72c8a2023..fdd5041d602 100644 --- a/gcc/rust/hir/rust-ast-lower-stmt.h +++

[PATCHv2] Get rid of get_locus_slow

In various places there was the following hack: /* HACK: slow way of getting location from base expression through virtual methods. */ virtual Location get_locus_slow () const { return Location (); } The problem with get_locus_slow () is that if a subclass didn't override it then there

Re: [PATCH] Get rid of get_locus_slow

On Thu, Aug 26, 2021 at 10:31:06AM +0800, The Other wrote: > The original point of the distinction between get_locus_slow() and > get_locus() was to avoid the overhead of virtual function calls > whenever possible, but still have a way to access locations from > abstract base classes like Expr.

[PATCH] Get rid of get_locus_slow

In various places there was the following hack: /* HACK: slow way of getting location from base expression through virtual methods. */ virtual Location get_locus_slow () const { return Location (); } The problem with get_locus_slow () is that if a subclass didn't override it then there

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi, On Sun, Aug 22, 2021 at 03:55:47PM +, build...@builder.wildebeest.org wrote: > The Buildbot has detected a new failure on builder gccrust-debian-arm64 while > building gccrust. > Full details are available at: > https://builder.wildebeest.org/buildbot/#builders/58/builds/355 This

[PATCH] Reject duplicate field names in structs and unions.

Odd things happen if structs or unions have duplicate field names. Emit an error when lowering an struct/union item or declaration statement and a duplicate field name is detected. A new testcase 'dup_fields.rs' checks an error is actually produced. ---

Re: [PATCH] Add support for const bool and const float

Hi, On Mon, Aug 16, 2021 at 11:03:19PM +0200, Mark Wielaard wrote: > Now having replicated it locally the rust.log shows: > > /srv/gccrs/gccrs/gcc/testsuite/rust/compile/torture/ifunaryexpr.rs: In > function 'main': > /srv/gccrs/gccrs/gcc/testsuite/rust/compile/torture/ifu

[PATCH] Allow bool and char to be cast as any integer type

bools and chars can be cast to any integer type, but not to floats or each other. Adjust the BoolCastRule and CharCastRule to allow these casts. Add a postive test "as_bool_char.rs" and negative test "bad_as_bool_char.rs" to check the correct casts are accepted and the illegal casts produce

Re: [PATCH] Add support for const bool and const float

Hi Marc, On Mon, 2021-08-16 at 07:48 +, d...@kataplop.net wrote: > Looks like tests are not OK, at least in the github action. Are you talking about this patch (which I cannot find on github) or "Use builtin bool instead of creating new bool types for ComparisonExpr"? On github I can only

[PATCH] Use default type_for_size langhook

The gcc constant folding code uses the type_for_size langhook. Use the default implementation instead of crashing when the langhook is called. Add a new testcase "prims_struct_eq.rs" that creates trees that triggers the constant folding. Also remove the write_globals langhook which was removed

[PATCH] Add support for const bool and const float

Handle BOOL and FLOAT in ConstFoldExpr::visit (HIR::LiteralExpr) to make it possible to create const bool, f32 and f64 constants. Add a new testcase "primconsts.rs". Not yet handled are const char and types. --- gcc/rust/typecheck/rust-hir-const-fold.h | 30

[PATCH] Suppress uninitialized candidate_type warning in process_traits_for_candidates

Without handling the default case in the switch statement gcc 10.2.1 will warn: rust-hir-path-probe.h:75:40: warning: ‘candidate_type’ may be used uninitialized in this function [-Wmaybe-uninitialized] --- gcc/rust/typecheck/rust-hir-path-probe.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] Use builtin bool instead of creating new bool types for ComparisonExpr

The TypeCheckExpr creates a new TyTy::BoolType for a ComparisonExpr. This new BoolType is unknown to TyTyResolveCompile which causes a crash when trying to compile the inferred new BoolType. The new "bools_eq.rs" testcase uses several bools which show this issue. Resolve this by looking up the

Re: [PATCH] Pass pratt parsed token to expr parser functions to fix expr locus

Hi, On Sat, Aug 07, 2021 at 03:01:39AM +0200, Mark Wielaard wrote: > > Sorry for lack of reply on this. After looking into this and also > > getting Arthur Cohen to review, I think: > > > > * Token passing: If we end up using the token for more than the > >

[PATCH] lex: accept zero codepoints in strings

Zero characters (codepoints) are acceptable in strings. The current Lexer::parse_string skipped such zero codepoints by accidents. The zero codepoint was also used as error/skip indicator, but that is only true if the third argument of utf8_escape_pair is true (yes, it is called pair, but is a

Re: Buildbot failure in Wildebeest Builder on whole buildset

Hi Philip, On Fri, Aug 06, 2021 at 03:31:07PM +0100, Philip Herron wrote: > > Is it possible to make bors check all commits in a series? Or can we > > somehow connect the buildbot workers to the bors checks? > > I think the build-bot checks for every commit is a really nice feature > here. I

[PATCH] More rustspec.cc cleanups

rustspec.cc was based on the Go frontend gospec.cc. Remove special handling of math and pthread libraries and profiling option. Handle .rs files instead of .go files. Keep support for linking with (static) librust which is currently commented out. Add generic static-librust option to common.opt.

  1   2   >