Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
Thank you Even. Paul Op zo 18 dec. 2022 om 22:59 schreef Even Rouault : > Paul, > > I've queued your proposed fix in pull request > https://github.com/OSGeo/gdal/pull/6943 > > Even > Le 18/12/2022 à 22:18, Paul Meems a écrit : > > I made the brackets bold. That seems to result in the * > Only (

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Even Rouault
Paul, I've queued your proposed fix in pull request https://github.com/OSGeo/gdal/pull/6943 Even Le 18/12/2022 à 22:18, Paul Meems a écrit : I made the brackets bold. That seems to result in the * Only ( and ) are needed, no *. Regards, Paul Op zo 18 dec. 2022 18:39 schreef Andrew C Aitchi

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
I made the brackets bold. That seems to result in the * Only ( and ) are needed, no *. Regards, Paul Op zo 18 dec. 2022 18:39 schreef Andrew C Aitchison : > On Sun, 18 Dec 2022, Paul Meems wrote: > > > Thanks all for your suggestions. > > I did some more research and it seems to be an issue with

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Andrew C Aitchison
On Sun, 18 Dec 2022, Paul Meems wrote: Thanks all for your suggestions. I did some more research and it seems to be an issue with the preprocessor on Windows. Adding some brackets solves the issue as well: // old constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 = std::numeric_limits::min()

Re: [gdal-dev] std::numeric_limits::min() vs LLONG_MIN

2022-12-18 Thread Paul Meems
Thanks all for your suggestions. I did some more research and it seems to be an issue with the preprocessor on Windows. Adding some brackets solves the issue as well: // old constexpr int64_t GDAL_PAM_DEFAULT_NODATA_VALUE_INT64 = std::numeric_limits::min(); constexpr uint64_tGDAL_PAM_DEFAULT_NODAT