Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

On Sun, Nov 20, 2022 at 8:21 PM Even Rouault wrote: > Hi Frank, > > > I'm not a huge GoogleTest fan but then I'm also not saying it *worse* than > any alternative, but the reasons are reasonably convincing, and I'm happy > if those running and contributing tests are happy! > > Just curious what

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

Hi Frank, I'm not a huge GoogleTest fan but then I'm also not saying it *worse* than any alternative, but the reasons are reasonably convincing, and I'm happy if those running and contributing tests are happy! Just curious what you don't like with GoogleTest ? Should I understand from the

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

Even, I'm not a huge GoogleTest fan but then I'm also not saying it *worse* than any alternative, but the reasons are reasonably convincing, and I'm happy if those running and contributing tests are happy! Should I understand from the RFC that https://github.com/rouault/gdal/tree/gtest

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

I am not in the PSC, but this RFC sounds very good. Thanks! Now that the tests are going to change, maybe it is a good idea to apply clang-format to them. .___ ._ ..._ .. . ._. .___ .. __ . _. . __.. ... ._ .__ Entre dos pensamientos racionales hay infinitos pensamientos irracionales.

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

Hi Mateusz, TUT was a very sensible choice at the time you implemented it, and it has been very useful up to now ! Even Le 17/11/2022 à 18:02, Mateusz Loskot a écrit : On Wed, 16 Nov 2022 at 19:42, Even Rouault wrote: Text at https://github.com/OSGeo/gdal/pull/6720 The document proposes

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

On Wed, 16 Nov 2022 at 19:42, Even Rouault wrote: > > Text at https://github.com/OSGeo/gdal/pull/6720 > > The document proposes and describes conversion of the existing C/C++ > autotest suite to use the `GoogleTest > framework `__. > > GoogleTest is a popular

Re: [gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

I am +1 for this switch, but I'm definitely biased by working at Google. My thoughts: tut definitely gets the job done, but I found it a bit awkward too. But I think the updates and the additional features of GoogleTest are probably worth it. I especially like the distinction between ASSERT.*

[gdal-dev] Call for discussion: RFC88: Use GoogleTest framework for C/C++ unit tests

Hi, As this is RFC season. I've prepared RFC88: Use GoogleTest framework for C/C++ unit tests Text at https://github.com/OSGeo/gdal/pull/6720 Summary: The document proposes and describes conversion of the existing C/C++ autotest suite to use the `GoogleTest framework