Re: [gdal-dev] GetSpatialRef, OGRSpatialReference and memory leaks ?

2020-08-03 Thread Andrew C Aitchison
On Mon, 3 Aug 2020, Even Rouault wrote: Andrew, You should hold a OGRSpatialReference object as a member variable of the dataset object and return its address. The ownership of the object remains to the dataset object as indicated in the doc: Thanks. I figured that from Andrew Bell's hint.

Re: [gdal-dev] GetSpatialRef, OGRSpatialReference and memory leaks ?

2020-08-03 Thread Even Rouault
On samedi 1 août 2020 10:44:45 CEST Andrew C Aitchison wrote: > I would like to define GetSpatialRef() for my raster driver as something > like: > > const OGRSpatialReference* GetSpatialRef() const override { > OGRSpatialReference* poSRS = new OGRSpatialReference(); > if (po

Re: [gdal-dev] GetSpatialRef, OGRSpatialReference and memory leaks ?

2020-08-01 Thread Andrew C Aitchison
On Sat, 1 Aug 2020, Andrew Bell wrote: Thanks for the hint. I had assumed that the caller was taking responsibility for it. Seems like it would depend on what you're doing with the pointer after you return it. On Sat, Aug 1, 2020, 5:50 AM Andrew C Aitchison wrote: I would like to define Ge

Re: [gdal-dev] GetSpatialRef, OGRSpatialReference and memory leaks ?

2020-08-01 Thread Andrew Bell
Seems like it would depend on what you're doing with the pointer after you return it. On Sat, Aug 1, 2020, 5:50 AM Andrew C Aitchison wrote: > > I would like to define GetSpatialRef() for my raster driver as something > like: > > const OGRSpatialReference* GetSpatialRef() const override { >

[gdal-dev] GetSpatialRef, OGRSpatialReference and memory leaks ?

2020-08-01 Thread Andrew C Aitchison
I would like to define GetSpatialRef() for my raster driver as something like: const OGRSpatialReference* GetSpatialRef() const override { OGRSpatialReference* poSRS = new OGRSpatialReference(); if (poSRS->importFromEPSGA(27700)!=OGRERR_NONE) { delete poSR