[Geany-devel] Find in files - Re: Patches required by gproject

2010-06-21 Thread Nick Treleaven
On Mon, 21 Jun 2010 08:47:54 +1000 Lex Trotman wrote: > > I like your idea in general, the only thing I don't like about it is > > that you wouldn't see the patterns in the FIF dialog, which would make > > it a bit unclear what you are searching for. I would propose to have a > > "file types" edi

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-21 Thread Jiří Techet
On Mon, Jun 21, 2010 at 16:08, Nick Treleaven wrote: > On Mon, 21 Jun 2010 08:47:54 +1000 > Lex Trotman wrote: > >> > I like your idea in general, the only thing I don't like about it is >> > that you wouldn't see the patterns in the FIF dialog, which would make >> > it a bit unclear what you are

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-21 Thread Lex Trotman
On 22 June 2010 00:08, Nick Treleaven wrote: > On Mon, 21 Jun 2010 08:47:54 +1000 > Lex Trotman wrote: > >> > I like your idea in general, the only thing I don't like about it is >> > that you wouldn't see the patterns in the FIF dialog, which would make >> > it a bit unclear what you are searchi

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Mon, 21 Jun 2010 20:53:58 +0200 Jiří Techet wrote: > >> Having a filetype pattern in the find in files dialog could be useful. > >>  Note that --include is a GNU grep extension, so a blank file pattern > >> should be the default and should not generate the option to grep so as > >> to maintain

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Jiří Techet
On Tue, Jun 22, 2010 at 13:46, Nick Treleaven wrote: > On Mon, 21 Jun 2010 20:53:58 +0200 > Jiří Techet wrote: > >> >> Having a filetype pattern in the find in files dialog could be useful. >> >>  Note that --include is a GNU grep extension, so a blank file pattern >> >> should be the default and

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Tue, 22 Jun 2010 15:19:02 +0200 Jiří Techet wrote: > >> > think it may be best if Geany does the filtering (and hence also the > >> > recursing). Also we may want to always filter out hidden files and > >> > broken links. > >> > >> There is one problem here - the command line may be too long.

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Nick Treleaven
On Tue, 22 Jun 2010 16:48:29 +0100 Nick Treleaven wrote: > > To me it looks much easier to use what's already present in grep right > > now and if this isn't satisfactory, it could be reimplemented the way > > you propose in the future. In addition if no patterns are specified, > > geany will beh

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-22 Thread Lex Trotman
On 23 June 2010 02:54, Nick Treleaven wrote: > On Tue, 22 Jun 2010 16:48:29 +0100 > Nick Treleaven wrote: > >> > To me it looks much easier to use what's already present in grep right >> > now and if this isn't satisfactory, it could be reimplemented the way >> > you propose in the future. In add

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-23 Thread Jiří Techet
On Tue, Jun 22, 2010 at 18:54, Nick Treleaven wrote: > On Tue, 22 Jun 2010 16:48:29 +0100 > Nick Treleaven wrote: > >> > To me it looks much easier to use what's already present in grep right >> > now and if this isn't satisfactory, it could be reimplemented the way >> > you propose in the future

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-24 Thread Nick Treleaven
On Wed, 23 Jun 2010 22:57:00 +0200 Jiří Techet wrote: > >> Let's use --include then if the user ticks a checkbox. That way a > >> non-gnu system will still be able to do non-recursive all files search. > > > > BTW I've just added a dummy Files checkbox and combobox to the dialog in > > SVN, and w

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-25 Thread Jiří Techet
On Thu, Jun 24, 2010 at 15:50, Nick Treleaven wrote: > On Wed, 23 Jun 2010 22:57:00 +0200 > Jiří Techet wrote: > >> >> Let's use --include then if the user ticks a checkbox. That way a >> >> non-gnu system will still be able to do non-recursive all files search. >> > >> > BTW I've just added a du

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-25 Thread Nick Treleaven
On Fri, 25 Jun 2010 14:32:38 +0200 Jiří Techet wrote: > > I wanted the Files box to be there and wanted to tidy up some things in > > the GUI code so that's done now. > > Looks good. I was just wondering about what separator should be used > to separate the individual patterns - in gproject I us

Re: [Geany-devel] Find in files - Re: Patches required by gproject

2010-06-25 Thread Jiří Techet
On Fri, Jun 25, 2010 at 17:31, Nick Treleaven wrote: > On Fri, 25 Jun 2010 14:32:38 +0200 > Jiří Techet wrote: > >> > I wanted the Files box to be there and wanted to tidy up some things in >> > the GUI code so that's done now. >> >> Looks good. I was just wondering about what separator should be