On 12/07/2010 07:42 AM, Peter Clifton wrote:
I just submitted a patch for some memory leaks that have been annoying
me. The soureforge id is #3131063:
Thanks.
___
geda-user mailing list
geda-user@moria.seul.org
http://www.seul.org/cgi-bin/mailma
Patch0002: we're getting close. I see only one remaining issue:
create.c:900: you address this both in patch 0001 and patch 0002
In patch 0001 you preserve the behaviour of the existing code
In patch 0002 you unconditionally call strdup()
I've looked at the code further, and I think that the appro
Regarding 0002-Not-so-sure-about-these-MyStrdup-calls.patch:
buffer.c:984: I can't tell, and suggest playing it safe with STRDUP()
create.c:593: My $0.02: CreateNewText() called with a NULL pointer
should be stopped in its tracks with a segfault rather than
propagating the error. If you're unsure
On Tue, 2010-12-07 at 23:18 +0100, Kai-Martin Knaak wrote:
> Andrew Miner wrote:
>
> > Fedora has geda (gaf) and pcb available through yum.
>
> So it should be:
> /-
> (...), new users should check the package management of their
> distribution. Major Linux distributions known to offer
On Tue, 2010-12-07 at 13:08 -0800, c...@eugeneweb.com wrote:
> Hi Peter,
>
> Well I did test them with make tests, and just to be sure they would catch
> something I forced an error and they caught it.
>
> These patches are not intended to change any behavior or output, so yes if
> you would pl
On Wed, Dec 8, 2010 at 4:51 AM, Peter Clifton wrote:
> Stephen, I'd appreciate your Acked-by: or Reviewed-by: on the attached
> patches:
Patch 0001 is good, but I can suggest some additional MyStrdup() calls
that can safely be directly replaced with strdup():
create.c
196: safe because DefaultLa
Andrew Miner wrote:
> Fedora has geda (gaf) and pcb available through yum.
So it should be:
/-
(...), new users should check the package management of their
distribution. Major Linux distributions known to offer geda and pcb are
Debian, Ubuntu, Fedora and OpenSuSE ((add more distros he
Hi Peter,
Well I did test them with make tests, and just to be sure they would catch
something I forced an error and they caught it.
These patches are not intended to change any behavior or output, so yes if
you would please push them.
Thanks,
Clif
Date: Tue, 07 Dec 2010 1
On Wed, 2010-12-08 at 03:43 +1100, Stephen Ecob wrote:
> That sounds good. In the interest of saving your development time (I
> don't want to keep you from PCB+GL !), I suggest:
> Of the 51 calls to MyStrdup()
> 7 are "safe" because of calling with a fixed string eg MyStrdup
> ("Font", "FontEd
On Wed, Dec 8, 2010 at 12:52 AM, Peter Clifton wrote:
> Note that the second patch gets my test PCB loading again, but does not
> consider every possible case.
>
> Before committing, these MUST be squashed, but it is convenient to keep
> them separate for now.
>
> Thinking about it, a pre-patch co
On Mon, 2010-12-06 at 21:31 -0800, c...@eugeneweb.com wrote:
> Agreed, and I had a similar experience. I was hoping to get a review or
> just some comments on a couple of patches I submitted (3114991, 3117075).
GAH, I _HATE_ SOURCEFORGE.
Please quote full HTML links when citing sourceforge pat
On Tue, 2010-12-07 at 16:16 +1100, Stephen Ecob wrote:
> I just submitted a patch for some memory leaks that have been annoying
> me. The soureforge id is #3131063:
>
> https://sourceforge.net/tracker/?func=detail&aid=3131063&group_id=73743&atid=538813
>
> Most users won't have noticed these lea
On Tue, 2010-12-07 at 14:59 +1100, Stephen Ecob wrote:
> I propose the following solution:
>
> 1. replace all calls to MyCalloc() with calls to calloc()
> 2. replace all calls to MyMalloc() with calls to malloc()
> 3. replace all calls to MyRealloc() with calls to realloc()
> 4. replace all calls
13 matches
Mail list logo
