On Mon, 18 Apr 2016 17:39:23 -0700
Jonathan Boeing wrote:
> diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c
> index 842b947..18f7311 100644
> --- a/src/ui_bookmark.c
> +++ b/src/ui_bookmark.c
> @@ -707,13 +707,19 @@ static void bookmark_dnd_get_data(GtkWidget
> *widget, {
&g
Dragged and dropped paths from xfe aren't escaped like paths from a gtk
app. A folder named 'test # one' for example causes g_filename_from_uri
to fail and return NULL, which then causes a SIGSEGV in path_to_utf8.
This patch fixes the crash by checking for failed conversions. If
conversion failed
the conversion failed due to a bad URI.
If so, it manually escapes the URI and tries to convert again.
This probably isn't specific to Xfe, but that's the only non-GTK/QT
program I use that can drag and drop.
Jonathan Boeing (1):
Fix crash on drag and drop from xfe
src/ui_bo
On Sun, 17 Apr 2016 17:09:49 +0100
Colin Clark wrote:
> Sorry, but I cannot test here this because I cannot replicate that
> fault on my system.
I'm using Fluxbox rather than a full Desktop Environment; maybe that
has something to do with it?
---
.
>
>
> My apologies if I have misunderstood your solution.
>
>
> Colin Clark
>
Notifying the user would definitely be better. This is my first time
working with GTK, so I was trying to keep it minimal. I'll take a look
at integrating what you suggested.
Thanks,
Jon
fic to Xfe, but that's the only non-GTK/QT
program I use that can drag and drop.
Jonathan Boeing (1):
Fix crash on drag and drop from xfe
src/uri_utils.c | 28 +++-
1 file changed, 27
Dragged and dropped paths from xfe aren't escaped like paths from a gtk
app. A folder named 'test # one' for example causes g_filename_from_uri
to fail and return NULL, which then causes a SIGSEGV in path_to_utf8.
This patch fixes the crash by checking for failed conversions. If
conversion failed