Re: [Geeqie-devel] [rfc] senseless use of ceil/floor in pixbuf-renderer.c (02-03 of 03)

2009-06-17 Thread Yuriy Kaminskiy
Yuriy Kaminskiy wrote: > Attached patch fixes that. Just in case, I did not noticed any user-visible effects (before|after), and not sure whether this patch correct or not. But current code wrong ;-) and should be somehow changed. And I noticed few more places to use introduced in previ

Re: [Geeqie-devel] [PATCH][trivial] attrs did not applied to 'show pixel info' label

2009-06-16 Thread Yuriy Kaminskiy
Yuriy Kaminskiy wrote: > --- geeqie-20090616/src/compat.h.orig 2009-05-15 04:45:45.0 +0400 > +++ geeqie-20090616/src/compat.h 2009-06-16 18:39:21.0 +0400 > +#if PANGO_CHECK_VERSION(2,20,0) Sorry, that should be (1,20,0), corrected patch attached. --- geeqie-200

Re: [Geeqie-devel] [PATCH][trivial] attrs did not applied to 'show pixel info' label

2009-06-16 Thread Yuriy Kaminskiy
Laurent Monin wrote: > in recent versions this doesn't seem to be needed (though i may be > wrong here). Well, I just wanted to ask myself "what did pango devs smoke, not using that by default". FWIW, I'm on debian oldstable/etch, with prehistoric pango 1.14.10 ;-) > /Since 1.20, pango_attribute_i

[Geeqie-devel] [rfc] senseless use of ceil/floor in pixbuf-renderer.c

2009-06-16 Thread Yuriy Kaminskiy
Hello! In pixbuf-renderer.c, I've noticed code like this: x1 = (gint)floor(x / pr->tile_width) * pr->tile_width; x2 = (gint)ceil((x + w) / pr->tile_width) * pr->tile_width; floor and ceil make sense only with float, x/pr->tile_width is integer division (and only then division re

[Geeqie-devel] [PATCH][trivial] attrs did not applied to 'show pixel info' label

2009-06-15 Thread Yuriy Kaminskiy
Hello! Due to missing assignment to start_index and end_index, monospace attribute did not applied to label, causing constant resizing of that field (I've also grepped for pango_attr_list_new - other places were ok). --- geeqie-20090616/src/layout_image.c.orig 2009-06-16 00:32:50.0 +0400