[gem5-dev] Review Request: x86: implement x87 fp instruction fnstsw

2012-12-12 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1591/ --- Review request for Default. Description --- Changeset 9372:9ea0c09dd390 --

Re: [gem5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

2012-12-12 Thread Nilay Vaish
> On May 15, 2012, 12:45 p.m., Marc Orr wrote: > > It seems that none of the instructions that move things on/off the floating > > point stack are implemented in the simulator (fld, fst, fstp, fxchg). Does > > it make sense to commit this code? Check out src/arch/x86/isa/insts/x87/data_transf

Re: [gem5-dev] Review Request: scons: Enforce gcc >= 4.4 or clang >= 2.9 and c++0x support

2012-12-12 Thread nathan binkert
Awesome. My biggest recommendation to everyone writing gem5 code. Learn what rvalue references are and *use* them. We should probably also get rid of our reference counting stuff and use make_shared and shared_ptr. Nate ___ gem5-dev mailing list gem

Re: [gem5-dev] Review Request: scons: Enforce gcc >= 4.4 or clang >= 2.9 and c++0x support

2012-12-12 Thread Ali Saidi
> On Dec. 12, 2012, 8:06 p.m., Nathan Binkert wrote: > > I'm in favor of this change, but this seems like something that should have > > some debate, or is there already general consensus? (Am I too late? :) At the user conference their seemed to be general consensus, no one has responded to

Re: [gem5-dev] Review Request: scons: Enforce gcc >= 4.4 or clang >= 2.9 and c++0x support

2012-12-12 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1556/#review3752 --- I'm in favor of this change, but this seems like something that should ha

Re: [gem5-dev] Review Request: scons: Add support for google protobuf building

2012-12-12 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1572/#review3751 --- Ship it! Thanks for making this optional! I appreciate the effort. - S

Re: [gem5-dev] Review Request: tests: Create base classes to encapsulate common test configurations

2012-12-12 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1550/#review3750 --- classic classes are evil. They don't behave the way new style classes do

Re: [gem5-dev] Review Request: dev: Make the ethernet devices use a non-zero clock

2012-12-12 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1586/#review3749 --- src/dev/ns_gige.cc I

[gem5-dev] changeset in gem5: arm regressions: updates to config.ini, termi...

2012-12-12 Thread Nilay Vaish
changeset 5172ffaf6e30 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=5172ffaf6e30 description: arm regressions: updates to config.ini, terminal files diffstat: tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3-dual/config.ini | 47 + tests/long

[gem5-dev] changeset in gem5: arm: set uopSet_uop as conditional or uncondi...

2012-12-12 Thread Nathanael Premillieu
changeset bd30fcbf8d28 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=bd30fcbf8d28 description: arm: set uopSet_uop as conditional or unconditional control uopSet_uop is microop instruction that has the IsControl flags set, but the IsCondControl or Is

[gem5-dev] changeset in gem5: arm: set movret_uop as conditional or uncondi...

2012-12-12 Thread Nathanael Premillieu
changeset 3cd40209af8d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=3cd40209af8d description: arm: set movret_uop as conditional or unconditional control A flag was missing for the movret_uop microop instruction. This patch adds that flag when the i

Re: [gem5-dev] Review Request: cpu: Add support for protobuf input for the trace generator

2012-12-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1577/ --- (Updated Dec. 12, 2012, 6:54 a.m.) Review request for Default. Description (updat

Re: [gem5-dev] Review Request: base: Add wrapped protobuf input stream

2012-12-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1575/ --- (Updated Dec. 12, 2012, 6:52 a.m.) Review request for Default. Description (updat

Re: [gem5-dev] Review Request: mem: Add tracing support in the communication monitor

2012-12-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1574/ --- (Updated Dec. 12, 2012, 6:51 a.m.) Review request for Default. Description (updat

Re: [gem5-dev] Review Request: base: Add wrapped protobuf output streams

2012-12-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1573/ --- (Updated Dec. 12, 2012, 6:50 a.m.) Review request for Default. Description (updat

Re: [gem5-dev] Review Request: scons: Add support for google protobuf building

2012-12-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1572/ --- (Updated Dec. 12, 2012, 6:49 a.m.) Review request for Default. Description (updat

[gem5-dev] Cron /z/m5/regression/do-regression quick

2012-12-12 Thread Cron Daemon
scons: `build/ALPHA_MOESI_hammer/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MESI_CMP_directory/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MOESI_CMP_directory/tests/opt/quick/fs' is up to date. scons: `build/ALPHA_MOESI_CMP_token/tests/opt/quick/fs' is up to date. scons: `bui