Re: [gem5-dev] Review Request 2272: x86: fix table walker assertion

2014-05-14 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2272/#review5102 --- src/arch/x86/pagetable_walker.cc

Re: [gem5-dev] Review Request 2273: cache: enable multiple stores per cycle

2014-05-14 Thread Andreas Hansson via gem5-dev
> On May 14, 2014, 2:55 p.m., Ali Saidi wrote: > > This looks fine to me, but I'm going to guess Andreas will have a comment. > > This patch fixes the lovelock you mentioned, correct? > > Steve Reinhardt wrote: > Yea, getting rid of the '+ 1' in PacketQueue::scheduleSend is needed to > do

Re: [gem5-dev] Review Request 2273: cache: enable multiple stores per cycle

2014-05-14 Thread Steve Reinhardt via gem5-dev
> On May 14, 2014, 7:55 a.m., Ali Saidi wrote: > > This looks fine to me, but I'm going to guess Andreas will have a comment. > > This patch fixes the lovelock you mentioned, correct? Yea, getting rid of the '+ 1' in PacketQueue::scheduleSend is needed to do two stores in one cycle, an the cha

Re: [gem5-dev] Review Request 2275: o3: make LSQ full check more selective

2014-05-14 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2275/#review5099 --- Ship it! Ship It! - Ali Saidi On May 14, 2014, 5:46 a.m., Steve Reinh

Re: [gem5-dev] Review Request 2274: o3: split load & store queue full cases

2014-05-14 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2274/#review5098 --- Ship it! Ship It! - Ali Saidi On May 14, 2014, 5:46 a.m., Steve Reinh

Re: [gem5-dev] Review Request 2273: cache: enable multiple stores per cycle

2014-05-14 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2273/#review5097 --- Ship it! This looks fine to me, but I'm going to guess Andreas will have

Re: [gem5-dev] Review Request 2272: x86: fix table walker assertion

2014-05-14 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2272/#review5096 --- Ship it! Ship It! - Ali Saidi On May 14, 2014, 5:46 a.m., Steve Reinh

Re: [gem5-dev] Review Request 2276: ruby: don't make O3 CPU squash on loads that hit outstanding requests

2014-05-14 Thread Steve Reinhardt via gem5-dev
> On May 14, 2014, 6:41 a.m., Nilay Vaish wrote: > > gem5 aborts due to segmentation fault with this patch applied. > > > > Program received signal SIGSEGV, Segmentation fault. > > Sequencer::writeCallback (this=0x3c9d800, address=..., data=..., > > externalHit=false, mach=MachineType_NUM, init

Re: [gem5-dev] Review Request 2276: ruby: don't make O3 CPU squash on loads that hit outstanding requests

2014-05-14 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2276/#review5094 --- gem5 aborts due to segmentation fault with this patch applied. Program r

[gem5-dev] Cron /z/m5/regression/do-regression quick

2014-05-14 Thread Cron Daemon via gem5-dev
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/inorder-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simp