Re: [gem5-dev] Review Request 2504: config: Fix to SystemC example's event handling

> On Nov. 20, 2014, 8:54 p.m., Cagdas Dirik wrote: > > I am afraid you have to move config_manager->instantiate() call into > > SimControl::run() after wait. > > > > Currently it is tripping at: > > fatal condition !eventq->empty() occurred: There must be no posted events > > before SimControl

Re: [gem5-dev] Review Request 2523: config: Get rid of some extra spaces around default arguments.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2523/#review5549 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 7:25 a.m., Gabe Bla

Re: [gem5-dev] Review Request 2521: ps2: Support translating left and right ALT keys.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2521/#review5548 --- Ship it! Ship It! - Nilay Vaish On Nov. 22, 2014, 1:36 p.m., Gabe Bla

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5547 --- What's TLC and CL? - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe Bla

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2520/#review5545 --- Ship it! Seems fine. - Nilay Vaish On Nov. 22, 2014, 1:32 p.m., Gabe

Re: [gem5-dev] Review Request 2519: x86: i8042: Give the keyboard controller a little TLC.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2519/#review5544 --- src/dev/x86/i8042.cc

Re: [gem5-dev] Review Request 2517: x86: vnc: Add a VNC server to x86 systems.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2517/#review5543 --- Ship it! Ship It! - Nilay Vaish On Nov. 22, 2014, 11:39 a.m., Gabe Bl

Re: [gem5-dev] Review Request 2499: mem: Clean up packet data allocation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2499/#review5540 --- src/mem/packet.hh We

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

> On Nov. 25, 2014, 9:52 p.m., Nilay Vaish wrote: > > I don't know what are we trying to achieve by interfacing gem5 and SystemC. > > But the patch seems fine to me. I would think roughly 90% of all the SoC model components in the world are written using SystemC as it is the de facto modeling

Re: [gem5-dev] Review Request 2495: mem: Add checks and explanation for assertMemInhibit usage

> On Nov. 25, 2014, 9:42 p.m., Nilay Vaish wrote: > > src/mem/packet.hh, line 507 > > > > > > I suggest we change the name of this and other such functions from > > assert* to set*. If someone were to tell me just the name

Re: [gem5-dev] Review Request 2516: config: Add options to take/resume from SimPoint checkpoints

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2516/#review5539 --- I suggest the additions being made to the Simulation.py file be made by

Re: [gem5-dev] VNC errors

Looking at the code it looks like it would be possible for there to be <12 bytes in the socket, so the read will return less that 12 bytes (because you got very unlucky and the bytes were split across two packets). Looking at the code fixing that assumption will be a bit of a pain. Ali On 11/

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2503/#review5538 --- Ship it! I don't know what are we trying to achieve by interfacing gem5

Re: [gem5-dev] Review Request 2495: mem: Add checks and explanation for assertMemInhibit usage

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2495/#review5537 --- src/mem/packet.hh I s

Re: [gem5-dev] Review Request 2494: mem: Assume all dynamic packet data is array allocated

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2494/#review5536 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:14 a.m., Andreas

[gem5-dev] GDB reviews

Hi folks. I have a few reviews up for GDB support for x86. It should be tested more since I touched the GDB support for all the other ISAs as well and haven't tested them more than that they still compile. I've tested using GDB to look around a 64 bit x86 kernel a little under the simple atomic and

[gem5-dev] Review Request 2541: sim: Make it possible to override the breakpoint length check.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2541/ --- Review request for Default. Repository: gem5 Description --- Changeset 10569

[gem5-dev] Review Request 2539: cpu: Only check for PC events on instruction boundaries.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2539/ --- Review request for Default. Repository: gem5 Description --- Changeset 10567

[gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2540/ --- Review request for Default. Repository: gem5 Description --- Changeset 10568

[gem5-dev] Review Request 2542: x86: Implement a remote GDB stub.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2542/ --- Review request for Default. Repository: gem5 Description --- Changeset 10570

[gem5-dev] Review Request 2538: misc: Make the GDB register cache accessible in various sized chunks.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2538/ --- Review request for Default. Repository: gem5 Description --- Changeset 10566

[gem5-dev] VNC errors

Hi folks. I've seen VNC related errors a couple of times which look like the following: gem5.opt: build/X86/base/vnc/vncserver.cc:382: void VncServer::checkProtocolVersion(): Assertion `len == 12' failed. Any idea what that's from? It's not annoying enough to spend time digging into it, but it is

[gem5-dev] Cron /z/m5/regression/do-regression quick

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing passed. * build/ALPHA/tests/opt/quick/se/20.eio-short/alpha/eio/simple-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linu

[gem5-dev] Review Request 2537: scons: Ensure dictionary iteration is sorted by key

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2537/ --- Review request for Default. Repository: gem5 Description --- Changeset 10585

[gem5-dev] Review Request 2535: mem: Remove WriteInvalidate support

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2535/ --- Review request for Default. Repository: gem5 Description --- Changeset 10583

[gem5-dev] Review Request 2536: mem: Support WriteInvalidate (again)

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2536/ --- Review request for Default. Repository: gem5 Description --- Changeset 10584

[gem5-dev] Review Request 2533: arm: Fix TLB ignoring faults when table walking

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2533/ --- Review request for Default. Repository: gem5 Description --- Changeset 10580

Re: [gem5-dev] some rough edges on remote GDB support

It looks like the comInstEventQueue will actually help with this quite a bit. It's currently used to stop the simulation after a certain number of instructions, but it can just as easily (I think) be used to trap into GDB after a single instruction, or to get it to break into GDB initially at the n