Re: [gem5-dev] Review Request 2861: sim: Refactor the serialization base class

2015-06-08 Thread Joel Hestness
On June 8, 2015, 2:47 p.m., Joel Hestness wrote: I like that this aims to remove some of the less common checkpoint writing functions. This is a useful step, and I'm largely ok with this change. I've always wondered why we don't explicitly pass Checkpoint to both serialize and

Re: [gem5-dev] Review Request 2844: ruby: Protocol changes for SimObject MessageBuffers

2015-06-08 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2844/ --- (Updated June 8, 2015, 6:52 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2845: ruby: Expose MessageBuffers as SimObjects

2015-06-08 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2845/ --- (Updated June 8, 2015, 6:52 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 2861: sim: Refactor the serialization base class

2015-06-08 Thread Andreas Sandberg
On June 8, 2015, 3:47 p.m., Joel Hestness wrote: I like that this aims to remove some of the less common checkpoint writing functions. This is a useful step, and I'm largely ok with this change. I've always wondered why we don't explicitly pass Checkpoint to both serialize and

[gem5-dev] Review Request 2876: sim: Fix broken event unserialization

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2876/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2877: base: Add serialization support to Pixels and FrameBuffer

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2877/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2879: tests: Skip SPARC tests if the required binaries are missing

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2879/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2878: base, sim: Add support for CircleBuf serialization

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2878/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2880: scons: remove dead leading underscore check

2015-06-08 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2880/ --- Review request for Default. Repository: gem5 Description --- e56c3d8 (2008)

[gem5-dev] Review Request 2870: base: Add a warn_if macro

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2870/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2869: dev, arm: Add a device model that uses the NoMali model

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2869/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2867: ext: Add the NoMali GPU no-simulation library

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2867/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2872: sim: Make the drain state a global typed enum

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2872/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2875: sim: Refactor and simplify the drain API

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2875/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2871: python: Remove redundant drain when changing memory modes

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2873: sim: Move mem(Writeback|Invalidate) to SimObject

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2873/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

2015-06-08 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2861: sim: Refactor the serialization base class

2015-06-08 Thread Joel Hestness
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2861/#review6474 --- I like that this aims to remove some of the less common checkpoint

Re: [gem5-dev] Review Request 2861: sim: Refactor the serialization base class

2015-06-08 Thread Andreas Sandberg
On June 8, 2015, 3:47 p.m., Joel Hestness wrote: I like that this aims to remove some of the less common checkpoint writing functions. This is a useful step, and I'm largely ok with this change. I've always wondered why we don't explicitly pass Checkpoint to both serialize and