[gem5-dev] Review Request 3235: stats: make sim_insts and sim_ops respect stats reset

2015-11-23 Thread Lena Olson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3235/ --- Review request for Default. Repository: gem5 Description --- Changeset 11229

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

2015-11-23 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7637 --- Thanks for updating the review. I think the overall design is good, but t

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

2015-11-23 Thread Boris Shingarov
> On Nov. 20, 2015, 9:32 a.m., Andreas Sandberg wrote: > > Looks like a good design to me. I'm currently testing it in aarch32 and it > > seems to work. There are a couple of nits below, but the code looks good > > overall. > > > > There is one ARM-specific high-level issues that you will need

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

2015-11-23 Thread Boris Shingarov
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- (Updated Nov. 23, 2015, 9:09 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3225: power: remote GDB: rationalize structure of register offsets

2015-11-23 Thread Boris Shingarov
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3225/ --- (Updated Nov. 23, 2015, 9:07 p.m.) Review request for Default. Changes --- M

Re: [gem5-dev] Review Request 3101: DrainManager/Checkpoint changes in SystemC coupling

2015-11-23 Thread Andrew Bardsley
On Sept. 10, 2015, 4:20 p.m., Abdul Mutaal Ahmad wrote: > > As you already mentioned, restoring from a checkpoint probably doesn't > > work. Looks good other than that. I'm Ok with this change if you add a > > warning when restoring from checkpoints, but please fix checkpointing in a > > separ

Re: [gem5-dev] Review Request 3101: DrainManager/Checkpoint changes in SystemC coupling

2015-11-23 Thread Andrew Bardsley
On Sept. 10, 2015, 4:20 p.m., Abdul Mutaal Ahmad wrote: > > As you already mentioned, restoring from a checkpoint probably doesn't > > work. Looks good other than that. I'm Ok with this change if you add a > > warning when restoring from checkpoints, but please fix checkpointing in a > > separ