Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-10 Thread Mohammad Alian
I think I messed up things when I posted the revisions. However, I believe I have fixed the issues that you have pointed out. Sorry about the inconvenience. Thanks, Mohammad On Sun, Jan 10, 2016 at 11:58 PM, Mohammad Alian wrote: > This is an automatically generated e-mail. To reply, visit: > h

Re: [gem5-dev] Review Request 3231: dist: config file for distributed switch

2016-01-10 Thread Mohammad Alian
> On Jan. 8, 2016, 7:10 p.m., Andreas Hansson wrote: > > The description should be <80 char lines. I am also not sure about the > > license header. Is it intentionally the "extended" BSD rather than just the > > plain BSD? > > Mohammad Alian wrote: > I fixed the description. Regarding the

Re: [gem5-dev] Review Request 3231: dist: config file for distributed switch

2016-01-10 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3231/ --- (Updated Jan. 11, 2016, 6:09 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3231: dist: config file for distributed switch

2016-01-10 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3231/ --- (Updated Jan. 11, 2016, 6:07 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-10 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/ --- (Updated Jan. 11, 2016, 5:58 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-10 Thread Mohammad Alian
> On Jan. 8, 2016, 5:22 p.m., Andreas Hansson wrote: > > src/dev/etherswitch.cc, line 529 > > > > > > This is not a very nice way to design things... > > > > It would be much better if this module was event based. I

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-10 Thread Mohammad Alian
> On Jan. 8, 2016, 5:29 p.m., Tony Gutierrez wrote: > > src/dev/Ethernet.py, line 88 > > > > > > Does 1Gbps as the default make sense? I think that is a little dated, > > particularly in the case of the systems multi/pd gem5

Re: [gem5-dev] Review Request 3230: dist, dev: add an ethernet switch model

2016-01-10 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/ --- (Updated Jan. 11, 2016, 5:47 a.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3230: [mq]: rb3230.patch

2016-01-10 Thread Mohammad Alian
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3230/ --- (Updated Jan. 11, 2016, 5:27 a.m.) Review request for Default. Summary (updated)

[gem5-dev] Cron /z/m5/regression/do-regression --scratch all

2016-01-10 Thread Cron Daemon
* build/SPARC/tests/opt/long/fs/80.solaris-boot/sparc/solaris/t1000-simple-atomic FAILED! scons: *** Error 134 * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby passed. * build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-timing passed. * build/ALPH