Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On oct. 18, 2016, 1:55 après-midi, Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > > > > > Rather than having an extra parameter, could you make a subclass of the > > BigCluster? If this would

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:45 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:35 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8939 --- Ship it! Ship It! - Steve Reinhardt On Oct. 19, 2016, 3:30 p.m., Bran

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8938 --- Ship it! Yes, thanks! - Steve Reinhardt On Oct. 19, 2016, 12:27 p.m.,

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 19, 2016, 10:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/ --- (Updated Oct. 19, 2016, 10:25 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8937 --- Ship it! Thanks for the change! - Jason Lowe-Power On Oct. 19, 2016,

Re: [gem5-dev] Review Request 3677: syscall_emul: [patch 11/22] extend functionality of fcntl

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3677/#review8936 --- So do the flag values vary across ISAs/OSes? If not, there's no reason to

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review8934 --- src/sim/fd_array.hh (line 65)

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

> On Oct. 17, 2016, 10:25 p.m., Jason Lowe-Power wrote: > > src/sim/process.cc, line 593 > > > > > > Any reason not to move this code into ProcessParams::create(), and > > eliminate this static function? > > Brandon Potter

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/ --- (Updated Oct. 19, 2016, 7:27 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3674/#review8933 --- src/sim/aux_vector.hh (line 2)

Re: [gem5-dev] Review Request 3673: syscall_emul: [patch 7/22] remove numCpus method

> On Oct. 18, 2016, 8:42 a.m., Jason Lowe-Power wrote: > > This is fine with me how it is. However, it's kind of moot if we're > > removing ALPHA support. > > Brandon Potter wrote: > Yeah, I am waiting to see if that materializes. If it does, I'll change > the patch to remove the numCpus m

Re: [gem5-dev] Review Request 3672: syscall_emul: [patch 6/22] remove unused fields from Process class

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3672/#review8931 --- Ship it! All that NXM support could probably go away at some point. We s

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review8930 --- I agree that it's dumb to have two PIDs in the Process object, but until

Re: [gem5-dev] Review Request 3643: style: [patch 3/22] reduce include dependencies in some headers

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3643/#review8929 --- Ship it! Ship It! - Steve Reinhardt On Oct. 17, 2016, 8:12 a.m., Bran

Re: [gem5-dev] Review Request 3660: style: [patch 1/22] use /r/3648/ to reorganize includes

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3660/#review8928 --- Ship it! Ship It! - Steve Reinhardt On Oct. 17, 2016, 8:07 a.m., Bran

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3662/#review8927 --- src/sim/syscall_desc.hh (line 67)

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/#review8926 --- Ship it! Ship It! - Steve Reinhardt On Oct. 17, 2016, 8:25 a.m., Bran

Re: [gem5-dev] Review Request 3662: syscall_emul: [patch 2/22] move SyscallDesc into its own .hh and .cc

> On Oct. 11, 2016, 4:43 p.m., Tony Gutierrez wrote: > > src/sim/syscall_desc.hh, line 66 > > > > > > (void) is not necessary in c++. also this is not gem5 convention. > > Brandon Potter wrote: > I tried to get the same

Re: [gem5-dev] Review Request 3622: Prefetch: Do not prefetch on cache & MSHR misses

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3622/#review8924 --- Interesting. This seems a problem worth correcting, but I fail to see how

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

> On Oct. 17, 2016, 3:25 p.m., Jason Lowe-Power wrote: > > Seems reasonable to me, but do we have any historical context for > > "LiveProcess"? > > > > Couple of small things below. > > Brandon Potter wrote: > I do not know about the historical context for LiveProcess. This is > speculati

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > > > > > Rather than having an extra parameter, could you make a subclass of the > > BigCluster? If this would introd

[gem5-dev] changeset in gem5: stats: Update stats to reflect recent changes...

changeset b3d5f0e9e258 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b3d5f0e9e258 description: stats: Update stats to reflect recent changes to floats Mostly just splitting out the floats ops and corresponding reads/writes. diffstat: tests/long/fs

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/#review8921 --- Ship it! Ship It! - Andreas Sandberg On Oct. 12, 2016, 4:50 p.m., Mic

Re: [gem5-dev] Review Request 3665: arm, config: Enabled MemConfig usage for the example big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3665/#review8920 --- Ship it! Ship It! - Andreas Sandberg On Oct. 19, 2016, 4:41 a.m., Ana

[gem5-dev] Cron /z/m5/regression/do-regression quick

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: CHANGED!* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: CHANGED!*** stat_diff: FAILURE: Statistics mismatchStatistics mismatch * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: