Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review9272 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 17, 2016, 3:14 p.m., Bra

Re: [gem5-dev] Review Request 3670: syscall_emul: [patch 4/22] remove redundant M5_pid field from process

2017-01-18 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3670/#review9271 --- Ship it! Ship It! - Tony Gutierrez On Oct. 17, 2016, 8:14 a.m., Brand

Re: [gem5-dev] Review Request 3784: sim,kvm,arm: fix typos

2017-01-18 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3784/#review9270 --- Ship it! Ship It! - Tony Gutierrez On Jan. 17, 2017, 2:04 p.m., Curti

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Jason Lowe-Power
> On Jan. 18, 2017, 3:21 p.m., Jason Lowe-Power wrote: > > While you're on this code, I have a question. Maybe Andreas H. can answer > > too. Why are all of the configurations for the memory controllers in > > src/mem/DRAMCtrl.py? They could all be in configs/dram_ctrls/*.py, right? > > > > It

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Matthew Poremba
> On Jan. 18, 2017, 3:21 p.m., Jason Lowe-Power wrote: > > While you're on this code, I have a question. Maybe Andreas H. can answer > > too. Why are all of the configurations for the memory controllers in > > src/mem/DRAMCtrl.py? They could all be in configs/dram_ctrls/*.py, right? > > > > It

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/#review9267 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 18, 2017, 5:39 p.m., Ale

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-18 Thread Alec Roelke
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/ --- (Updated Jan. 18, 2017, 5:39 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3778: Fix order of object construction in the CxxConfigManager

2017-01-18 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3778/#review9266 --- Ship it! Tested this and saving/loading checkpoints still seems to work

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-18 Thread Jason Lowe-Power
> On Jan. 18, 2017, 4:06 p.m., Jason Lowe-Power wrote: > > src/arch/riscv/process.cc, line 222 > > > > > > Two comments: > > 1. Shouldn't this at least have a warning? If the syscall arg register > > > 3 there is defini

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-18 Thread Jason Lowe-Power
> On Jan. 18, 2017, 4:04 p.m., Jason Lowe-Power wrote: > > tests/test-progs/insttest/src/riscv/rv64i.cpp, line 238 > > > > > > Can you block-comment instead of delete? I think we'll want to add this > > back in sometime in

Re: [gem5-dev] Review Request 2691: mem: implement x86 locked accesses in timing-mode classic cache

2017-01-18 Thread Tony Gutierrez
> On Jan. 5, 2017, 8:32 a.m., Tony Gutierrez wrote: > > Is there anything holding this up from being shipped? > > Andreas Hansson wrote: > In my view the patch needs two things: > > 1) Some thought around the design. I am still hoping there is a less > invasive way of accommodating

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-18 Thread Alec Roelke
> On Jan. 18, 2017, 4:06 p.m., Jason Lowe-Power wrote: > > src/arch/riscv/process.cc, line 222 > > > > > > Two comments: > > 1. Shouldn't this at least have a warning? If the syscall arg register > > > 3 there is defini

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-18 Thread Alec Roelke
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/ --- (Updated Jan. 18, 2017, 4:42 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3781: riscv: Remove ECALL tests from insttest

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9260 --- Ship it! tests/test-progs/insttest/src/riscv/rv64i.cpp

Re: [gem5-dev] Review Request 3780: riscv: Fix crash when syscall argument reg index is too high

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3780/#review9261 --- src/arch/riscv/process.cc (line 222)

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Andreas Hansson
Hi Jason, I don’t see a reason why it could not be refactored as you suggest. Definitely something to consider going forward. Andreas On 18/01/2017, 07:21, "gem5-dev on behalf of Jason Lowe-Power" wrote: > >--- >This is an automatically g

Re: [gem5-dev] Review Request 3785: sim, kvm: make KvmVM a System parameter

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3785/#review9259 --- Is there any way you can remove the #if USE_KVM from the system.cc file?

Re: [gem5-dev] Review Request 3786: arm, kvm: implement MuxingKvmGic

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3786/#review9256 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Cu

Re: [gem5-dev] Review Request 3788: arm, kvm: remove KvmGic

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3788/#review9258 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Cu

Re: [gem5-dev] Review Request 3787: arm, kvm: Automatically use the MuxingKvmGic

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3787/#review9257 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Cu

Re: [gem5-dev] Review Request 3784: sim,kvm,arm: fix typos

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3784/#review9255 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 17, 2017, 10:04 p.m., Cu

Re: [gem5-dev] Review Request 3783: mem: Update DRAM configuration names

2017-01-18 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3783/#review9254 --- Ship it! While you're on this code, I have a question. Maybe Andreas H.

[gem5-dev] Cron /z/m5/regression/do-regression quick

2017-01-18 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/l