Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
Great! Thanks Jason. On 15/02/2017, 21:06, "gem5-dev on behalf of Jason Lowe-Power" wrote: >I just pushed the other patch. > >Cheers, >Jason > >On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter >wrote: > >> This

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Jason Lowe-Power
I just pushed the other patch. Cheers, Jason On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter wrote: > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3813/ > > On February 15th, 2017, 8:46 p.m. UTC, *Jason Lowe-Power* wrote: > >

[gem5-dev] changeset in gem5: mem, stats: fix typos in CommMonitor and Stats

2017-02-15 Thread Pierre-Yves Péneau
changeset f438fcbab00e in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=f438fcbab00e description: mem, stats: fix typos in CommMonitor and Stats Signed-off-by: Pierre-Yves Péneau Reviewed-by: Tony Gutierrez

[gem5-dev] changeset in gem5: mem, misc: fix building issue with CommMonito...

2017-02-15 Thread Pierre-Yves Péneau
changeset 22d08b519cb0 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=22d08b519cb0 description: mem, misc: fix building issue with CommMonitor (unused variables) Signed-off-by: Pierre-Yves Péneau Reviewed-by: Andreas

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Brandon Potter
> On Feb. 15, 2017, 8:46 p.m., Jason Lowe-Power wrote: > > Same as http://reviews.gem5.org/r/3801? Thanks for pointing that out; I hadn't noticed the other review. I'll close this one, but can we ship the other patch now that it has several ShipIts? - Brandon

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
> On Feb. 15, 2017, 8:46 p.m., Andreas Hansson wrote: > > It's not the third time this is resolved :-) > > > > http://reviews.gem5.org/r/3801/ > > > > Jason, is there any chance you could push the aforementioned patch? s/not/now/ - Andreas

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3813/#review9430 --- It's not the third time this is resolved :-)

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3813/#review9429 --- Same as http://reviews.gem5.org/r/3801? - Jason Lowe-Power On Feb.

[gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

2017-02-15 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3813/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3806: sparc: fix bugs caused by cd7f3a1dbf55

2017-02-15 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3806/#review9428 --- Ship it! Ship It! - Tony Gutierrez On Feb. 10, 2017, 12:31 p.m.,

[gem5-dev] changeset in gem5: mem: fix assertion in respondEvent

2017-02-15 Thread Wendy Elsasser
changeset b9436a49 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=b9436a49 description: mem: fix assertion in respondEvent Assertion in the respondEvent erroneously fired. The assertion verifies that the controller has not moved to a

Re: [gem5-dev] Thoughts On Project Using C++14

2017-02-15 Thread Jason Lowe-Power
Hi Brandon, I agree with Andreas. It seems to me that it is a little too soon to require GCC 6.1. Until we're confident most people's IT infrastructure is using more recent Linuxes, it's going to be hard to go beyond C++11. Do you have any suggestions on how to make it simple for all of our