Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14520 )
Change subject: systemc: Update the gem5-within-systemc README to mention
USE_SYSTEMC.
..
systemc: Updat
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14656 )
Change subject: util: Add the scons configuration cache to .gitignore for
util/tlm.
..
util: Add the sco
Giacomo Travaglini has uploaded a new patch set (#17) to the change
originally created by Giacomo Gabrielli. (
https://gem5-review.googlesource.com/c/public/gem5/+/13127 )
Change subject: base: Iterable CircularQueue implementation
.
Hello Nikos Nikoleris, Ciro Santilli,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14695
to review the following change.
Change subject: ext: Import googlemock, release version 1.8.0
...
I would recommend using _test.cc, and then just prevent any other class from
being named as _test.cc.
This is also the recommendation of the Google C++ style guide:
https://google.github.io/styleguide/cppguide.html#File_Names
Conceptually, it feels nice as we don't change the simple .cc style w
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14676 )
Change subject: base: Rename unit test cc files to be *.test.cc.
..
base: Rename unit test cc files to be *
Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/14677 )
Change subject: base: Change the unit test binary names to use .test, and
to be consistent.
..
base: Cha
Hello Gabe Black, Jason Lowe-Power, Giacomo Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14497
to look at the new patch set (#5).
Change subject: base: increase the GDB buffer size dynamically
..
scons: *** [build/ALPHA/systemc/utils/vcd.do] Error 1
scons: *** [build/MIPS/systemc/utils/vcd.do] Error 1
scons: *** [build/NULL/systemc/utils/vcd.do] Error 1
scons: *** [build/NULL_MOESI_hammer/systemc/utils/vcd.do] Error 1
scons: *** [build/NULL_MESI_Two_Level/systemc/utils/vcd.do] Error 1
scons
Hello Jason Lowe-Power, Nikos Nikoleris, Daniel Carvalho, Giacomo
Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14620
to look at the new patch set (#2).
Change subject: mem-cache: Support for page cross
Giacomo Travaglini has uploaded a new patch set (#18) to the change
originally created by Giacomo Gabrielli. (
https://gem5-review.googlesource.com/c/public/gem5/+/13127 )
Change subject: base: Iterable CircularQueue implementation
.
Hi Chang,
I think it makes sense to wait until EOL of Ubuntu 14.04.
We should consider about fixing the bug then, or to explicitly say in gem5.org
that SYSTEMC has to be disabled in order
to be compliant (which is not the best approach IMO).
Gabe, what's your opinion on this? Can you provide
Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14716
Change subject: mem-cache: Add R/W information to calculateAccessLatency
..
mem-cache: Add R/W information to c
Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14715
Change subject: mem-cache: Add getter and setter to CacheBlk::whenReady
..
mem-cache: Add getter and setter to
Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14717
Change subject: mem-cache: Add parameter for tag-only access
..
mem-cache: Add parameter for tag-only access
I
Hello Giacomo Travaglini, Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14735
to review the following change.
Change subject: mem-cache: allow prefetchers to emit page crossing
references
..
Hello Jason Lowe-Power, Nikos Nikoleris, Daniel Carvalho, Giacomo
Travaglini, Andreas Sandberg,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14620
to look at the new patch set (#3).
Change subject: mem-cache: Support for page cross
Daniel Carvalho has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14736
Change subject: mem-cache: Fix recvTimingReq doWritebacks tick
..
mem-cache: Fix recvTimingReq doWritebacks tic
Hello Giacomo Travaglini, Andreas Sandberg,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/14737
to review the following change.
Change subject: mem-cache: Signature Path Prefetcher
..
Hey Gabe,
Are you thinking that a custom allocator would make a difference in terms
of memory footprint or in terms of performance (or both)?
A couple of thoughts:
- I'm hesitant to put the final keyword on Packet. I think we could see
some code cleanup by making Packet a polymorphic object (e.g.
I advocate for explicitly stating that SystemC should be disabled for gcc <
5.0 and making this change in the SConscript with a warning. I don't think
the SystemC support is widely used right now, and few people are stuck on
4.8, so I doubt it will affect anyone. We can even include a link to the
g
Hey all,
The bigger opportunity is probably around packets as sometimes we are
allocating a number of them per request.
A custom allocator would be a great contribution if it would make gem5
substantially faster. But if it proved make things only marginally
better, I agree with Jason, we would ne
Hello,
Polymorphism could provide a good cleanup (Just random possibilities/examples:
Split between source types (CPU, Mem, GPU...), or between cmd types), but maybe
it is unrealistic, since these classes are all over. Regarding compressed
packets, they would still be "easily" implemented wit
I looked at the code as is, and Packets themselves aren't ever inherited by
anything, and they maintain a stack (I think) of sender state objects which
doesn't affect the size of the packet. The sender state is inherited in a
bunch of places since that is often customized. As far as compressed
pack
Sorry I missed this before I checked in the changes I had. That might make
sense if files consistently used _ in their names, but unfortunately they
don't. I also think it's a little cleaner to have a separate namespace
entirely for things rather than avoiding conflicts by being careful,
although p
I commented on the CL if we decide to check it in. I'm not 100% sure what's
best, but the more I think about it the more I tend to agree with Jason.
That would probably be the least invasive thing to do, given its temporary
nature. It would be a bit awkward and clunky for anybody that hits it, but
Gabe, can you put a patch together real fast that disables SystemC for gcc
< 5?
If not, I should be able to do it tomorrow.
Jason
On Thu, Nov 29, 2018 at 4:06 PM Gabe Black wrote:
> I commented on the CL if we decide to check it in. I'm not 100% sure what's
> best, but the more I think about i
Couple more comments below.
On Thu, Nov 29, 2018 at 3:08 PM Gabe Black wrote:
> I looked at the code as is, and Packets themselves aren't ever inherited by
> anything, and they maintain a stack (I think) of sender state objects which
> doesn't affect the size of the packet. The sender state is i
Yes, although I don't have a version of gcc old enough to really test it
thoroughly. I might try to fake it by setting the cutoff really high for
testing purposes.
Gabe
On Thu, Nov 29, 2018 at 5:09 PM Jason Lowe-Power
wrote:
> Gabe, can you put a patch together real fast that disables SystemC f
Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/14755
Change subject: systemc: Disable systemc when using gcc versions older than
5.0.
..
systemc: Disable systemc when
>
> As a side note, tcmalloc has bitten me a number of times here. I've run
> valgind with tcmalloc and seen "0 bytes allocated and 0 bytes deleted"
> after waiting for hours too many times. I have finally learned to recompile
> everything using "--without-tcmalloc" before running valgind.
>
>
Yeah
31 matches
Mail list logo
