Re: [gem5-dev] commit message thrown away because of bad tag

It is thrown away if you then attempt to create another commit, assuming the first one went worked, overwriting COMMIT_EDITMSG. Then when I wrote the message again it failed again, and then I ran git commit trying to figure out what happened, and the COMMIT_EDITMSG was thrown away again. There is a

[gem5-dev] Change in gem5/gem5[master]: arch: Add a bunch of missing override specifiers.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25223 ) Change subject: arch: Add a bunch of missing override specifiers. .. arch: Add a bunch of missing override specifi

[gem5-dev] Change in gem5/gem5[master]: scons: Disable some warnings in clang.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25229 ) Change subject: scons: Disable some warnings in clang. .. scons: Disable some warnings in clang. The defaulted-fu

[gem5-dev] Change in gem5/gem5[master]: mem: Use using to expose a print() method that would otherwise be hid...

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25227 ) Change subject: mem: Use using to expose a print() method that would otherwise be hiddne. .. mem: Use using to

[gem5-dev] Change in gem5/gem5[master]: arm: Fix how a bitfield is extracted in some SVE instructions.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25224 ) Change subject: arm: Fix how a bitfield is extracted in some SVE instructions. .. arm: Fix how a bitfield is ex

[gem5-dev] Change in gem5/gem5[master]: ext: Disable the unused-value warning in clang for pybind.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25228 ) Change subject: ext: Disable the unused-value warning in clang for pybind. .. ext: Disable the unused-value warnin

[gem5-dev] Change in gem5/gem5[master]: riscv: Cast to float explicitly when comparing a float to an int.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25225 ) Change subject: riscv: Cast to float explicitly when comparing a float to an int. .. riscv: Cast to float expli

[gem5-dev] Change in gem5/gem5[master]: base: Use a const auto & in a range based for loop.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/25226 ) Change subject: base: Use a const auto & in a range based for loop. .. base: Use a const auto & in a range based f

Re: [gem5-dev] commit message thrown away because of bad tag

Gabe, Commit messages are not thrown away but are instead stored in "./.git/COMMIT_EDITMSG" if rejected. Perhaps this should be explicitly stated when a commit message is rejected. As you may already be aware, this is a result of Daniel's (relatively) new git commit message checks: https://gem5.g

Re: [gem5-dev] commit message thrown away because of bad tag

I think until this changes, --no-verify is going to become a permanent fixture of my commit command line. Gabe On Sun, Feb 9, 2020 at 7:20 PM Gabe Black wrote: > Hi folks. I just spent 10 minutes writing up a commit message, only for it > to be thrown away because git didn't like the tag I had

[gem5-dev] commit message thrown away because of bad tag

Hi folks. I just spent 10 minutes writing up a commit message, only for it to be thrown away because git didn't like the tag I had which I've used many times (arm). This is a really bad experience and IMHO not how this should be done. I believe at the time this change was introduced I pointed out

[gem5-dev] Change in gem5/gem5[master]: systemc: gem5_to_tlm: treat non-rw as ignorable command

Earl Ou has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/25163 ) Change subject: systemc: gem5_to_tlm: treat non-rw as ignorable command .. systemc: gem5_to_tlm: treat non-rw as ignorable comma