[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: fix incorrect interrupt checking logic

2021-01-12 Thread Cui Jin (Gerrit) via gem5-dev
Cui Jin has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39035 ) Change subject: arch-riscv: fix incorrect interrupt checking logic .. arch-riscv: fix incorrect interrupt checking

[gem5-dev] Change in gem5/gem5[develop]: base: Remove begin() and end() from CircleBuf.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38998 ) Change subject: base: Remove begin() and end() from CircleBuf. .. base: Remove begin() and end() from CircleBuf. These

[gem5-dev] IWYU tool and include checking from scons

2021-01-12 Thread Gabe Black via gem5-dev
Hi folks. Daniel has submitted a big change which fixes up a bunch of missing includes in files which were coincidentally getting the definitions they needed indirectly from some other file. Way down the line in c++20 I think the "modules" mechanism would be a great tool avoiding these sorts of

[gem5-dev] Change in gem5/gem5[develop]: dev: Use regular atomic accesses for DMA in bypass mode.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38720 ) Change subject: dev: Use regular atomic accesses for DMA in bypass mode. .. dev: Use regular atomic accesses for DMA in

[gem5-dev] Change in gem5/gem5[develop]: dev: Teach the DmaPort to use atomic memory backdoors.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38719 ) Change subject: dev: Teach the DmaPort to use atomic memory backdoors. .. dev: Teach the DmaPort to use atomic memory

[gem5-dev] Change in gem5/gem5[develop]: dev: Generate DMA packets as needed.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38717 ) Change subject: dev: Generate DMA packets as needed. .. dev: Generate DMA packets as needed. Instead of generating all of

[gem5-dev] Change in gem5/gem5[develop]: base: Re-implement CircleBuf without using CircularQueue.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/38896 ) Change subject: base: Re-implement CircleBuf without using CircularQueue. .. base: Re-implement CircleBuf without using

[gem5-dev] Re: Testing fail on GCN3_X86 on Arm machine

2021-01-12 Thread Poremba, Matthew via gem5-dev
[AMD Public Use] The defines causing an error seem to be set in the HSA header file itself but only for x86 type hosts. I'm hesitant to change this since it is pulled directly, unmodified, from the AMD HSA runtime repo including license, etc. However, we might be able to do some scons magic to

[gem5-dev] Change in gem5/gem5[develop]: misc: Fix coding style for class-opening braces

2021-01-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
Daniel Carvalho has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39015 ) Change subject: misc: Fix coding style for class-opening braces .. misc: Fix coding style for class-opening

[gem5-dev] Change in gem5/gem5[develop]: util: Add verifier for opening braces of classes

2021-01-12 Thread Daniel Carvalho (Gerrit) via gem5-dev
Daniel Carvalho has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/39016 ) Change subject: util: Add verifier for opening braces of classes .. util: Add verifier for opening braces of

[gem5-dev] Re: Testing fail on GCN3_X86 on Arm machine

2021-01-12 Thread Bobby Bruce via gem5-dev
I'm guessing you're correct and this is because you're testing on an ARM machine. GCN3_X86 should compile fine, though we don't test on ARM hosts (we'd like to change this soon). I've added a Jira ticket covering this bug: https://gem5.atlassian.net/browse/GEM5-881. -- Dr. Bobby R. Bruce Room

[gem5-dev] Change in gem5/gem5[develop]: base: Remove begin() and end() from CircleBuf.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/38998 ) Change subject: base: Remove begin() and end() from CircleBuf. .. base: Remove begin() and end() from CircleBuf.

[gem5-dev] Re: Testing fail on GCN3_X86 on Arm machine

2021-01-12 Thread Nathanael Premillieu via gem5-dev
Hi, Thanks Jason and Matt for your answers. I’m not really interested in GCN3, it’s just that it is tested by default when running all the tests. And as I’m working on a change that is not specific to a particular architecture, I wanted to test it on everything. For the moment I have relaunched

[gem5-dev] Change in gem5/gem5[develop]: sim: Break the eventq.hh dependency in core.hh.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/38996 ) Change subject: sim: Break the eventq.hh dependency in core.hh. .. sim: Break the eventq.hh dependency in

[gem5-dev] Change in gem5/gem5[develop]: base: Remove the curTick prototype from base/statistics.hh.

2021-01-12 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/38997 ) Change subject: base: Remove the curTick prototype from base/statistics.hh. .. base: Remove the curTick prototype