Attention is currently required from: Andreas Sandberg, Bobby R. Bruce,
Jason Lowe-Power.
Hello Andreas Sandberg, kokoro, Bobby R. Bruce, Jason Lowe-Power,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/42013
to review the following change.
Change subject: Revert "python: Add search functions to pystats groups"
......................................................................
Revert "python: Add search functions to pystats groups"
This reverts commit 649e5cd8e04d38bcab9227f8ff7c520bbe12d228.
Reason for revert: Rebase error
Change-Id: I28fc102e552334f28a271516bbc39d562caab299
---
M src/python/m5/ext/pystats/group.py
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/src/python/m5/ext/pystats/group.py
b/src/python/m5/ext/pystats/group.py
index 10887e2..41a5633 100644
--- a/src/python/m5/ext/pystats/group.py
+++ b/src/python/m5/ext/pystats/group.py
@@ -24,7 +24,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-from typing import Dict, Iterator, List, Optional, Union
+from typing import Dict, List, Optional, Union
from .jsonserializable import JsonSerializable
from .statistic import Scalar, Statistic
@@ -53,26 +53,6 @@
for key,value in kwargs.items():
setattr(self, key, value)
- def find(self, name: str) -> Iterator[Union["Group", Statistic]]:
- """ Find all stats that match the name
- This function searches all of the "children" in this group. It
yields
- the set of attributes (children) that have the `name` as a
substring.
- The order of the objects returned by the generator is arbitrary.
- ```
- system.find('cpu') -> [cpu0, cpu1, cpu2, cpu3, other_cpu, ...]
- ```
- This is useful for performing aggregates over substats. For
instance:
- ```
- total_instruuctions = sum([cpu.exec_context.thread_0.numInsts.value
- for cpu in simstat.system.find('cpu')])
- ```
- """
- for attr in self.__dict__:
- if name in attr:
- obj = getattr(self, attr)
- if isinstance(obj, Group) or isinstance(obj, Statistic):
- yield obj
-
class Vector(Group):
"""
The Vector class is used to store vector information. However, in gem5
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42013
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I28fc102e552334f28a271516bbc39d562caab299
Gerrit-Change-Number: 42013
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-Attention: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Attention: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Attention: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
