Matthew Poremba has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/58471 )
Change subject: dev-amdgpu: Update comment point to ROCK repository
......................................................................
dev-amdgpu: Update comment point to ROCK repository
It seems the tag name was changed which broke a few links in some
comments pointing to where definitions and struct come from. Update the
URLs and also use consistent version.
Change-Id: I7d6393f1f08d592989999a8a6f9c5bbdf1a9c992
---
M src/dev/amdgpu/amdgpu_vm.hh
M src/dev/amdgpu/ih_mmio.hh
M src/dev/amdgpu/interrupt_handler.hh
M src/dev/amdgpu/pm4_queues.hh
M src/dev/amdgpu/sdma_commands.hh
M src/dev/amdgpu/sdma_mmio.hh
6 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/src/dev/amdgpu/amdgpu_vm.hh b/src/dev/amdgpu/amdgpu_vm.hh
index e16975b..8df169b 100644
--- a/src/dev/amdgpu/amdgpu_vm.hh
+++ b/src/dev/amdgpu/amdgpu_vm.hh
@@ -45,9 +45,9 @@
* MMIO offsets for graphics register bus manager (GRBM). These values were
* taken from linux header files. The header files can be found here:
*
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.2.0/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/ asic_reg/gc/gc_9_0_offset.h
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.2.0/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/ asic_reg/mmhub/mmhub_1_0_offset.h
*/
diff --git a/src/dev/amdgpu/ih_mmio.hh b/src/dev/amdgpu/ih_mmio.hh
index c7e94fd..b0c1e45 100644
--- a/src/dev/amdgpu/ih_mmio.hh
+++ b/src/dev/amdgpu/ih_mmio.hh
@@ -36,7 +36,7 @@
* MMIO offsets for interrupt handler. These values were taken from the
linux
* header for IH. The header files can be found here:
*
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.3.x/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/asic_reg/oss/osssys_4_0_offset.h
*/
#define mmIH_RB_CNTL 0x0080
diff --git a/src/dev/amdgpu/interrupt_handler.hh
b/src/dev/amdgpu/interrupt_handler.hh
index 1b38dc3..fcf1076 100644
--- a/src/dev/amdgpu/interrupt_handler.hh
+++ b/src/dev/amdgpu/interrupt_handler.hh
@@ -50,7 +50,7 @@
/**
* Defines from driver code. Taken from
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.2.0/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/soc15_ih_clientid.h
*/
enum soc15_ih_clientid
diff --git a/src/dev/amdgpu/pm4_queues.hh b/src/dev/amdgpu/pm4_queues.hh
index 4af5e30..4e8638b 100644
--- a/src/dev/amdgpu/pm4_queues.hh
+++ b/src/dev/amdgpu/pm4_queues.hh
@@ -38,7 +38,7 @@
/**
* Queue descriptor with relevant MQD attributes. Taken from
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.3.x/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/v9_structs.h
*/
typedef struct GEM5_PACKED
@@ -186,7 +186,7 @@
/**
* Queue descriptor for SDMA-based user queues (RLC queues). Taken from
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.2.0/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/v9_structs.h
*/
typedef struct GEM5_PACKED
diff --git a/src/dev/amdgpu/sdma_commands.hh
b/src/dev/amdgpu/sdma_commands.hh
index c5eebf9..50f942b 100644
--- a/src/dev/amdgpu/sdma_commands.hh
+++ b/src/dev/amdgpu/sdma_commands.hh
@@ -35,7 +35,7 @@
/**
* Commands for the SDMA engine. The header files can be found here:
*
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.3.x/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/amdgpu/vega10_sdma_pkt_open.h
*/
#define SDMA_OP_NOP 0
diff --git a/src/dev/amdgpu/sdma_mmio.hh b/src/dev/amdgpu/sdma_mmio.hh
index a10682f..a87bfb8 100644
--- a/src/dev/amdgpu/sdma_mmio.hh
+++ b/src/dev/amdgpu/sdma_mmio.hh
@@ -36,9 +36,9 @@
* MMIO offsets for SDMA engine. These values were taken from the linux
header
* for SDMA. The header files can be found here:
*
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.3.x/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/asic_reg/sdma0/sdma0_4_0_offset.h
- * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/rocm-4.3.x/
+ * https://github.com/RadeonOpenCompute/ROCK-Kernel-Driver/blob/roc-4.3.x/
* drivers/gpu/drm/amd/include/asic_reg/sdma1/sdma1_4_0_offset.h
*/
#define mmSDMA_GFX_RB_CNTL 0x0080
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58471
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7d6393f1f08d592989999a8a6f9c5bbdf1a9c992
Gerrit-Change-Number: 58471
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
