Matthew Poremba has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/55543 )
Change subject: mem-ruby: Remove probe dest assert in MOESI_AMD_Base
......................................................................
mem-ruby: Remove probe dest assert in MOESI_AMD_Base
This asserts that there is at least one destination for a probe when
sending an invalidation or shared probe from the directory to coherence
end points in the protocol (TCC, LLC). This is not necessarily required
and for certain configurations there will be no probes required and none
will be sent. One such configuration is the GPU protocol tester which
would not require a probe to the CPU if it does not exist.
Change-Id: If016f457cb8c9e0277a910ac2c3f315c25b50ce8
---
M src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
b/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
index e44d8db..d7a29f2 100644
--- a/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
+++ b/src/mem/ruby/protocol/MOESI_AMD_Base-dir.sm
@@ -678,7 +678,6 @@
APPEND_TRANSITION_COMMENT(" dc: Acks remaining: ");
APPEND_TRANSITION_COMMENT(tbe.NumPendingAcks);
tbe.ProbeRequestStartTime := curCycle();
- assert(out_msg.Destination.count() > 0);
}
}
}
@@ -720,7 +719,6 @@
APPEND_TRANSITION_COMMENT(" dc: Acks remaining: ");
APPEND_TRANSITION_COMMENT(tbe.NumPendingAcks);
tbe.ProbeRequestStartTime := curCycle();
- assert(out_msg.Destination.count() > 0);
}
}
}
@@ -759,7 +757,6 @@
APPEND_TRANSITION_COMMENT(" sc: Acks remaining: ");
APPEND_TRANSITION_COMMENT(tbe.NumPendingAcks);
tbe.ProbeRequestStartTime := curCycle();
- assert(out_msg.Destination.count() > 0);
}
}
}
@@ -800,7 +797,6 @@
APPEND_TRANSITION_COMMENT(" sc: Acks remaining: ");
APPEND_TRANSITION_COMMENT(tbe.NumPendingAcks);
tbe.ProbeRequestStartTime := curCycle();
- assert(out_msg.Destination.count() > 0);
}
}
}
@@ -841,7 +837,6 @@
APPEND_TRANSITION_COMMENT(tbe.NumPendingAcks);
DPRINTF(RubySlicc, "%s\n", out_msg);
tbe.ProbeRequestStartTime := curCycle();
- assert(out_msg.Destination.count() > 0);
}
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55543
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If016f457cb8c9e0277a910ac2c3f315c25b50ce8
Gerrit-Change-Number: 55543
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
