Hello Anthony Gutierrez, Jason Lowe-Power, Giacomo Travaglini,

I'd like you to reexamine a change. Please visit

    https://gem5-review.googlesource.com/c/public/gem5/+/16950

to look at the new patch set (#4).

Change subject: cpu: Added namespace to O3 Cpu Model
......................................................................

cpu: Added namespace to O3 Cpu Model

The O3 cpu folder doesn't offer a namespace implementation like others
model (i.e. Simple).
This lack of a proper namespace creates a conflict if a new O3-like cpu
model is added, preventing the reuse of typical O3-related keyword names
for classes and structures.

FUPool is renamed to O3FUPool according to the other o3 objects.
Classes used as a parameter (params/*.hh) are defined out of the O3
namespace due to their global scope when created at compile time.

Change-Id: I4a9ce60b94937fb8d8fe8d0b35d92819feb7037f
---
M src/cpu/o3/O3CPU.py
R src/cpu/o3/O3FUPool.py
M src/cpu/o3/SConscript
M src/cpu/o3/base_dyn_inst.cc
M src/cpu/o3/checker.cc
M src/cpu/o3/checker.hh
M src/cpu/o3/comm.hh
M src/cpu/o3/commit.cc
M src/cpu/o3/commit.hh
M src/cpu/o3/commit_impl.hh
M src/cpu/o3/cpu.cc
M src/cpu/o3/cpu.hh
M src/cpu/o3/cpu_policy.hh
M src/cpu/o3/decode.cc
M src/cpu/o3/decode.hh
M src/cpu/o3/decode_impl.hh
M src/cpu/o3/dep_graph.hh
M src/cpu/o3/deriv.hh
M src/cpu/o3/dyn_inst.cc
M src/cpu/o3/dyn_inst.hh
M src/cpu/o3/dyn_inst_impl.hh
M src/cpu/o3/fetch.cc
M src/cpu/o3/fetch.hh
M src/cpu/o3/fetch_impl.hh
M src/cpu/o3/free_list.cc
M src/cpu/o3/free_list.hh
M src/cpu/o3/fu_pool.cc
M src/cpu/o3/fu_pool.hh
M src/cpu/o3/iew.cc
M src/cpu/o3/iew.hh
M src/cpu/o3/iew_impl.hh
M src/cpu/o3/impl.hh
M src/cpu/o3/inst_queue.cc
M src/cpu/o3/inst_queue.hh
M src/cpu/o3/inst_queue_impl.hh
M src/cpu/o3/lsq.cc
M src/cpu/o3/lsq.hh
M src/cpu/o3/lsq_impl.hh
M src/cpu/o3/lsq_unit.cc
M src/cpu/o3/lsq_unit.hh
M src/cpu/o3/lsq_unit_impl.hh
M src/cpu/o3/mem_dep_unit.cc
M src/cpu/o3/mem_dep_unit.hh
M src/cpu/o3/mem_dep_unit_impl.hh
M src/cpu/o3/probe/elastic_trace.cc
M src/cpu/o3/probe/elastic_trace.hh
M src/cpu/o3/probe/simple_trace.cc
M src/cpu/o3/probe/simple_trace.hh
M src/cpu/o3/regfile.cc
M src/cpu/o3/regfile.hh
M src/cpu/o3/rename.cc
M src/cpu/o3/rename.hh
M src/cpu/o3/rename_impl.hh
M src/cpu/o3/rename_map.cc
M src/cpu/o3/rename_map.hh
M src/cpu/o3/rob.cc
M src/cpu/o3/rob.hh
M src/cpu/o3/rob_impl.hh
M src/cpu/o3/scoreboard.cc
M src/cpu/o3/scoreboard.hh
M src/cpu/o3/store_set.cc
M src/cpu/o3/store_set.hh
M src/cpu/o3/thread_context.cc
M src/cpu/o3/thread_context.hh
M src/cpu/o3/thread_context_impl.hh
M src/cpu/o3/thread_state.hh
66 files changed, 330 insertions(+), 56 deletions(-)


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/16950
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I4a9ce60b94937fb8d8fe8d0b35d92819feb7037f
Gerrit-Change-Number: 16950
Gerrit-PatchSet: 4
Gerrit-Owner: Andrea Mondelli <andrea.monde...@ucf.edu>
Gerrit-Reviewer: Andrea Mondelli <andrea.monde...@ucf.edu>
Gerrit-Reviewer: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-CC: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-CC: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to