Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/25143 )
Change subject: cpu: Remove the ancient do_quiesce config option.
......................................................................
cpu: Remove the ancient do_quiesce config option.
This option has existed for a very long time, defaults to True, and is
not used in any of the checked in configs. It enables the "quiesce"
mechanism, originally just pseudo instructions, and it's not clear
why you'd ever want to turn it off.
Change-Id: I92c7e5af22157e8435c7326634857d30bb5d7254
---
M src/cpu/BaseCPU.py
M src/cpu/thread_context.cc
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/src/cpu/BaseCPU.py b/src/cpu/BaseCPU.py
index 57f0f2f..3262418 100644
--- a/src/cpu/BaseCPU.py
+++ b/src/cpu/BaseCPU.py
@@ -164,7 +164,6 @@
"enable statistics pseudo instructions")
profile = Param.Latency('0ns', "trace the kernel stack")
- do_quiesce = Param.Bool(True, "enable quiesce instructions")
wait_for_remote_gdb = Param.Bool(False,
"Wait for a remote GDB connection");
diff --git a/src/cpu/thread_context.cc b/src/cpu/thread_context.cc
index f8c422c..bebfe91 100644
--- a/src/cpu/thread_context.cc
+++ b/src/cpu/thread_context.cc
@@ -132,9 +132,6 @@
void
ThreadContext::quiesce()
{
- if (!getCpuPtr()->params()->do_quiesce)
- return;
-
DPRINTF(Quiesce, "%s: quiesce()\n", getCpuPtr()->name());
suspend();
@@ -148,9 +145,6 @@
{
BaseCPU *cpu = getCpuPtr();
- if (!cpu->params()->do_quiesce)
- return;
-
EndQuiesceEvent *quiesceEvent = getQuiesceEvent();
cpu->reschedule(quiesceEvent, resume, true);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/25143
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I92c7e5af22157e8435c7326634857d30bb5d7254
Gerrit-Change-Number: 25143
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
