Jason Lowe-Power has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/4881 )

Change subject: tests: Fix hello.c test program
......................................................................

tests: Fix hello.c test program

Update the hello test to have a sane return code.

Change-Id: I9576b71ee995d8aa410c4ed19d44cc4e9fad10ee
Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/4881
Reviewed-by: Nikos Nikoleris <nikos.nikole...@arm.com>
Reviewed-by: Anthony Gutierrez <anthony.gutier...@amd.com>
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Reviewed-by: Gabe Black <gabebl...@google.com>
Maintainer: Anthony Gutierrez <anthony.gutier...@amd.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
---
M tests/test-progs/hello/src/hello.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
  Nikos Nikoleris: Looks good to me, approved
  Anthony Gutierrez: Looks good to me, approved; Looks good to me, approved
  Gabe Black: Looks good to me, approved



diff --git a/tests/test-progs/hello/src/hello.c b/tests/test-progs/hello/src/hello.c
index be6ec83..4488f4e 100644
--- a/tests/test-progs/hello/src/hello.c
+++ b/tests/test-progs/hello/src/hello.c
@@ -30,8 +30,9 @@

 #include <stdio.h>

-int main()
+int main(int argc, char* argv[])
 {
     printf("Hello world!\n");
+    return 0;
 }


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/4881
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I9576b71ee995d8aa410c4ed19d44cc4e9fad10ee
Gerrit-Change-Number: 4881
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Anthony Gutierrez <anthony.gutier...@amd.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to