[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Gabe Black via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/58633 On Tue, Apr 5, 2022 at 7:52 PM Jason Lowe-Power wrote: > That sounds like a great middle ground. > > We could *probably* drop support for 18.04 in v22.0, but we should have a > broader discussion and make sure that's our intention. It's

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Jason Lowe-Power via gem5-dev
That sounds like a great middle ground. We could *probably* drop support for 18.04 in v22.0, but we should have a broader discussion and make sure that's our intention. It's probably not great to drop support for an OS to get the nightly tests to pass :). Cheers, Jason On Tue, Apr 5, 2022 at 3:4

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Gabe Black via gem5-dev
Well, in that case, we could detect version 3.0.1 (there is a function to get the version I believe) and do the monkey patch they suggest in the email. The fix was just adding that little function they show, which did not exist at all in version 3.0.1. I would have to look up exactly how you monkey

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Bobby Bruce via gem5-dev
I think we need to have a little discussion on this. The problem with increasing the scons version is we support Ubuntu 18.04 (Official end-of-support not until April 2023) which if you run `apt install scons` will give you v3.0.1. So, increasing this the scons version requirements will hurt these

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Gabe Black via gem5-dev
The bug in SCons was fixed in version 3.0.2. I have a CL which updates the required version here: https://gem5-review.googlesource.com/c/public/gem5/+/58629 I'm assuming some docker configuration something will need to be updated to use SCons version 3.0.2 instead of the 3.0.1 it seems to be usin

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Gabe Black via gem5-dev
I think this is actually a bug in SCons. This docker image seems to be using the minimum version of it we support, which I think is where the problem is coming from and not the compiler versions. There is a "fix"/workaround in this email thread which I haven't tried yet, and which is a bit of a hac

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-05 Thread Gabe Black via gem5-dev
Yes, I'll take a look. Gabe On Mon, Apr 4, 2022 at 3:02 PM Bobby Bruce wrote: > I don't fully understand the issue, but after doing a bisect, the commit > causing these issues is > https://gem5-review.googlesource.com/c/public/gem5/+/58356. > > To reproduce locally: > > ``` > docker run -u $UID

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-04 Thread Bobby Bruce via gem5-dev
I don't fully understand the issue, but after doing a bisect, the commit causing these issues is https://gem5-review.googlesource.com/c/public/gem5/+/58356. To reproduce locally: ``` docker run -u $UID:$GID --rm -v $(pwd):$(pwd) -w $(pwd) gcr.io/gem5-test/clang-version-9 python3 /usr/bin/scons bu

[gem5-dev] Re: Build failed in Jenkins: compiler-checks #189

2022-04-01 Thread Jason Lowe-Power via gem5-dev
Interesting errors. See https://jenkins.gem5.org/job/compiler-checks/189/artifact/compile-test-out/clang-version-9/ for more info. I think this is a scons error, as it looks like python. scons: *** [build/RISCV/gem5.opt] TypeError `unhashable type: 'Literal'' trying to evaluate `${_concat(RPATHPRE