[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Jason Lowe-Power via gem5-dev
Hi all, Generally, I think that any code that doesn't have tests and we are not actively supporting should be removed. We can always resurrect it with about the same amount of work as getting it up to date today. Plus, we can now say "the code is available in gem5-20." We have an extremely lean d

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Steve Reinhardt via gem5-dev
I assume this is leftover from Ali's thesis, which sadly did not take the world by storm as it deserved to. So I expect he'd be OK with us getting rid of it, as would I. Steve On Wed, Aug 19, 2020 at 8:57 AM Jason Lowe-Power wrote: > Hi all, > > Generally, I think that any code that doesn't ha

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Gabe Black via gem5-dev
Since everybody is in agreement so far, I'll probably put together a CL in the next day or two to remove this code. I'll add everybody to the review and wait a little bit just to make sure there aren't any last minute objections. Gabe On Wed, Aug 19, 2020 at 11:05 AM Steve Reinhardt wrote: > I

[gem5-dev] Re: Remove CP annotation support?

2020-08-19 Thread Gabe Black via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/32954 On Wed, Aug 19, 2020 at 7:57 PM Gabe Black wrote: > Since everybody is in agreement so far, I'll probably put together a CL in > the next day or two to remove this code. I'll add everybody to the review > and wait a little bit just to ma