[gem5-dev] Re: de-templating the O3 CPU

2021-03-22 Thread Gabe Black via gem5-dev
03:20 > > To: Jason Lowe-Power > > Cc: gem5 Developer List ; Giacomo Travaglini > > > > Subject: Re: [gem5-dev] Re: de-templating the O3 CPU > > > > People seemed pretty enthusiastic for this series of CLs, but I haven't > been > > able to get revie

[gem5-dev] Re: de-templating the O3 CPU

2021-03-22 Thread Giacomo Travaglini via gem5-dev
Lowe-Power > Cc: gem5 Developer List ; Giacomo Travaglini > > Subject: Re: [gem5-dev] Re: de-templating the O3 CPU > > People seemed pretty enthusiastic for this series of CLs, but I haven't been > able to get reviews for it... > > https://gem5-review.googlesource.com/c

[gem5-dev] Re: de-templating the O3 CPU

2021-03-21 Thread Gabe Black via gem5-dev
People seemed pretty enthusiastic for this series of CLs, but I haven't been able to get reviews for it... https://gem5-review.googlesource.com/c/public/gem5/+/42094 On Wed, Mar 3, 2021 at 9:15 AM Gabe Black wrote: > Series of 28 CLs, ends here: > > https://gem5-review.googlesource.com/c/public

[gem5-dev] Re: de-templating the O3 CPU

2021-03-03 Thread Gabe Black via gem5-dev
Series of 28 CLs, ends here: https://gem5-review.googlesource.com/c/public/gem5/+/42120 On Mon, Mar 1, 2021 at 8:50 AM Jason Lowe-Power wrote: > Hey Gabe, > > I love this idea! It would be nice if you could document the code as you > go, too. It could serve as a good learning tool in the future

[gem5-dev] Re: de-templating the O3 CPU

2021-03-01 Thread Jason Lowe-Power via gem5-dev
Hey Gabe, I love this idea! It would be nice if you could document the code as you go, too. It could serve as a good learning tool in the future. Cheers, Jason On Mon, Mar 1, 2021 at 7:56 AM Giacomo Travaglini via gem5-dev < gem5-dev@gem5.org> wrote: > +2, +1, Merged > > 😊 > > Giacomo > > > ---

[gem5-dev] Re: de-templating the O3 CPU

2021-03-01 Thread Giacomo Travaglini via gem5-dev
+2, +1, Merged 😊 Giacomo > -Original Message- > From: Gabe Black via gem5-dev > Sent: 27 February 2021 10:13 > To: gem5 Developer List > Cc: Gabe Black > Subject: [gem5-dev] de-templating the O3 CPU > > Hi folks. The O3 CPU uses templates pretty heavily, I think nominally to make > i

[gem5-dev] Re: de-templating the O3 CPU

2021-03-01 Thread Gabe Black via gem5-dev
Hi Nathanael, I intend to split it into multiple steps, if nothing else just to make reviewing the changes more feasible. Gabe On Mon, Mar 1, 2021 at 1:51 AM Nathanael Premillieu < nathanael.premill...@huawei.com> wrote: > Hi Gabe, > > > > I totally agree with you on this. > > I think it’s also

[gem5-dev] Re: de-templating the O3 CPU

2021-03-01 Thread Nathanael Premillieu via gem5-dev
Hi Gabe, I totally agree with you on this. I think it’s also quite a blocker when learning gem5 as it makes the code difficult to follow and understand. Do you intend to do it as one big patch or split that into several steps (if that’s possible)? Thanks, Nathanael From: Gabe Black via gem5-de