Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/ --- (Updated June 11, 2013, 9:02 a.m.) Review request for Default. Description (updat

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Steve Reinhardt
> On June 11, 2013, 7:03 a.m., Steve Reinhardt wrote: > > Same comments as before: (1) please append to rather than replace existing > > copyrights and (2) why not just merge this with the previous one. > > Andreas Hansson wrote: > The replacing here was based on the fact that nothing of th

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Andreas Hansson
> On June 11, 2013, 7:03 a.m., Steve Reinhardt wrote: > > Same comments as before: (1) please append to rather than replace existing > > copyrights and (2) why not just merge this with the previous one. The replacing here was based on the fact that nothing of the original file is left. Do you

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/#review4419 --- Ship it! Same comments as before: (1) please append to rather than repla

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/#review4413 --- Ship it! LGTM - Andreas Sandberg On June 6, 2013, 2:33 p.m., Andreas

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-11 Thread Andreas Sandberg
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/#review4414 --- Ship it! LGTM - Andreas Sandberg On June 6, 2013, 2:33 p.m., Andreas

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-07 Thread Nilay Vaish
On Fri, 7 Jun 2013, Andreas Hansson wrote: On June 7, 2013, 5:52 a.m., Nilay Vaish wrote: Seems fine. Btw, it would be great if we could do the same with the .*-ruby configs, but I am not quite sure how to achieve that. Any ideas? I'll take a look over the weekend and get back to you.

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-07 Thread Andreas Hansson
> On June 7, 2013, 5:52 a.m., Nilay Vaish wrote: > > Seems fine. Btw, it would be great if we could do the same with the .*-ruby configs, but I am not quite sure how to achieve that. Any ideas? - Andreas --- This is an automatically ge

Re: [gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-07 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/#review4401 --- Seems fine. - Nilay Vaish On June 6, 2013, 2:33 p.m., Andreas Hansson

[gem5-dev] Review Request: config: Use BaseSESystem in multi-processor regressions

2013-06-06 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1902/ --- Review request for Default. Description --- Changeset 9758:47d9b6068c50 --