-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Andreas Hansson
via gem5-dev
Sent: 01 July 2014 18:46
To: gem5 Developer List
Subject: Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model
Hi Steve,
Just to chime in here. There are definitely
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/#review5171
---
Last chance for comments?
- Ali Saidi
On June 17, 2014, 5:03 p.m.,
Give me a chance... I haven't had time to go over Andrew's responses
carefully.
I appreciate the changes you've made so far, Andrew. I'm still not
convinced that Ticked needs to be a separate class though. What's the
point of an interface class when the only use of the interface is in
Subject: Re: [gem5-dev] Review Request 2279: cpu: `Minor' in-order CPU model
Give me a chance... I haven't had time to go over Andrew's responses
carefully.
I appreciate the changes you've made so far, Andrew. I'm still not
convinced that Ticked needs to be a separate class though. What's
) the single instance of TickedObject in
Minor.
- Andrew
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Steve
Reinhardt via gem5-dev
Sent: 01 July 2014 17:55
To: gem5 Developer List
Cc: Ali Saidi
Subject: Re: [gem5-dev] Review Request 2279: cpu
instance of TickedObject in
Minor.
- Andrew
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Steve
Reinhardt via gem5-dev
Sent: 01 July 2014 17:55
To: gem5 Developer List
Cc: Ali Saidi
Subject: Re: [gem5-dev] Review Request 2279: cpu: `Minor
On June 4, 2014, 1:15 p.m., Steve Reinhardt wrote:
src/cpu/minor/cpu.hh, line 88
http://reviews.gem5.org/r/2279/diff/1/?file=39833#file39833line88
I don't know why, and I know it's not in the style guide, but all the
gem5 code I've seen (or written) has the colon at the beginning
On June 4, 2014, 8:15 p.m., Steve Reinhardt wrote:
src/cpu/minor/Expr.py, line 48
http://reviews.gem5.org/r/2279/diff/1/?file=39827#file39827line48
This is pretty interesting... it would be nice to generalize this
capability and not make it Minor-specific
Andrew Bardsley
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/
---
(Updated June 17, 2014, 5:03 p.m.)
Review request for Default.
Repository: gem5
On June 4, 2014, 8:15 p.m., Steve Reinhardt wrote:
Nice! I didn't have time to read all the code closely, but I did notice a
few things, and wanted to give feedback before I forgot.
Basically the comments boil down to three things:
1. There are several pieces (Named,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/#review5125
---
Nice! I didn't have time to read all the code closely, but I did notice
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2279/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
12 matches
Mail list logo
