Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On July 17, 2014, 10:35 a.m., Andreas Sandberg wrote: > > I'm sorry I didn't spot this earlier, but it seems like you forgot to > > include the ethernet device's interrupt in the MP table. See the interrupt > > declaration for pci_dev4_inta for an example. Without that entry, Linux > > won't

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5206 --- There is still something to do with x86 ethernet support: When using atom

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On July 17, 2014, 9:35 a.m., Andreas Sandberg wrote: > > I'm sorry I didn't spot this earlier, but it seems like you forgot to > > include the ethernet device's interrupt in the MP table. See the interrupt > > declaration for pci_dev4_inta for an example. Without that entry, Linux > > won't

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5200 --- I'm sorry I didn't spot this earlier, but it seems like you forgot to inc

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/ --- (Updated July 17, 2014, 4:35 a.m.) Review request for Default. Changes --- R

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

On 16/07/14 11:01, Jiuyue Ma via gem5-dev wrote: On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote: Could you split this into two (or potentially three) different patches? The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP. As far as I'm concerned that particular par

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote: > > Could you split this into two (or potentially three) different patches? > > > > The PCI/ISA bus ID fixes look fine and should definitely go upstream ASAP. > > As far as I'm concerned that particular part of the patch can be submitted >

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On July 15, 2014, 1:26 p.m., Andreas Sandberg wrote: > > configs/common/FSConfig.py, line 431 > > > > > > I might be wrong here, but I think the InterruptLine is actually the > > interrupt line as seen by the APIC. It doe

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5190 --- Could you split this into two (or potentially three) different patches?

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On June 17, 2014, 2:54 p.m., Andreas Hansson wrote: > > configs/common/FSConfig.py, line 429 > > > > > > It would be good to add a line describing where the values come from. Change InterruptLine from IRQ13(reserved for c

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/ --- (Updated June 18, 2014, 1:42 a.m.) Review request for Default. Changes --- c

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

> On June 17, 2014, 2:54 p.m., Andreas Hansson wrote: > > configs/common/FSConfig.py, line 348 > > > > > > I do not understand why this is not covered by the last statement, i.e. > > the Pci config space until the end of 64

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5139 --- configs/common/FSConfig.py

Re: [gem5-dev] Review Request 2301: config: add ethernet support for x86 fullsystem

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2301/#review5136 --- configs/common/FSConfig.py