Re: [gem5-dev] Review Request 2411: syscall emulation: devirtualize BaseBufferArg methods

2014-09-24 Thread Steve Reinhardt via gem5-dev
> On Sept. 24, 2014, 4:09 a.m., Andreas Hansson wrote: > > src/sim/syscall_emul_buf.hh, line 73 > > > > > > Are there classes inheriting from this? If so, gcc 4.7 and beyond will > > be unhappy about removing the virtual key

Re: [gem5-dev] Review Request 2411: syscall emulation: devirtualize BaseBufferArg methods

2014-09-24 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2411/#review5354 --- src/sim/syscall_emul_buf.hh

Re: [gem5-dev] Review Request 2411: syscall emulation: devirtualize BaseBufferArg methods

2014-09-24 Thread Ali Saidi via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2411/#review5351 --- Ship it! Ship It! - Ali Saidi On Sept. 23, 2014, 7:47 p.m., Steve Rei

[gem5-dev] Review Request 2411: syscall emulation: devirtualize BaseBufferArg methods

2014-09-23 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2411/ --- Review request for Default. Repository: gem5 Description --- Changeset 10414