Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-12-04 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5617 --- Ship it! Ship It! - Nilay Vaish On Nov. 23, 2014, 7:26 a.m., Gabe Bla

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-12-03 Thread Gabe Black via gem5-dev
> On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > I do not see much value though, but I am fine with patch. > > Gabe Black wrote: > The ChromeOS kernel needs lots of command line arguments, both to > configure the kernel and to leave information for the system at large. This > is so we

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-12-01 Thread Gabe Black via gem5-dev
> On Nov. 30, 2014, 6:38 p.m., Nilay Vaish wrote: > > I do not see much value though, but I am fine with patch. The ChromeOS kernel needs lots of command line arguments, both to configure the kernel and to leave information for the system at large. This is so we don't have to have a custom hac

Re: [gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-11-30 Thread Nilay Vaish via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/#review5591 --- I do not see much value though, but I am fine with patch. configs/commo

[gem5-dev] Review Request 2524: config: Add two options for setting the kernel command line.

2014-11-22 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2524/ --- Review request for Default. Repository: gem5 Description --- Changeset 10561