[gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2540/ --- Review request for Default. Repository: gem5 Description --- Changeset 10568

Re: [gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2540/#review5627 --- Ship it! Just minor stuff, no need to repost IMO src/base/remote_gdb.c

Re: [gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2540/#review5631 --- src/base/remote_gdb.hh

Re: [gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

> On Dec. 4, 2014, 6:59 p.m., Steve Reinhardt wrote: > > src/base/remote_gdb.hh, line 118 > > > > > > I'd be tempted to rename the other Event class rather than have to > > disambiguate here, but I understand if you don't w

Re: [gem5-dev] Review Request 2540: sim: Ensure GDB interrupts the simulation at an instruction boundary.

> On Dec. 4, 2014, 6:50 p.m., Steve Reinhardt wrote: > > src/base/remote_gdb.cc, line 2 > > > > > > date? Fixed. > On Dec. 4, 2014, 6:50 p.m., Steve Reinhardt wrote: > > src/base/remote_gdb.cc, line 255 > >