[gem5-dev] Review Request 2591: x86: Enable three bits in the FamilyModelStepping ECX CPUID bitfield.

2014-12-22 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2591/ --- Review request for Default. Repository: gem5 Description --- Changeset 10608

Re: [gem5-dev] Review Request 2591: x86: Enable three bits in the FamilyModelStepping ECX CPUID bitfield.

2014-12-22 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2591/#review5706 --- Ship it! Fine with me, assuming that our implementations of those featur

Re: [gem5-dev] Review Request 2591: x86: Enable three bits in the FamilyModelStepping ECX CPUID bitfield.

2014-12-22 Thread Gabe Black via gem5-dev
> On Dec. 23, 2014, 5:19 a.m., Steve Reinhardt wrote: > > Fine with me, assuming that our implementations of those features are > > indeed complete. They aren't, but I think the bits that are missing will trigger warnings. - Gabe --- T

Re: [gem5-dev] Review Request 2591: x86: Enable three bits in the FamilyModelStepping ECX CPUID bitfield.

2014-12-23 Thread Steve Reinhardt via gem5-dev
> On Dec. 22, 2014, 9:19 p.m., Steve Reinhardt wrote: > > Fine with me, assuming that our implementations of those features are > > indeed complete. > > Gabe Black wrote: > They aren't, but I think the bits that are missing will trigger warnings. OK, good enough. Thanks. - Steve -