[gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/ --- Review request for Default. Repository: gem5 Description --- Changeset 10706

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/#review5899 --- I like the idea of having a single global limit event, with a function to

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 5:17 p.m., Steve Reinhardt wrote: > > I like the idea of having a single global limit event, with a function to > > access it so clients can check whether that's what was hit. > > > > However I don't think the GlobalSimLoopExitEvent should be a singleton, as > > there are a

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 9:17 a.m., Steve Reinhardt wrote: > > I like the idea of having a single global limit event, with a function to > > access it so clients can check whether that's what was hit. > > > > However I don't think the GlobalSimLoopExitEvent should be a singleton, as > > there are a

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 5:17 p.m., Steve Reinhardt wrote: > > I like the idea of having a single global limit event, with a function to > > access it so clients can check whether that's what was hit. > > > > However I don't think the GlobalSimLoopExitEvent should be a singleton, as > > there are a

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 9:17 a.m., Steve Reinhardt wrote: > > I like the idea of having a single global limit event, with a function to > > access it so clients can check whether that's what was hit. > > > > However I don't think the GlobalSimLoopExitEvent should be a singleton, as > > there are a

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 5:17 p.m., Steve Reinhardt wrote: > > I like the idea of having a single global limit event, with a function to > > access it so clients can check whether that's what was hit. > > > > However I don't think the GlobalSimLoopExitEvent should be a singleton, as > > there are a

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/ --- (Updated Feb. 25, 2015, 1:16 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/ --- (Updated Feb. 25, 2015, 1:22 a.m.) Review request for Default. Changes --- C

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/#review5913 --- Looks much better, thanks... just one more little thing src/sim/sim_eve

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 25, 2015, 4:26 a.m., Steve Reinhardt wrote: > > src/sim/sim_events.hh, line 77 > > > > > > seems like it would be safer just to say: > > > > if (scheduled()) > > deschedule(); > > > >

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 8:26 p.m., Steve Reinhardt wrote: > > src/sim/sim_events.hh, line 77 > > > > > > seems like it would be safer just to say: > > > > if (scheduled()) > > deschedule(); > > > >

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 25, 2015, 4:26 a.m., Steve Reinhardt wrote: > > src/sim/sim_events.hh, line 77 > > > > > > seems like it would be safer just to say: > > > > if (scheduled()) > > deschedule(); > > > >

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 24, 2015, 8:26 p.m., Steve Reinhardt wrote: > > src/sim/sim_events.hh, line 77 > > > > > > seems like it would be safer just to say: > > > > if (scheduled()) > > deschedule(); > > > >

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/ --- (Updated March 3, 2015, 11:43 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

> On Feb. 25, 2015, 4:26 a.m., Steve Reinhardt wrote: > > src/sim/sim_events.hh, line 77 > > > > > > seems like it would be safer just to say: > > > > if (scheduled()) > > deschedule(); > > > >

Re: [gem5-dev] Review Request 2665: sim: Reuse the same limit_event in simulate()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2665/#review5933 --- Ship it! Thanks for the changes! - Steve Reinhardt On March 3, 2015,