Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-27 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/#review5980 --- Looks much nicer. Thanks for the changes! Sorry for the long wait for

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-27 Thread Curtis Dunham
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- (Updated March 27, 2015, 10:27 p.m.) Review request for Default. Repository:

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-27 Thread Curtis Dunham
On March 27, 2015, 6:28 p.m., Steve Reinhardt wrote: ext/sst/tests/test6_arm_4c.py, line 93 http://reviews.gem5.org/r/2668/diff/5/?file=43877#file43877line93 so does this require you to edit the file to replace /XXX/abs-path-to? couldn't this path be read from an environment

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- (Updated March 4, 2015, 12:56 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- (Updated March 4, 2015, 1:04 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- (Updated March 4, 2015, 12:47 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- (Updated March 4, 2015, 1:07 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
On Feb. 25, 2015, 4:32 p.m., Steve Reinhardt wrote: Took me longer to review this just because I'm not sure what to think of it. It's not pretty, but I don't have better ideas, so it's hard to object. One thing that bothers me is that, while it's noble to try and generalize

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-03-03 Thread Curtis Dunham via gem5-dev
On Feb. 25, 2015, 4:32 p.m., Steve Reinhardt wrote: Took me longer to review this just because I'm not sure what to think of it. It's not pretty, but I don't have better ideas, so it's hard to object. One thing that bothers me is that, while it's noble to try and generalize

Re: [gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-02-25 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/#review5914 --- Took me longer to review this just because I'm not sure what to think of

[gem5-dev] Review Request 2668: config: Support full-system with SST's memory system

2015-02-20 Thread Curtis Dunham via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2668/ --- Review request for Default. Repository: gem5 Description --- Changeset