Re: [gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-28 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2775/#review6418 --- Ship it! Ship It! - Jason Power On May 11, 2015, 10:17 p.m., Tony Gut

Re: [gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-28 Thread Brad Beckmann
> On May 11, 2015, 11:48 p.m., Nilay Vaish wrote: > > Please the read the discussion we had for this patch before: > > http://reviews.gem5.org/r/1620/. I still think this is a bad idea. > > Brad Beckmann wrote: > I don't quite understand your resistence. This patch only provides more > f

Re: [gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-13 Thread Nilay Vaish
On Wed, 13 May 2015, Brad Beckmann wrote: On May 11, 2015, 11:48 p.m., Nilay Vaish wrote: Please the read the discussion we had for this patch before: http://reviews.gem5.org/r/1620/. I still think this is a bad idea. I don't quite understand your resistence. This patch only provides mo

Re: [gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-13 Thread Brad Beckmann
> On May 11, 2015, 11:48 p.m., Nilay Vaish wrote: > > Please the read the discussion we had for this patch before: > > http://reviews.gem5.org/r/1620/. I still think this is a bad idea. I don't quite understand your resistence. This patch only provides more flexibility in naming. It won't a

Re: [gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-11 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2775/#review6129 --- Please the read the discussion we had for this patch before: http://revi

[gem5-dev] Review Request 2775: slicc: isinstance bugfix

2015-05-11 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2775/ --- Review request for Default. Repository: gem5 Description --- Changeset 10832