Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/#review6718 --- Ship it! Ship It! - Steve Reinhardt On July 6, 2015, 3:43 a.m., Andre

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/ --- (Updated July 6, 2015, 11:43 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

> On July 4, 2015, 11:57 a.m., Steve Reinhardt wrote: > > So I think the Drainable class is a great idea, it's nice not to pollute > > random SimObjects with code that forces them to track what sub-objects of > > theirs need to be drained. > > > > I'm less convinced about the benefits of irrev

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

> On July 4, 2015, 7:57 p.m., Steve Reinhardt wrote: > > So I think the Drainable class is a great idea, it's nice not to pollute > > random SimObjects with code that forces them to track what sub-objects of > > theirs need to be drained. > > > > I'm less convinced about the benefits of irreve

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/#review6704 --- So I think the Drainable class is a great idea, it's nice not to pollute

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/#review6695 --- Ship it! Ship It! - Nilay Vaish On June 8, 2015, 12:13 p.m., Andreas

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

> On June 27, 2015, 6:44 p.m., Nilay Vaish wrote: > > src/python/m5/simulate.py, line 335 > > > > > > Why do we not need this resume()? Resume is now called automatically by simualte() if simulate is called on a drained sy

Re: [gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/#review6632 --- I'll read the patch once more after you have answered my queries, src/p

[gem5-dev] Review Request 2874: sim: Decouple draining from the SimObject hierarchy

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2874/ --- Review request for Default. Repository: gem5 Description --- Changeset 10872