Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

> On Nov. 3, 2015, 9:37 p.m., Steve Reinhardt wrote: > > src/dev/io_device.cc, line 60 > > > > > > out of scope for now, but just a thought: arguably this zeroing of the > > delay fields should probably take place in Packet:

Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3172/#review7486 --- Ship it! Ship It! - Steve Reinhardt On Nov. 4, 2015, 1:34 a.m., Andre

Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3172/ --- (Updated Nov. 4, 2015, 9:34 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

> On Nov. 4, 2015, 5:37 a.m., Steve Reinhardt wrote: > > src/dev/io_device.cc, line 60 > > > > > > out of scope for now, but just a thought: arguably this zeroing of the > > delay fields should probably take place in Packet:

Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

> On Nov. 4, 2015, 5:37 a.m., Steve Reinhardt wrote: > > src/dev/io_device.cc, line 59 > > > > > > minor, but 'additional_latency' is rather nondescript. maybe > > 'transmission_delay' or 'receive_delay' or 'receive_latency'

Re: [gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3172/#review7471 --- src/dev/io_device.cc (line 59)

[gem5-dev] Review Request 3172: mem: Use the packet delays and do not just zero them out

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3172/ --- Review request for Default. Repository: gem5 Description --- Changeset 11188