Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- (Updated Dec. 18, 2015, 8:57 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

On Dec. 3, 2015, 11:03 a.m., Boris Shingarov wrote: > > Thanks for sorting this out! Remind me to buy you a beer if we ever meet in > > person! :) > > > > Minor nits above. Don't worry about it unless you need to update for some > > other reason. Also, try and get an ACK from someone who cares

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7720 --- Ship it! I have been testing this a bit with the hello world program in

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7681 --- Ship it! src/arch/arm/remote_gdb.cc (lines 243 - 255)

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

> On Nov. 23, 2015, 11:26 p.m., Andreas Sandberg wrote: > > src/base/remote_gdb.hh, line 201 > > > > > > Make this const wrt the object. > > Boris Shingarov wrote: > And also, symmetrically, the argument to getRegs() wa

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

> On Nov. 23, 2015, 11:26 p.m., Andreas Sandberg wrote: > > src/arch/arm/remote_gdb.cc, lines 348-351 > > > > > > Won't this leak memory with the current use cases? (Actually, it seems > > like it won't work at all since a

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- (Updated Dec. 3, 2015, 9:53 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7637 --- Thanks for updating the review. I think the overall design is good, but t

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

> On Nov. 20, 2015, 9:32 a.m., Andreas Sandberg wrote: > > Looks like a good design to me. I'm currently testing it in aarch32 and it > > seems to work. There are a couple of nits below, but the code looks good > > overall. > > > > There is one ARM-specific high-level issues that you will need

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- (Updated Nov. 23, 2015, 9:09 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7617 --- Looks like a good design to me. I'm currently testing it in aarch32 and i

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

> On Nov. 14, 2015, 6:26 p.m., Ali Saidi wrote: > > I've added descriptions for the abstract class and the methods which each architecture should implement. If the general shape of things look ok to you, I will submit the new implementations for the rest of the platforms. - Boris -

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- (Updated Nov. 16, 2015, 12:19 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/#review7584 --- src/base/remote_gdb.hh (line 156)

[gem5-dev] Review Request 3207: arm: remote GDB: rationalize structure of register offsets

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3207/ --- Review request for Default. Repository: gem5 Description --- arm: remote GDB