Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/#review8830 --- Ship it! Ship it! Thanks for the fixes! - Gabor Dozsa On Oct. 12,

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/ --- (Updated Oct. 12, 2016, 3:51 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Sept. 9, 2016, 2:53 p.m., Gabor Dozsa wrote: > > src/dev/net/dist_iface.cc, line 71 > > > > > > This change effectively disables the use of the start_tick parameter. > > It is because 'nextAt' is overwritten in

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Sept. 9, 2016, 2:53 p.m., Gabor Dozsa wrote: > > I like the idea of starting the sync on a pseudo op very much. I cannot see > > the usefulness of stopping the sync after it started though. Do you have a > > use case in mind? > > > > I have a few comments below (mainly minor nits). > >

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Sept. 9, 2016, 2:53 p.m., Gabor Dozsa wrote: > > I like the idea of starting the sync on a pseudo op very much. I cannot see > > the usefulness of stopping the sync after it started though. Do you have a > > use case in mind? > > > > I have a few comments below (mainly minor nits). > >

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Sept. 9, 2016, 2:53 p.m., Gabor Dozsa wrote: > > I like the idea of starting the sync on a pseudo op very much. I cannot see > > the usefulness of stopping the sync after it started though. Do you have a > > use case in mind? > > > > I have a few comments below (mainly minor nits). > >

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Aug. 30, 2016, 3:39 p.m., Michael LeBeane wrote: > > Any comments on this patch? > > Mohammad Alian wrote: > I just have some high level question before goring through the code: > > Can you explain the use-case for this patch? Probably it means to speed > up the simulation

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/#review8713 --- I like the idea of starting the sync on a pseudo op very much. I cannot

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

> On Aug. 30, 2016, 3:39 p.m., Michael LeBeane wrote: > > Any comments on this patch? I just have some high level question before goring through the code: Can you explain the use-case for this patch? Probably it means to speed up the simulation but why do we need to switch on/off

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/#review8693 --- Any comments on this patch? - Michael LeBeane On Aug. 4, 2016, 4:51

[gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/ --- Review request for Default. Repository: gem5 Description --- Changeset