Re: [gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Tony Gutierrez
> On Oct. 13, 2016, 2:50 p.m., Jason Lowe-Power wrote: > > src/mem/ruby/system/GPUCoalescer.cc, line 878 > > > > > > IIRC, you can do `reqCoalescer[line_addr].emplace_back(pkt, > > primary_type, secondary_type);` to avoid a

Re: [gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3664/#review8839 --- Ship it! src/mem/ruby/system/GPUCoalescer.cc (line 877)

Re: [gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3664/#review8838 --- Ship it! Nice fix, this is much clearer and seems like generally safer c

[gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3664/ --- Review request for Default. Repository: gem5 Description --- Changeset 11855