Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2017-02-23 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9470 --- Ship it! Ship It! - Alexandru Dutu On Feb. 23, 2017, 7:40 p.m., Brand

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2017-02-23 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9464 --- Ship it! Ship It! - Michael LeBeane On Feb. 23, 2017, 7:40 p.m., Bran

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2017-02-23 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/ --- (Updated Feb. 23, 2017, 7:40 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2017-02-17 Thread Brandon Potter
> On Nov. 15, 2016, 8:17 p.m., Michael LeBeane wrote: > > src/arch/x86/process.cc, line 1100 > > > > > > Same here. This isn't really related to this patch so I'll create a new patch for this copy constructor. > On Nov.

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-23 Thread Brandon Potter
> On Nov. 15, 2016, 2:03 a.m., Alexandru Dutu wrote: > > src/sim/process.cc, line 148 > > > > > > Does memState need to be dynamically allocated? Yes, the memState need to be able to be dynamically created and shared betwee

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-15 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9076 --- In general, I think this patch could be improved by making better use of

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-14 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/#review9071 --- src/mem/page_table.cc (line 110)

Re: [gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-14 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/ --- (Updated Nov. 14, 2016, 8:37 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3696: syscall_emul: [PATCH 15/22] add clone/execve for threading and multiprocess simulations

2016-11-07 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3696/ --- Review request for Default. Repository: gem5 Description --- Changeset 11704